aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjgeboski <jgeboski@gmail.com>2016-01-09 12:24:24 -0500
committerjgeboski <jgeboski@gmail.com>2016-01-09 12:24:24 -0500
commitad7193f7f5eaf1164ecf6cbab1989f75d9f35fb9 (patch)
tree54abf39bb6dbe0fa03cedc89defd7ae378d72da7
parent1952710b5c31c9e6a4c5f2e431e75db9ca5f9f0d (diff)
downloadbitlbee-facebook-ad7193f7f5eaf1164ecf6cbab1989f75d9f35fb9.tar.gz
bitlbee-facebook-ad7193f7f5eaf1164ecf6cbab1989f75d9f35fb9.tar.bz2
bitlbee-facebook-ad7193f7f5eaf1164ecf6cbab1989f75d9f35fb9.tar.xz
facebook-api: fixed incorrect handling of unknown XMA types
This fixes an improper GError propagation, which not is only incorrect, but also has no effect. This ends up leading to the unsupported XMA message being ignored without any notice to the user.
-rw-r--r--facebook/facebook-api.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/facebook/facebook-api.c b/facebook/facebook-api.c
index 4344cf8..e7a8409 100644
--- a/facebook/facebook-api.c
+++ b/facebook/facebook-api.c
@@ -1297,9 +1297,9 @@ fb_api_xma_parse(FbApi *api, const gchar *body, JsonNode *root, GError **error)
url = fb_json_values_next_str(values, NULL);
if ((str == NULL) || (url == NULL)) {
- g_propagate_error(error, err);
+ text = g_strdup("<Unsupported Attachment>");
g_object_unref(values);
- return NULL;
+ return text;
}
if (g_strcmp0(str, "ExternalUrl") == 0) {