Fix use-after-free when leaving invited (temporary) channels

Trac ticket 1229, https://bugs.bitlbee.org/bitlbee/ticket/1229

This one is complicated. See the trac ticket for details.

Relevant commits: cc20520 6963230 664bac3 - second one fixed the same
issue, third one reverted it, this one takes a different approach.

1 files changed, 5 insertions, 2 deletions

diff --git a/irc_im.c b/irc_im.c
index 46699747..2d569bbb 100644
--- a/irc_im.c
+++ b/irc_im.c
@@ -862,8 +862,11 @@ static gboolean bee_irc_channel_chat_part(irc_channel_t *ic, const char *msg)
 		c->ic->acc->prpl->chat_leave(c);
 	}
 
-	/* Remove the reference. We don't need it anymore. */
-	ic->data = NULL;
+	if (!(ic->flags & IRC_CHANNEL_TEMP)) {
+		/* Remove the reference.
+		 * We only need it for temp channels that are being freed */
+		ic->data = NULL;
+	}
 
 	return TRUE;
 }