diff options
| author | dequis <dx@dxzone.com.ar> | 2015-02-22 19:04:08 -0300 |
|---|---|---|
| committer | dequis <dx@dxzone.com.ar> | 2015-02-22 19:44:40 -0300 |
| commit | 05816dd33396f92b7d9348a2acd18537ac18fa1e (patch) | |
| tree | 980ad6ad4c5efc040d19ec09ed1cecc0104b17eb /protocols/yahoo/yahoo.c | |
| parent | 91f06e5535d3711da06533495b197c1b8e545f82 (diff) | |
coverity: Fix some (harmless?) use-after-free with g_slist_remove()
These were passing a pointer to a variable right after it was g_free()'d
They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.
Diffstat (limited to 'protocols/yahoo/yahoo.c')
| -rw-r--r-- | protocols/yahoo/yahoo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/protocols/yahoo/yahoo.c b/protocols/yahoo/yahoo.c index 8048ef8f..728803fb 100644 --- a/protocols/yahoo/yahoo.c +++ b/protocols/yahoo/yahoo.c @@ -732,9 +732,9 @@ void ext_yahoo_remove_handler(int id, int tag) while (l) { inp = l->data; if (inp->h == tag) { + byahoo_inputs = g_slist_remove(byahoo_inputs, inp); g_free(inp->d); g_free(inp); - byahoo_inputs = g_slist_remove(byahoo_inputs, inp); break; } l = l->next; |