| Commit message (Collapse) | Author | Age | Lines |
|---|
| ... | |
| |
|
|
|
|
|
| |
I didn't want to do the next release with a broken msn, but...
gotta be realistic.
Also featuring shameless plug.
|
| |
|
|
|
|
|
| |
Yeah ok that was dumb.
This is essentially just using a 'data' variable instead of 'l->data',
but i went ahead and cleaned up the function.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
It will get disabled automatically if the deps (xmlto and xsltproc)
are missing
Also added checks for asciidoc (a2x) for the skype plugin, which needs
it for the skyped man page, and will also get that disabled if --doc=0
is passed or if asciidoc isn't installed.
This should keep those ugly deps under control for now.
I'd like to replace them at some point with something less dumb.
|
| |
|
|
|
| |
From coverity. Would cause an invalid write if read() fails
(but open() doesn't)
|
| |
|
|
|
|
|
| |
These were passing a pointer to a variable right after it was g_free()'d
They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.
|
| | |
|
| |
|
|
|
| |
Fixes issues such as parsing "reply eo" as replying to "0e",
as reported by torrancew
|
| | |
|
| | |
|
| |
|
|
|
| |
Shouldn't affect anything, and still doesn't allow initializing
libpurple more than once, but whatever.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This segfault happened when none of the available streamhosts can be
connected to - or if at least one of them fails to connect.
Before this commit, it can be reproduced reliably by setting the "proxy"
setting of the account to nonsense, for example, this is what i used:
proxy.example.org,1.2.3.4,7777;proxy.example.com,173.194.42.65,80
jabber_bs_recv_handshake_abort() calls jabber_bs_recv_handshake(), which
is supposed to restart the handshake with the next streamhost. And it
replaced bt->tf->watch_out, which held an event ID, with a newer event
ID. So the replaced event ID doesn't get removed, and it gets called
again when its socket is closed by the timeout - and by the time that
happens, the memory is free()'d already. Boom.
The patch is simple - created jabber_bs_remove_events() to cleanup those
events, and use it before any code that expects to restart the cycle.
So basically the same as doing b_event_remove(bt->tf->watch_out).
I hope there aren't more bugs like this in this code.
|
| |
|
|
|
|
|
|
|
| |
- get_ft_by_sid()
- generate_pseudoaddr() (also uses g_compute_checksum_for_string() to
make the code shorter)
- jabber_streamhost_new()
Behavior should be the same.
|
| |
|
|
| |
them up.
|
| | |
|
| |
|
|
|
|
|
| |
Used uncrustify, with the configuration file in ./doc/uncrustify.cfg
Commit author set to "Indent <please@skip.me>" so that it's easier to
skip while doing git blame.
|
| | |
|
| |
|
|
|
|
| |
This reverts commit ce402b20d82ec323e6bd5e306de934773590742d.
See discussion in PR #10 for more details.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes behavior slightly:
- md5_init()/sha1_init() allocate a GChecksum
- md5_finish()/sha1_finish() close and free() it
- md5_digest_keep() was added (no sha1 equivalent needed)
And yes, glib has this concept of "closing" the GChecksum, which means
it can't be used anymore after g_checksum_get_digest().
jabber_cache_add() actually seems to need to do that to generate some
random-ish values, so i kept that working by adding a md5_digest_keep()
function that copies the GChecksum before it gets closed
GChecksum was introduced in glib 2.16, so the configure script version
was bumped. We were already depending on glib 2.16 accidentally
(some post-3.2.2 code uses GHashTableIter)
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
With similar commands being supported, such as INVITE, the KICK command
should be supported as well. The key motivation behind supporting KICK
is having for having a way to remove users from group chats. As of now,
there is no way for a bitlbee user to remove a user from a group chat.
With no current KICK implementation, it made using this command a prime
candidate for the UI side of this implementation. In addition, the KICK
command has been supported in the control channel as well. This is to
keep the INVITE/KICK pair consistent.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for users to be declared as being special, which does not
have any specific meaning. The meaning of being special is different
from protocol-to-protocol, which many protocols do not even implement.
This functionality is mainly geared towards a special user state which
only some protocols may actually need to define. For example, with the
third-party Steam plugin, this can be used for denoting a user which is
actively playing a game.
By default, this mode will not actually be used by any plugin. However,
it does default to the half-operator user mode.
|
| | |
|
| |\
| |
| | |
purple: add topic and name_hint to groupchats
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Allow users to specify how tweets should be displayed
3 new settings are available to set how tweets are displayed:
- twitter_format_string for normal tweets
- retweet_format_string for retweets
- reply_format_string for replies
For full documentation see the help files
|
| | |
| |
| |
| |
| |
| |
| | |
By default, "reply" prepends the username of the tweet being replied to. This
adds support for a "rawreply" command which does not prepend this username.
This is useful for "replying" to your own tweet to maintain a chain of tweets
on a singular topic.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Filter group chats allow for the ability to read the tweets of select
users without actually following the users, and/or track keywords or
hashtags. A filter group chat can have multiple users, keywords, or
hashtags. These users, keywords, or hashtags can span multiple group
chats. This allows for rather robust filter organization.
The underlying structure for the filters is based on linked list, as
using the glib hash tables requires >= glib-2.16 for sanity. Since the
glib requirement of bitlbee is only 2.14, linked list are used in order
to prevent an overly complex implementation.
The idea for this patch was inspired by Artem Savkov's "Twitter search
channels" patch.
In order to use the filter group chats, a group chat must be added to
the twitter account. The channel room name is either follow:username,
track:keyword, and/or track:#hashtag. Multiple elements can be used by
separating each element by a semicolon.
|
| | |
| |
| |
| |
| |
| | |
Also abort() if there's no /dev/urandom
See http://www.2uo.de/myths-about-urandom/ for details.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Had to move the code that adds contacts to imcb_connected to avoid
dereferencing a null im_connection.
Turns out this kind of local contact lists only applies to renamed
contacts, though. It doesn't deal with libpurple's blist.xml at all
(it could, there are APIs for it since 2.6.0)
|
| | |
| |
| |
| |
| | |
This sets the default value of 'nick' for newly created groupchats.
There is no way to set an account-wide nick.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
When bee_chat needs to check for self messages, it can call this
function to let the protocol implementation do the comparison.
In the case of jabber, sometimes the server reports a different username
after login, this one is stored in jd->internal_jid, and the one that is
used for login isn't changed
|
| | |
| |
| |
| | |
And that's enough editing of the oscar protocol code for 2015
|
| |/ |
|
| |
|
|
|
|
|
|
| |
- A few build system tweaks
- A fancy README.md
- s/.bzrignore/.gitignore/
- .travis.yml for travis-ci integration
- doc/git-bzr-rev-map for historical purposes
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
When a chat is left, prpl->chat_leave() is invoked, which is suppose
to free the groupchat. Since the data is now freed, or suppose to have
been freed, attempting to modify the data will result in bad things.
This simply removes an assignment operation, which was unneeded due to
the memory already being freed.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the auto_join channel flag set to false, the channel is still
auto-joined. This can lead to the channel being "doubly" joined if
a client previously sent a channel join request. The result of being
"doubly" joined is really undefined, but most notably memory leaks
can occur.
It also appears, based on the comment under the modified condition,
the previous condition was incorrect.
Another patch should probably implement some sort of check to ensure a
channel is not already joined, assuming the auto_join flag is enabled.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When nicks exceeded the length limit, they were cut at 24 bytes and that
sometimes left invalid utf8 at the end, which made the nick_ok()
validation fail and often broke those nicks completely.
This adds a truncate_utf8 function to cut the string at a safe place
Also, the method to deduplicate nicks when there's no more place to add
underscores was changed to add "_XX" at the end, where XX are two random
hex chars. The previous method in those cases was increasing the value
of the first character of the nick... which leads to silly and confusing
results (i.e. FacebookUser -> GacebookUser)
|
| | |
| |
| |
| |
| |
| | |
Also refactor jabber_normalize() to be UTF8 aware.
See trac ticket 1106 for more details
|
| | |
| |
| |
| |
| | |
It was checking for "Connection established" and some proxies use a
different string, such as "Tunnel established" in polipo
|
| | |
| |
| |
| | |
Both in gaim_io_connected(), visible when using an http proxy
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Allocating insufficient memory for the terminating null of the string
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
* Don't use PIE/PIC on Cygwin/Darwin unless specified as these
platforms don't support it.
* Cleanup warnings for 'make check' build.
* Fix the type issue for getsockopt calls.
* Fix enum warnings in Yahoo libs on Mac OS X.
|
| | |
| |
| |
| |
| | |
This works by setting the last_tweet hidden account setting to the ID of
the last shown tweet.
|
