aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
* purple: fix -Werror=format-string in chat settings codedequis2016-12-26-4/+2
| | | | | This one was caught by the debian build scripts in travis. I had format-security in my local cflags, not format-string. Welp.
* purple: hack to keep the purple-line auth token in the configdequis2016-12-26-1/+20
|
* purple: add support for extra groupchat settings (helps with SIPE)dequis2016-12-26-0/+93
| | | | | | | | | | | | | | | | | This adds channel settings prefixed by purple_. For example jabber now has purple_room and purple_server which are decomposed variants of our own 'room' setting. Okay, that doesn't sound very useful. It also adds some sync from the values returned by chat_info_defaults() - so if the plugin figures something out in there, we save it in our own settings. In the case of SIPE this adds a new setting, purple_uri, which can be set with the ma-chan:// uri for a persistent chat. This solves the issue with the SIPE plugin only knowing how to do name lookups after doing 'chat list' - now it just needs to work once, and we save the real URI in our settings.
* jabber: Workaround for servers (like slack) that send echoes without iddequis2016-12-26-4/+15
| | | | | | | | Just comparing the body of the last sent message. This isn't foolproof and sending several messages quickly can make it fail, but it's less annoying than before. The correct solution is still to fix the server. In the case of slack I still recommend using the irc gateway instead.
* Change some asserts into g_return_if_fail()dequis2016-12-26-11/+5
| | | | | | Because crashing asserts are bad, and maybe this helps fix the captures_build_path issue with debian's reproducible builds (those asserts probably include __FILE__)
* Fix some clang static analyzer warningsdequis2016-12-26-6/+6
| | | | Nothing interesting.
* [debian] Drop dependncy on net-toolsJochen Sprickerhof2016-12-26-8/+2
| | | | | See: https://lists.debian.org/debian-devel/2016/12/msg00604.html Also, this is consistent to systemd.
* nick_strip: accept null irc parameterdequis2016-12-25-1/+1
| | | | Sometimes I'm randomly reminded that we have a test suite.
* purple: Call imcb_buddy_nick_change() on a few whitelisted pluginsdequis2016-12-25-4/+40
| | | | | | | | The whitelist includes hangouts, funyahoo and icq. These plugins tend to have numeric or meaningless usernames. With this change, users don't have to do 'ac whatever set nick_format %full_name' anymore. Just sugar.
* purple: include purple plugins in the 'plugins' command listdequis2016-12-25-1/+25
|
* Refactor: Split plugin info stuff from load_plugin() into two functionsdequis2016-12-25-35/+53
|
* Add 'plugins info' subcommand, only show plugin details theredequis2016-12-25-17/+56
|
* Misc documentation updatesdequis2016-12-25-15/+52
| | | | | | | - Remove a bunch of mentions of yahoo - Remove 'smileys' topic from help index - Add 'identify_methods' help topic - Mention new commands like 'chat list' or 'plugins'
* genhelp: Slightly improve error messages on xml parse errordequis2016-12-25-1/+5
|
* Remove "Cleaning up channel, bye!" messagedequis2016-12-25-4/+0
|
* Add nick_lowercase and nick_underscores settingsdequis2016-12-25-17/+49
|
* Fix some compiler warningsdequis2016-11-28-12/+19
| | | | | | | | warn_unused_result on write() is particularly annoying. You can't just add (void) to ignore it due to gcc bug 66425. I replaced some of those with fwrite() and used a variable marked with the G_GNUC_UNUSED attribute for the writes from signal handlers.
* Include debug symbols in non-debug builds, disable stripping by defaultdequis2016-11-28-3/+3
| | | | | | | | | | | | | | | | With this commit, the difference between debug and non-debug builds is mainly the optimization level and -DDEBUG (which isn't used much) In other words: --debug=0 == CFLAGS="-g -O2 -fno-strict-aliasing" --debug=1 == CFLAGS="-g3 -DDEBUG -O0" And --strip=1 can be used to get rid of the debug symbols. This is closer to the default behavior of autotools. Should have done this forever ago, like back when bitlbee had bugs (lol)
* purple: Use roomlist_room_serialize, fixes joining jabber chatsdequis2016-11-28-3/+17
| | | | | | | The room names in 'chat list' were missing the server part. Jabber is the only prpl which implements this method as far as I can see, and it's needed to get the full name.
* Expand each (media) URL only once. Twitter likes duplication. #1275.Wilmer van der Gaast2016-11-27-3/+5
|
* Heh, oops, some error in the Twitter module still mentioned XML. Fixed.Wilmer van der Gaast2016-11-23-1/+1
| | | | | Some structs still have xml in their name but meh, at least that's not visible to the user.
* Manual merge with wilmer's approach to handling missing protocolsdequis2016-11-21-111/+67
| | | | | | | | | | | | | | | | | | | | | | | | Turns out he already implemented pretty much the same thing in the parson branch... last year. The differences between the two approaches are subtle (there aren't too many ways to do this, some lines are the exact same thing) but I decided I like his version better, so this mostly reverts a handful of my changes while keeping others. The main advantage of his approach is that no fake protocols are registered, no actual prpl functions are called, and the missing prpl is a singleton constant. New things compared to the implementation in the other branch: - The explain_unknown_protocol() function. - Fixed named chatrooms throwing a warning and losing the "account" setting when saving. See changes in irc_im.c - Fixed the "server" setting dropping when saving. See account.c Differences with my previous implementation: - Accounts with missing protocols don't autoconnect - 'account list' marks them as "(missing!)"
* protocols/unknown: Fix format-security warningdequis2016-11-19-1/+1
| | | | Which is -Werror'd in debian builds
* ...of course, i had to forget to add unknown.cdequis2016-11-19-0/+75
|
* Remove yahoo (the old protocol). Use funyahoo++ instead.dequis2016-11-19-9021/+0
| | | | | | RIP The previous commit already handled the part of telling users.
* Improve handling of unknown protocols / missing pluginsdequis2016-11-19-12/+75
| | | | | | | | | | | | | | | Instead of failing to load the config, a fake prpl is created to load the account, keep its settings, and refuse to log in with a helpful error message. Also added a new explain_unknown_protocol() function which returns text which attempts to explain why a protocol is missing, handling several typical cases, including the future removal of several dead libpurple plugins. That message is shown when logging in to a loaded account with a missing protocol and when adding a new one with 'account add', with the difference that the latter doesn't leave a placeholder fake account.
* Improve support for protocols which don't require a passworddequis2016-11-13-3/+44
| | | | | | This adds a prpl_options_t enum with flags, which mostly just brings OPT_PROTO_{NO_PASSWORD,PASSWORD_OPTIONAL} from libpurple as PRPL_OPT_{NO_PASSWORD,PASSWORD_OPTIONAL}
* purple: fix file transfer memory managementdequis2016-11-13-11/+75
| | | | | | | | | | | | | | | | This means cancelling transfers on logout to avoid crashes, keeping track of timeouts, reffing and unreffing the xfers, listening to the callbacks from UI and purple more carefully and using the correct functions to free the correct things at the correct moments. Originally intended to fix a crash triggered when the dcc stall timeout kicks in after the account is offline, which is apparently very frequent with telegram (it sends file transfers while fetching history, and randomly disconnects a while later). Trying to fix that meant opening a can of worms, but after three days of work on this bug I'm pretty sure I've finished dealing with the resulting mess and tested all the typical edge cases.
* imcb_file_send_start: handle ft attempts from non-existing usersdequis2016-11-13-1/+1
|
* word_wrap: truncate utf8 safelydequis2016-11-12-3/+14
|
* tests: don't require pam and ldap to testdequis2016-11-12-1/+1
|
* otr: word_wrap long system messages ("unencrypted message received")dequis2016-11-11-3/+8
|
* purple: hack to pass server parameter to jabber's input requestdequis2016-11-04-2/+23
| | | | | | | | | | | | Because our purple module is all about hacks, adding more can't hurt. There's a string comparison for "Enter a Conference Server". It's gettexted in the source but in practice it isn't affected by locale (bitlbee disables localization). Worst case, if this stops working, it will open an input request like it did before this commit. It also does that in purple's jabber if you don't provide a server parameter.
* purple: fix icq login when the protocol name is "oscar"dequis2016-10-30-4/+17
| | | | | | | | | | | | | | | Which happens when moving from non-purple to purple. Fixes trac ticket 1269 Since "oscar" doesn't exist in purple, the old code called register_protocol() to associate oscar with prpl-aim, which meant that aim accounts migrated seamlessly to purple but icq accounts broke silently, throwing incorrect password errors. Now the oscar protocol is special-cased to return prpl-aim or prpl-icq depending on the first character of the username, which is the same thing the built-in oscar protocol does.
* oscar: remove some dead codedequis2016-10-18-26/+2
|
* Support motd.txt files bigger than 2048 charsdequis2016-10-18-9/+7
| | | | By using g_file_get_contents()
* chat list: Fix alignment/truncation when utf8 characters are presentdequis2016-10-17-5/+30
| | | | By using the str_pad_and_truncate() function I just added
* misc: Add str_pad_and_truncate() helper functiondequis2016-10-17-0/+27
| | | | Useful for tables. See following commit.
* jabber: Implement chat list commanddequis2016-10-16-0/+78
| | | | Also applies to hipchat.
* lib/sha1: Refactor sha1_hmac into a generic b_hmac functiondequis2016-10-16-15/+35
|
* Turn purple_chatlist_free() into a imcb_chat_list_free()dequis2016-10-16-17/+20
| | | | | I found myself copypasting this to jabber. Might as well make it part of the API.
* Rename bee_chat_list_finish() to imcb_chat_list_finish()dequis2016-10-16-3/+10
| | | | | | | | | bee_chat_list_finish is still available as a deprecated function but it will be removed before the next stable release It has never been part of any release, just keeping it for a while for the sake of being polite to the users of the discord plugin who may be using the experimental chat list branch.
* jabber: Don't pass a readonly empty string to imcb_chat_topic()dequis2016-10-12-1/+2
| | | | | | | | | Fixes crashes when a topic is unset and strip_html is set to always. Turns out that the strip_html() function does a strcpy at the end which may write a single null byte over the null byte of the empty string, and if it's not in writable memory, that blows up. Thanks to iamthemcmaster / mcm for pointing this out
* purple: Fix handling of empty, immediate roomlist resultsdequis2016-10-08-10/+22
| | | | | | | | | | | | | | | | | | | | Two issues here: 1. SIPE called in_progress(FALSE) immediately (which decreases refcount), before purple_roomlist_get_list() could return (which would normally increase refcount). The first refcount decrease steals it from the prpl, and bad things happen. Added an initialized flag to only do that decrease after it was increased first. This is similar to how pidgin sets a 'dialog' attribute after the purple_roomlist_get_list() call, and skips the unref if it's not set. 2. The code assumed that NULL return value means room listing not supported. That's not quite true, so now it checks in the prpl info to see if roomlist_get_list is defined. Also, made purple_roomlist_data more private.
* twitter: fix quoted tweet expansion in extended tweetsdequis2016-10-02-5/+14
| | | | | | | | | | | | The outermost entities object only contains the url of the compat tweet, the one linking to /i/web/status/[...] The inner entities object, inside the "extended_tweet", is the one that contains the quoted tweet url that we're supposed to replace. But expand_entities() assumed that the quoted_status object would be next to entities, which doesn't apply in the case of extended tweets. So now it gets an extra parameter to look for entities.
* ssl_openssl: Allow TLS versions newer than 1.0dequis2016-09-29-1/+2
| | | | | | | | | | | | Another victim of SSLv23_client_method's terrible name. At least we weren't forcing ssl 3.0. Thanks kl3 for pointing this out. Despite what this commit might suggest, using openssl is not recommended at all. Potential GPL incompatibility aside, that module doesn't have certificate verification code. Don't use it unless you have a good reason to do so.
* Fix crash when setting away in protocols with null away_states listdequis2016-09-28-0/+3
| | | | | | | Like funyahoo++, which has online and offline statuses, but bitlbee's purple filters those out, resulting in an empty list, and boom. It's ugly enough that I think I'll add a workaround to the plugin too.
* purple: Fix another issue where /join results in two channelsdequis2016-09-25-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to a3019499665384a3dcbbc11016d256e6d4dcd26c (which actually made things worse than before for this particular case - found it by bisecting) This affected skypeweb and hangouts, maybe others. Sometimes serv_join_chat() results in a call chain like this (outermost frame first) 1. purple_chat_join 2. serv_join_chat 3. (the join_chat function of the prpl) 4. serv_got_joined_chat 5. purple_conversation_new 6. prplcb_conv_new The last one tries to find a struct groupchat by name (that's the code from the referenced commit). If it doesn't exist, it creates a new one. This usually isn't an issue because the 4th step is done asynchronously, and a groupchat is created at the end of purple_chat_join. If it's not, you end up with two groupchats, which can lead to other nasty issues. This moves the creation of the groupchat right before serv_join_chat(). That way, it always exists even if the conversation is created immediately.
* twitter: don't count filter stream reply as valid pongsdequis2016-09-24-1/+4
| | | | | | | | | | | | | | | | | Twitter streams send newlines to indicate that they are alive. The twitter_http_stream() function processes those and sets the ponged flag so that the whole connection doesn't timeout. That function is used to handle both user stream and filter stream. If the user stream is dead (not sending whitespace) but the filter stream isn't, the latter keeps the connection alive while the main twitter channel is completely dead. This commit only sets the ponged flag for the user stream. This has the side effect of not detecting if the filter stream dies - but that didn't work before, anyway. In the future the whole stream connection management should be revamped - for example stream disconnections shouldn't take the whole account down, especially not filter streams.
* purple: support setting chat room topics (#84)Eion Robb2016-09-24-0/+16
|
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-26 15:27:40 +0000