| Commit message (Collapse) | Author | Age | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
Basically the same thing as github PR #55, which fixes trac bug 415,
but this one conditionalized that behavior and uses the API introduced a
few commits ago.
I didn't think too much about the setting name and i'm open to changing
it to anything else
|
| |
|
|
|
|
| |
So if someone has several connections with several clients to a chat,
they won't appear as leaving from the chat until they leave from the
last client.
|
| |
|
|
|
|
|
| |
The jabber_buddy used for messages sent from other resources connected
to the same groupchat has a different ext_jid and it's a different
object than jc->me, so doing a string comparison against acc->user is
needed.
|
| |
|
|
|
|
| |
Had this one in a stash, i think it's about trying to join a channel
with an invalid JID and getting an error with a different JID back, so
doing jabber_chat_by_jid() doesn't find it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Well, just deprecated and turned into a no-op. It was only used for
jabber anonymous MUCs, but this is something the IRC layer must take
care of. It stripped all whitespace, control and non-ascii characters,
breaking utf8 nicks support and accidentally merging contacts whose
cleaned-up handles were the same string.
For example, you could have two users with nicks ' ' and ' ' (one and
two spaces respectively) and imcb_clean_handle() would just merge them
into a single handle, '', which makes them look like a single irc user.
The same thing happens with nicks that are entirely made of utf8.
Thanks to schoppenhauer from #bitlbee for reporting this and preparing a
test case channel!
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XMPP MUCs always echo own messages, and send messages from other
clients. So, we must display everything except the messages we just
sent.
This implementation uses the jabber stanza cache to add an ID to the
message and attach it to a callback which always returns XT_ABORT.
This way, if we do get the echo, the message packet handler can call
jabber_cache_handle_packet(), and if it returns XT_ABORT, it can skip
that particular message.
Every other message that looks like it comes from our own JID and wasn't
handled by the cache will be displayed, with the OPT_SELFMESSAGE flag
Stanza cache entries expire after some time, so it's not a problem if
the server doesn't echo messages for some reason.
I actually wrote this forever ago, for hipchat, but it works the same
way for standard XMPP MUCs.
|
| |
|
|
| |
From coverity.
|
| |
|
|
|
|
|
| |
- Look for a status message right inside <presence> (seen with ejabberd
as a result of a s2s connection error)
- Check status codes in a while loop, skipping unknown ones (such as
110, which means "Inform user that presence refers to itself")
|
| | |
|
| |
|
|
|
|
|
|
| |
- Improve handling of "unknown 'from'"
- Try a bit harder to detect the source of the message, and fall back to
messages sent from a fake temporary user.
- Fix receiving topic when it was set by someone who left the room.
- Add jabber_get_bare_jid() utility function
|
| |
|
|
|
|
|
|
| |
If the from="..." of the message that includes a subject refers to us,
that buddy object won't have an ext_jid set, and passing that to
strchr() results in pain.
This happens with recent versions of an xmpp server called "lets-chat".
|
| |
|
|
|
|
|
| |
Used uncrustify, with the configuration file in ./doc/uncrustify.cfg
Commit author set to "Indent <please@skip.me>" so that it's easier to
skip while doing git blame.
|
| |
|
|
|
|
|
| |
my copyright mentions since some were getting pretty stale. Left files not
touched since before 2012 alone so that this change doesn't touch almost
EVERY source file.
|
| |
|
|
|
|
|
| |
Just join #somechannel and start inviting people. It should Just Work,
like on other IM networks. Works at least with GTalk and with other
servers that have conference stuff installed on conference.$servername.
|
| | |
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
full JIDs to be added to the local contact list, but not removed when
leaving the room, eventually triggering errors like the one in #499. People
kept sending me these dumps and I finally took time to make what turned out
to be this one-line fix.
This error should never appear again unless people are doing really crazy
stuff.
|
| | | |
|
| | | |
|
| |/
|
|
|
| |
into a room. More will follow soon.
|
| |
|
|
|
|
| |
servers, sending a "you left this chat" without first acknowledging you
entering it.
|
| |
|
|
|
|
|
|
|
| |
chatrooms. Doesn't seem to be Google Talk specific, other than that this
is the first time I see empty <x xmlns="http://jabber.org/protocol/muc#user"/>
elements that cause this crash.
A more proper/efficient fix may be to just move the break outside the inner if.
|
| |
|
|
|
| |
password-protected rooms *really* works.
|
| |
|
|
|
| |
a password in the IRC JOIN command).
|
| | |
|
| |
|
|
|
|
| |
chatroom. Until now they were ignored, which might make backlogs a little
bit confusing.
|
| |
|
|
|
| |
possible.
|
| | |
|
| |
|
|
|
| |
to chat_invite).
|
| | |
|
| |
|
|
|
|
| |
jabber_chat_by_jid() (with the right name) to conference.c, I don't know
what it was doing in jabber_util.c.
|
| | |
|
| |
|
|
|
|
|
| |
IRC-specific stuff into the Jabber module). Only using this in the MUC
code for now because this only works if the IM module can somehow convert
the cleaned up handle back to the original one.
|
| |
|
|
|
|
| |
channel name generation code in root_commands.c and fixed one memory leak
in jabber_buddy_remove_bare().
|
| | |
|
| |
|
|
|
|
|
| |
fixes a bug reported by James Teh in the monster ticket #20. There's no
proper garbage collection yet in the Jabber conference code, really have
to do that soon. :-(
|
| | |
|
| |
|
|
|
|
| |
work. This also solves the issue of underscores appearing and disappearing
in their nicknames when people leave/join a chat.
|
| |
|
|
|
| |
way to set the nickname in time before BitlBee sends the JOIN.
|
| |
|
|
|
|
|
|
| |
nicknames for chatroom participants. There'll probably be a lot of
underscores now, but this is by far the cleanest way to implement this, I
think. At least now whispers will work properly. Also using this function
call to set names for ICQ contacts in a slightly saner way.
|
| |
|
|
|
|
| |
actually be recognized properly. This is running on my work machine for
a few days already.
|
| |
|
|
|
|
| |
doesn't deal with it very well, and I don't really know yet how I'll
solve this... :-(
|
| |
|
|
|
| |
conferences the user's in.
|
| |
|
|
|
|
|
| |
used the GLOBAL IM connections list, allowing user A to interfere with
user B's groupchats if running in daemon mode. I can't believe this was
still there...
|
| |
|
|
|
| |
with anonymous rooms (ie about 95% of all available Jabber chatrooms?).
|
|
|
Just don't use this, you're really not going to like it. :-)
|
