| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
| |
XEP-0184 section 5.3 says those shouldn't be sent over MUCs, but some
misbehaving clients do anyway, resulting in 'forbidden' errors
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes trac ticket 1143: https://bugs.bitlbee.org/bitlbee/ticket/1143
The "correct" way to discover XEP85 support is to send a discovery
query. We take a more conservative approach: if the irc client claims to
support typing (by sending CTCP TYPING at least once), we send an
<active> tag along with next chat message, and set JBFLAG_PROBED_XEP85.
The logic for that stuff is in jabber_buddy_msg().
That's all neat and clever and actually works fine. What was broken was
the detection side. Whenever a <composing>, <active> or <pause> is
received, the buddy is marked as supporting XEP85. However the <active>
tag had an additional check:
/* No need to send a "stopped typing" signal when there's a message. */
else if (xt_find_node(node->children, "active") && (body == NULL)) {
It skipped the tag completely if it had a message too.
This was changed to move the body == NULL condition inside, so that the
flag is set.
Took me longer to write this message than the diff itself. But even
longer to actually decide to debug this behavior. I'm the one who
submitted that ticket, one year and a half ago. Yep.
|
|
|
|
|
|
|
| |
Used uncrustify, with the configuration file in ./doc/uncrustify.cfg
Commit author set to "Indent <please@skip.me>" so that it's easier to
skip while doing git blame.
|
|
|
|
|
|
|
| |
my copyright mentions since some were getting pretty stale. Left files not
touched since before 2012 alone so that this change doesn't touch almost
EVERY source file.
|
|\ |
|
|/
|
|
|
|
|
| |
This change will make BitlBee acknowledge messages when requested.
It will not request message receipts from other clients, mainly because I am
not sure if this feature can be mapped to IRC cleanly.
|
| |
|
|
|
|
|
| |
channel the user can easily /join.
|
|
|
|
|
| |
with some changes.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
a activity_timeout setting. Now, messages to someone who hasn't spoken for
a while will be sent to his/her bare JID, usually resulting in a broadcast.
This should fix issues with messages sometimes arriving on someone's
Crackberry/Android/etc instead of some place s/he's paying attention to.
Last, the activity timer is only reset on incoming messages.
|
| |
|
|
|
|
|
| |
(NULL pointer dereference).
|
| |
|
|
|
|
|
| |
with anonymous rooms (ie about 95% of all available Jabber chatrooms?).
|
|
|
|
|
| |
Just don't use this, you're really not going to like it. :-)
|
|
|
|
|
| |
buddy/groupchat related functions.
|
|
|
|
|
|
| |
will come tomorrow. It compiles, I'll leave the real testing up to someone
else. ;-)
|
|
|
|
|
| |
insensitivity. Probably not complete yet...
|
| |
|
|
|
|
|
| |
part, non-chat messages.)
|
|
|
|
|
|
|
| |
list, proper checking (and handling) of events related to buddies that
aren't "hashed" yet, limit checks on priorityto setting, renamed JEP85
to XEP85, support for more XEP85 states.
|
|
|
|
|
|
|
| |
budd_by_jid(), added a full_jid property to easily address that resource
without having to rebuild the full JID every time and implemented typing
notification shite.
|
|
|
|
|
|
| |
messages now. Just try to figure out why it doesn't get typing
notifications...
|
| |
|
|
|