| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
| |
This was needed back in 2010, but now it's not.
|
|
|
|
| |
I mean sure you could use messenger reviver but..
|
| |
|
|
|
|
|
|
|
|
| |
Just a 1msec timeout, so that it will run in the next main loop
iteration.
The official clients send the first few commands in the same request,
which reduces roundtrips during login. This commit doesn't do that.
|
|
|
|
| |
This is straightforward, like receiving a message with From/To swapped
|
|
|
|
| |
That includes location blocked and incorrect password.
|
|
|
|
|
|
|
| |
This is what the 'howtofixmsn' wiki page addressed, which has a very
generic name because it's one of the first msn issues that appeared when
we thought it was dying. Since it's just a security measure, it still
appears when people log in from unusual locations.
|
|
|
|
|
| |
- GMail notifications stuff is now just 'mail_notifications'
- sed -i s/notify_handle/mail_notifications_handle/
|
|
|
|
|
|
|
| |
Saves some messing with g_strdup_printf for the callers, and
flags/sent_at weren't used anyway.
Also check if the mail_notifications setting is enabled
|
| |
|
| |
|
|
|
|
| |
Also remove some old unused debug stuff
|
| |
|
|
|
|
|
|
|
| |
The previous value (7) was FL | AL | BL, and the block role was replaced
with "Hide" in msnp21, so the server was rejecting the parts of the ADL
that had it. And since adding blocked contacts isn't very useful anyway,
this is like silencing an annoying warning.
|
|
|
|
|
|
|
| |
Also fix a leak in msn_ns_callback while i'm at it.
Also fix a potential null deref when req->reply_body is null and
BITLBEE_DEBUG is enabled, but i don't even know if this one can happen.
|
|
|
|
|
|
| |
The servers send them for other reasons nowadays, and all
non-MPOP clients are blocked, so OTH is highly unlikely
to mean "someone else logged in with your account"
|
| |
|
|
|
|
| |
I avoided doing this before to keep the diff small. But meh.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
- bump protocol version
- update CVR parameters
- don't send BLP, send ADL right after getting contact list
- NFY payload size parsing
- MSNP21 style ADL
|
| |
|
|
|
|
|
|
|
|
|
| |
Since this removes invitation.h, do "make distclean" to fix build errors
MSNFTP is a file transfer method used by early msn messenger versions,
and has been replaced by MSNP2P probably 10 years ago.
This code was disabled/commented out in bitlbee
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- irc_im.c:
- bee_irc_user_msg: strdup leaks when otr swallows messages
- bee_irc_user_action_response: GString leak in all ctcp replies
- otr.c:
- call g_slist_free() on the list of the otr_policy setting
- otr_filter_msg_in: call otrl_tlv_free() if "tlvs" are returned
- otr_filter_msg_out: don't g_strdup() if the message should be ignored
- log_otr_message: g_strdup_vprintf() leaks always
- nogaim.c:
- imcb_ask_auth/imcb_ask_add: leaks in g_strdup_printf()
- imcb_ask_add leaks imcb_ask_cb_data if the user already exists
- add imcb_ask_cb_free() to correctly free its data
- msn_util.c: add msn_buddy_ask_free(), ditto
- storage_xml.c: pass_cr/password if base64_decode or arc_decode fail
- ssl_gnutls.c: conn->hostname leak in error conditions, like invalid certs
- jabber_util.c: jabber_buddy_by_ext_jid() leaks jid if it's not an ext jid
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was requesting memberships for the following services:
Messenger, Invitation, SocialNetwork, Space, Profile
Now it only requests the same services as WLM 2012:
Messenger, IMAvailability
Fixes trac ticket 1191.
I'm going to apply this to the master branch just for the sake of
marking it as fixed, but I can't log in at all with that branch at the
moment. Yes this is silly.
|
|
|
|
|
|
|
| |
I didn't want to do the next release with a broken msn, but...
gotta be realistic.
Also featuring shameless plug.
|
|
|
|
|
|
|
| |
These were passing a pointer to a variable right after it was g_free()'d
They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.
|
|
|
|
|
|
|
| |
Used uncrustify, with the configuration file in ./doc/uncrustify.cfg
Commit author set to "Indent <please@skip.me>" so that it's easier to
skip while doing git blame.
|
|
|
|
| |
Allocating insufficient memory for the terminating null of the string
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes warnings about passing signed chars to them (apparently they
are implemented as macros that do array lookups without checks in some
platforms, yay)
Specifically:
functions=isalnum|isalpha|isdigit|isspace|isxdigit|tolower|toupper
sed -ir "s/$functions/g_ascii_&/g" **/*.c
|
| |
|
| |
|
|
|
|
|
| |
This workarounds the problems of showing as offline to other contacts,
by sending ADL with role 3 (FL+AL) instead of just 1 (FL, no AL or BL)
|
|
|
|
|
| |
Previously it asked if they were in pending/reverse but not allow/block.
In theory that would fix inconsistent states. And in practice... nope.
|
|
|
|
| |
Because why not
|
|
|
|
| |
The previous ApplicationId was from WLM 2008 (8.5)
|
|
|
|
| |
It has been broken for a very long time and nobody cared about it.
|
|\
| |
| |
| |
| |
| | |
XML-formatted user configs from disk I/O so we can try to start using other
mechanisms to store them (a REST API or something, for example).
|
| | |
|