| Commit message (Collapse) | Author | Age | Lines |
|
|
|
| |
It was showing 'secondary' only before.
|
|
|
|
|
|
|
|
|
|
| |
Those are purple_conversation_write with PURPLE_MESSAGE_SEND flag set,
received through the write_conv UI op.
write_chat and write_im still receive and filter PURPLE_MESSAGE_SEND.
In the case of write_chat it *could* show some of those, but it seems
there's no decent way to tell echoes apart from remote self-messages.
So just keep those hidden for now.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
It was passing the wrong data to the callback - it was supposed to pass
the data of the PurpleMenuItem but it passed the PurpleMenuItem itself.
Probably also applies to other protocols too. It worked fine with
jabber, which i'm guessing is what this code was tested with originally.
It still whines about the null return value saying "(Possible) failure"
but, eh, whatever.
|
|
|
|
|
|
|
|
| |
Purple's IRC, for example, doesn't have the PURPLE_CONNECTION_HTML flag,
but still sends html for format codes.
Note that using IRC through libpurple through bitlbee is still a
terrible idea. Use ZNC instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Which has no connection context. Luckily local_bee exists, and libpurple
only supports only one irc user per process.
This sucks.
And yesterday I was naively thinking (again) that local_bee might not be
needed, that maybe we can do things properly. Of course it only took a
look at that one reverted commit (56985aa) to remember that life is
unfair, and that, under Moloch, everyone is irresistably incentivized to
ignore the things that unite us in favor of forever picking at the
things that divide us in exactly the way that is most likely to make
them more divisive. That being said, I think all these hacks are going
to look nicer once I sandbox the whole thing in a separate process with
one IM account per process, as opposed to one irc use per process. Then
we'll be able to rely on global state exclusively, which is saner.
|
|
|
|
| |
More fixing warnings.
|
|
|
|
| |
Also turn them into asserts because that's what it really does.
|
|
|
|
|
| |
Most of them related to channel joins, one of them related to my recent
certificate pool path fix.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When joining named channels, purple_chat_join() returned NULL instead of
a struct groupchat, which was actually created in the conversation
created callback (prplcb_conv_new()).
If the name of this channel turned out to be different to the joined
one, this meant having one empty window in the irc client, and another
one for the other channel.
The fix is to return a mostly-empty struct groupchat immediately, and
pick it up later when the PurpleConversation is created using
bee_chat_by_title(). If that fails, fall back to creating a new one.
This bug also meant there was no proper way to report a join failure.
Future commits will address that, this one just makes that easier.
Thanks to Etan Reisner (deryni) for enlightening me while i was trying
to figure out how to fix this.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the issue with getting asked to accept certificates that are
perfectly valid, every time.
The directory is normally created by x509_tls_peers_init(), a few calls
below purple_core_init(), which is at module initialization time, way
before we have an irc username to fix the user directory. So it creates
the wrong directory first, and now we have to fix it manually.
And apparently not being able to save cached certificates somehow means
they aren't trusted. For some reason.
< krisfremen> "for some reason"
< dx> idklol
|
|
|
|
|
|
|
|
|
| |
Fixes trac ticket 995 https://bugs.bitlbee.org/bitlbee/ticket/995
This is slightly pointless for the suggested use case (tor), since with
socks5 we already send a hostname instead of an IP address.
Either way, it was easy to implement, so I hope it helps.
|
|
|
|
|
| |
- GMail notifications stuff is now just 'mail_notifications'
- sed -i s/notify_handle/mail_notifications_handle/
|
|
|
|
|
|
|
| |
Saves some messing with g_strdup_printf for the callers, and
flags/sent_at weren't used anyway.
Also check if the mail_notifications setting is enabled
|
| |
|
|
|
|
|
| |
Purple just doesn't work with daemon mode anyway, but it's better to
show the intended error message than to crash while showing it.
|
|
|
|
|
|
|
| |
- Added support for PURPLE_REQUEST_INPUT
- Changed memory management to do the free() of data through
purple_request_close(), letting purple know that the request was
answered, and fixing use-after-free issues with it
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes trac bug 1190 ("Accepting SSL certs too late resets bitlbee-libpurple")
To reproduce:
1. Connect to server with self-signed ssl certificate (downgrading to
libpurple 2.10.9 might be required to actually get the request)
2. Disconnect the account
3. Type "yes"
4. Acquire segfault.
Normally, query_del_by_conn() would handle this, but some requests have
no account context at all. Yeah, it sucks. This is how pidgin handles it.
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 5ff46180e5378acd6d103d9314175c78530bda7e.
Turns out that libpurple really doesn't provide any context at all for
some queries.
Also, not going to say "Shouldn't affect anything" again. I'm getting
good at writing code that looks good, but actually breaks stuff.
That's not good. At all.
|
| |
|
|
|
|
|
| |
Shouldn't affect anything, and still doesn't allow initializing
libpurple more than once, but whatever.
|
|
|
|
|
|
|
| |
Used uncrustify, with the configuration file in ./doc/uncrustify.cfg
Commit author set to "Indent <please@skip.me>" so that it's easier to
skip while doing git blame.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes warnings about passing signed chars to them (apparently they
are implemented as macros that do array lookups without checks in some
platforms, yay)
Specifically:
functions=isalnum|isalpha|isdigit|isspace|isxdigit|tolower|toupper
sed -ir "s/$functions/g_ascii_&/g" **/*.c
|
|
|
|
|
|
|
| |
my copyright mentions since some were getting pretty stale. Left files not
touched since before 2012 alone so that this change doesn't touch almost
EVERY source file.
|
| |
|
|
|
|
|
| |
unexpectedly being set to something already.
|
|
|
|
|
|
|
| |
This in response to #898. I could also try to make each split a separate
setting but that'd make the Jabber module very ugly for example, requiring
the user to split up his/her JID. Let's hope people read this help info..
|
|
|
|
|
| |
Mostly an attempt to explain what's up with #898.
|
|
|
|
|
|
| |
don't even know what's the difference, but this fixes Facebook nicks when
using libpurple.
|
|
|
|
|
|
| |
add new irc_usermsg, irc_usernotice.
deliver user-specific messages from libotr as notices to that user.
|
|
|
|
|
| |
libpurple versions.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't have Twitter support by default and it's unlikely that someone will
prefer libpurple-twitter over BitlBee's Twitter code anyway.
Also automatically disable libpurple protocol modules if a native variant is
already set up. The linking conflict works the other way around (libpurple
modules may break if native modules for the same protocol are compiled in)
so this should mostly resolve the linking conflict problem.
|
|
|
|
|
| |
#679. Patch from "rover.orna".
|
|
|
|
|
| |
using /tmp so far but this wasn't a good idea. Try to use something saner.
|
|
|
|
|
|
|
|
|
|
| |
files, this finally gives proper dependencies, which means the end of
getting broken binaries around headerfile changes, etc.
Sure, this may not work on obscurux with superawesomeincompatiblecc while
autoconf does, but at least BitlBee's configure script still runs in <1s.
:-)
|
| |
|
|
|
|
|
| |
with contacts in multiple groups.
|
|
|
|
|
|
|
| |
a contact is in multiple groups, for now I'm not supporting it.
Also cleaning up query code to avoid calling NULL.
|
| |
|
| |
|
|
|
|
|
| |
would otherwise be a digit.
|
|
|
|
|
|
|
| |
the "struct irc" containing all data belonging to a session. Sanitise
memory management a little bit here. (There are some memory leaks in here
too that need to be fixed at some point.)
|
| |
|
| |
|
|
|
|
|
|
| |
build files in there. I need this to properly make Debian package variants
(i.e. libpurple and native).
|