From d6e2aa8220ae87c58c10ff54b2de80e32b51ac08 Mon Sep 17 00:00:00 2001 From: dequis Date: Mon, 9 Nov 2015 09:21:46 -0300 Subject: Nuke imcb_clean_handle(), which was merging handles accidentally Well, just deprecated and turned into a no-op. It was only used for jabber anonymous MUCs, but this is something the IRC layer must take care of. It stripped all whitespace, control and non-ascii characters, breaking utf8 nicks support and accidentally merging contacts whose cleaned-up handles were the same string. For example, you could have two users with nicks ' ' and ' ' (one and two spaces respectively) and imcb_clean_handle() would just merge them into a single handle, '', which makes them look like a single irc user. The same thing happens with nicks that are entirely made of utf8. Thanks to schoppenhauer from #bitlbee for reporting this and preparing a test case channel! --- protocols/jabber/conference.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'protocols/jabber/conference.c') diff --git a/protocols/jabber/conference.c b/protocols/jabber/conference.c index 9c32bb01..ebb97a72 100644 --- a/protocols/jabber/conference.c +++ b/protocols/jabber/conference.c @@ -301,9 +301,6 @@ void jabber_chat_pkt_presence(struct im_connection *ic, struct jabber_buddy *bud bud->ext_jid[i] = '_'; } } - - /* Some program-specific restrictions. */ - imcb_clean_handle(ic, bud->ext_jid); } bud->flags |= JBFLAG_IS_ANONYMOUS; } -- cgit v1.2.3