From d6e2aa8220ae87c58c10ff54b2de80e32b51ac08 Mon Sep 17 00:00:00 2001 From: dequis Date: Mon, 9 Nov 2015 09:21:46 -0300 Subject: Nuke imcb_clean_handle(), which was merging handles accidentally Well, just deprecated and turned into a no-op. It was only used for jabber anonymous MUCs, but this is something the IRC layer must take care of. It stripped all whitespace, control and non-ascii characters, breaking utf8 nicks support and accidentally merging contacts whose cleaned-up handles were the same string. For example, you could have two users with nicks ' ' and ' ' (one and two spaces respectively) and imcb_clean_handle() would just merge them into a single handle, '', which makes them look like a single irc user. The same thing happens with nicks that are entirely made of utf8. Thanks to schoppenhauer from #bitlbee for reporting this and preparing a test case channel! --- protocols/nogaim.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'protocols/nogaim.h') diff --git a/protocols/nogaim.h b/protocols/nogaim.h index 548b22f9..668216b3 100644 --- a/protocols/nogaim.h +++ b/protocols/nogaim.h @@ -327,7 +327,8 @@ G_MODULE_EXPORT void imcb_buddy_action_response(bee_user_t *bu, const char *acti G_MODULE_EXPORT void imcb_buddy_typing(struct im_connection *ic, const char *handle, guint32 flags); G_MODULE_EXPORT struct bee_user *imcb_buddy_by_handle(struct im_connection *ic, const char *handle); -G_MODULE_EXPORT void imcb_clean_handle(struct im_connection *ic, char *handle); + +G_GNUC_DEPRECATED G_MODULE_EXPORT void imcb_clean_handle(struct im_connection *ic, char *handle); /* Actions, or whatever. */ int imc_away_send_update(struct im_connection *ic); -- cgit v1.2.3