Fix race condition making a new report.

If you started a new report by clicking the map before the
server had responded with the map list pins, when they did
arrive they would replace the new report pin.

1 files changed, 14 insertions, 0 deletions

diff --git a/.cypress/cypress/integration/regressions.js b/.cypress/cypress/integration/regressions.js
index a0d5b3fc9..209013339 100644
--- a/.cypress/cypress/integration/regressions.js
+++ b/.cypress/cypress/integration/regressions.js
@@ -1,3 +1,10 @@
+// See https://github.com/cypress-io/cypress/issues/761 - Cypress dies if we
+// go straight to the next test with an XHR in progress. So visit a 404 page
+// to cancel anything in progress.
+Cypress.Commands.add('cleanUpXHR', function() {
+    cy.visit('/404', { failOnStatusCode: false });
+});
+
 describe('Regression tests', function() {
     it('Shows the sub-map links after clicking Try again', function() {
         cy.viewport(480, 800);
@@ -5,5 +12,12 @@ describe('Regression tests', function() {
         cy.get('#map_box').click(200, 200);
         cy.get('#try_again').click();
         cy.get('#sub_map_links').should('be.visible');
+        cy.cleanUpXHR();
+    });
+    it('Does not hide the new report pin even if you click really quick', function() {
+        cy.visit('/around?pc=BS10+5EE&js=1');
+        cy.get('#map_box').click(200, 200);
+        cy.get('#loading-indicator').should('be.hidden');
+        cy.get('#map_box image').should('be.visible');
     });
 });