aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormatthew <matthew>2007-04-19 12:08:53 +0000
committermatthew <matthew>2007-04-19 12:08:53 +0000
commit1a31a43a6ea40d57cbca297f4b6614e6162577dd (patch)
tree81a3da246ecb641de99ca7c8d28776479c4a246d
parenteec04f402643e29e85d176b26cc52d39e8a35cd2 (diff)
Alert on missing rows now, as they shouldn't get into the database anyway
unless something has been deleted and therefore needs looking at. FIx missing hidden variables on admin page.
-rwxr-xr-xbin/send-reports3
-rwxr-xr-xweb-admin/index.cgi11
2 files changed, 6 insertions, 8 deletions
diff --git a/bin/send-reports b/bin/send-reports
index 9877e7875..626eb63cf 100755
--- a/bin/send-reports
+++ b/bin/send-reports
@@ -6,7 +6,7 @@
# Copyright (c) 2007 UK Citizens Online Democracy. All rights reserved.
# Email: matthew@mysociety.org. WWW: http://www.mysociety.org
#
-# $Id: send-reports,v 1.31 2007-04-11 19:40:01 matthew Exp $
+# $Id: send-reports,v 1.32 2007-04-19 12:08:53 matthew Exp $
use strict;
require 5.8.0;
@@ -60,7 +60,6 @@ foreach my $row (@$unsent) {
my ($council_email, $confirmed, $note) = dbh()->selectrow_array(
"SELECT email,confirmed,note FROM contacts WHERE deleted='f'
and area_id=? AND category=?", {}, $council, $row->{category});
- next unless $council_email; # Ignore missing councils, or non-responsible councils
unless ($confirmed) {
$all_confirmed = 0;
$notgot{$council_email}{$row->{category}}++;
diff --git a/web-admin/index.cgi b/web-admin/index.cgi
index 4a2c7ff8f..57f6c3f53 100755
--- a/web-admin/index.cgi
+++ b/web-admin/index.cgi
@@ -7,10 +7,10 @@
# Copyright (c) 2007 UK Citizens Online Democracy. All rights reserved.
# Email: francis@mysociety.org; WWW: http://www.mysociety.org/
#
-# $Id: index.cgi,v 1.27 2007-04-17 21:36:48 matthew Exp $
+# $Id: index.cgi,v 1.28 2007-04-19 12:08:54 matthew Exp $
#
-my $rcsid = ''; $rcsid .= '$Id: index.cgi,v 1.27 2007-04-17 21:36:48 matthew Exp $';
+my $rcsid = ''; $rcsid .= '$Id: index.cgi,v 1.28 2007-04-19 12:08:54 matthew Exp $';
use strict;
@@ -311,11 +311,10 @@ sub do_council_contacts ($$) {
);
print $q->p($q->strong("Note: "),
$q->textarea(-name => "note", -rows => 3, -columns=>40));
- $q->param('posted', 'new');
print $q->p(
- $q->hidden('area_id'),
- $q->hidden('posted'),
- $q->hidden('page'),
+ $q->hidden('area_id', $area_id),
+ $q->hidden('posted', 'new'),
+ $q->hidden('page', 'councilcontacts'),
$q->submit('Create category')
);
print $q->end_form();