diff options
| author | Duncan Parkes <duncan@mysociety.org> | 2010-12-26 13:05:56 +0000 |
|---|---|---|
| committer | Duncan Parkes <duncan@mysociety.org> | 2010-12-26 13:05:56 +0000 |
| commit | d8b1a2aac76c6aecd6f6c8a519358dd4131fc63d (patch) | |
| tree | 0554da3ae95b7e38c4c6c513f8c63553cd85a332 | |
| parent | fff9cd0b2796dd97db96846b6732e2281e038cc6 (diff) | |
Double quote href.
Change quoting of this href from single to double quotes.
URI::Escape::uri_escape_utf8 on cake appears to escape double quotes,
but not single quotes (which surprises me, given on CPAN this change
appears to happen at version 1.53, and cake only has version 1.35.
I'm guessing there is a debian specific change earlier).
This should fix Alex's bad Google maps url on
http://www.fixmystreet.com/report/124869
Details of why this change is needed here:
http://stackoverflow.com/questions/3523732/perl-uri-escape-utf8-inconsistent-behaviour-or-programmer-error
| -rwxr-xr-x | web/index.cgi | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/web/index.cgi b/web/index.cgi index 1864eba6f..83b3b421c 100755 --- a/web/index.cgi +++ b/web/index.cgi @@ -931,8 +931,8 @@ sub display_problem { my $google_link = Cobrand::base_url_for_emails($cobrand, $extra_data) . '/report/' . $problem->{id}; my ($lat, $lon) = mySociety::GeoUtil::national_grid_to_wgs84($problem->{easting}, $problem->{northing}, 'G'); - my $map_links = "<p id='sub_map_links'><a href='http://maps.google.co.uk/maps?output=embed&z=16&q=" - . URI::Escape::uri_escape_utf8($problem->{title} . ' - ' . $google_link) . "\@$lat,$lon'>View on Google Maps</a></p>"; + my $map_links = "<p id='sub_map_links'><a href=\"http://maps.google.co.uk/maps?output=embed&z=16&q=" + . URI::Escape::uri_escape_utf8($problem->{title} . ' - ' . $google_link) . "\@$lat,$lon\">View on Google Maps</a></p>"; my $banner; if ($q->{site} ne 'emptyhomes' && $problem->{state} eq 'confirmed' && $problem->{duration} > 8*7*24*60*60) { |