diff options
| author | Matthew Somerville <matthew-github@dracos.co.uk> | 2018-09-12 16:48:43 +0100 |
|---|---|---|
| committer | Matthew Somerville <matthew-github@dracos.co.uk> | 2018-09-12 16:48:43 +0100 |
| commit | 58ceefa1d5f6c5d8eff3cddcfc3e337bcd1a5368 (patch) | |
| tree | ea9fe0dd1350cb0d1744663796248cb4fbfe3076 | |
| parent | 26db180bb3663f0ac74ca7c925bde13446b9ded8 (diff) | |
Prevent scan of all problems on /_dev pages.
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rwxr-xr-x | perllib/FixMyStreet/App/Controller/Develop.pm | 6 | ||||
| -rw-r--r-- | perllib/FixMyStreet/DB/Result/User.pm | 4 |
3 files changed, 6 insertions, 5 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index f6d5363f5..53807228b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ * Unreleased - Bugfixes: - Fix display of area/pins on body page when using Bing or TonerLite map. + - Do not scan through all problems to show /_dev pages. * v2.4 (6th September 2018) - Security diff --git a/perllib/FixMyStreet/App/Controller/Develop.pm b/perllib/FixMyStreet/App/Controller/Develop.pm index 1cc8f8906..ae7122fa1 100755 --- a/perllib/FixMyStreet/App/Controller/Develop.pm +++ b/perllib/FixMyStreet/App/Controller/Develop.pm @@ -38,7 +38,7 @@ Shows a list of links to preview HTML emails. sub index : Path('/_dev') : Args(0) { my ( $self, $c ) = @_; - $c->stash->{problem} = $c->model('DB::Problem')->first; + $c->stash->{problem} = $c->model('DB::Problem')->search(undef, { rows => 1 } )->first; } =item email_list @@ -63,8 +63,8 @@ sub email_list : Path('/_dev/email') : Args(0) { 'confirm_report_sent' => 1, 'problem-moderated' => 1, 'questionnaire' => 1, 'submit' => 1); - my $update = $c->model('DB::Comment')->first; - my $problem = $c->model('DB::Problem')->first; + my $update = $c->model('DB::Comment')->search(undef, { rows => 1 } )->first; + my $problem = $c->model('DB::Problem')->search(undef, { rows => 1 } )->first; $c->stash->{templates} = []; foreach (sort keys %templates) { diff --git a/perllib/FixMyStreet/DB/Result/User.pm b/perllib/FixMyStreet/DB/Result/User.pm index 05e0b620a..246159009 100644 --- a/perllib/FixMyStreet/DB/Result/User.pm +++ b/perllib/FixMyStreet/DB/Result/User.pm @@ -176,8 +176,8 @@ sub phone_display { sub latest_anonymity { my $self = shift; - my $p = $self->problems->search(undef, { order_by => { -desc => 'id' } } )->first; - my $c = $self->comments->search(undef, { order_by => { -desc => 'id' } } )->first; + my $p = $self->problems->search(undef, { rows => 1, order_by => { -desc => 'id' } } )->first; + my $c = $self->comments->search(undef, { rows => 1, order_by => { -desc => 'id' } } )->first; my $p_created = $p ? $p->created->epoch : 0; my $c_created = $c ? $c->created->epoch : 0; my $obj = $p_created >= $c_created ? $p : $c; |