diff options
| author | Zarino Zappia <mail@zarino.co.uk> | 2019-02-15 17:28:52 +0000 |
|---|---|---|
| committer | Matthew Somerville <matthew-github@dracos.co.uk> | 2019-02-25 12:18:59 +0000 |
| commit | 775ce06cb346cf2d00171e7cdbe0cf1817002f14 (patch) | |
| tree | 5ec516ef1cb51f371f263b14b6d6f7241b58502f | |
| parent | 3de73ad628759ca510012d532cc681e0b9008969 (diff) | |
Remove --reports from .item-list--reports__item classes in Inspector UI
There’s no need for this `--reports` to be there, so let’s start phasing
it out.
| -rw-r--r-- | templates/web/base/report/_inspect.html | 2 | ||||
| -rw-r--r-- | templates/web/base/report/duplicate-no-updates.html | 2 | ||||
| -rw-r--r-- | web/cobrands/sass/_base.scss | 9 | ||||
| -rw-r--r-- | web/cobrands/sass/_report_list_pins.scss | 2 |
4 files changed, 6 insertions, 9 deletions
diff --git a/templates/web/base/report/_inspect.html b/templates/web/base/report/_inspect.html index e5094d02e..76555cef8 100644 --- a/templates/web/base/report/_inspect.html +++ b/templates/web/base/report/_inspect.html @@ -120,7 +120,7 @@ <p class="[% "hidden" IF problem.duplicate_of %]">[% loc('Which report is it a duplicate of?') %]</p> <ul class="item-list item-list--inspect-duplicates"> [% IF problem.duplicate_of %] - [% INCLUDE 'report/_item.html' item_extra_class = 'item-list--reports__item--selected' problem = problem.duplicate_of %] + [% INCLUDE 'report/_item.html' item_extra_class = 'item-list__item--selected' problem = problem.duplicate_of %] <li class="item-list__item"><a class="btn" href="#" id="js-change-duplicate-report">[% loc('Choose another') %]</a></li> [% END %] </ul> diff --git a/templates/web/base/report/duplicate-no-updates.html b/templates/web/base/report/duplicate-no-updates.html index 7de2ae042..6cfc85887 100644 --- a/templates/web/base/report/duplicate-no-updates.html +++ b/templates/web/base/report/duplicate-no-updates.html @@ -4,6 +4,6 @@ [% END %] <p>[% loc("This report is a duplicate. Please leave updates on the original report:") %]</p> <ul class="item-list"> - [% INCLUDE 'report/_item.html' item_extra_class = 'item-list__item--with-pin item-list--reports__item--selected' problem = problem.duplicate_of %] + [% INCLUDE 'report/_item.html' item_extra_class = 'item-list__item--with-pin item-list__item--selected' problem = problem.duplicate_of %] </ul> </div> diff --git a/web/cobrands/sass/_base.scss b/web/cobrands/sass/_base.scss index 7937139a0..6fc63d9f0 100644 --- a/web/cobrands/sass/_base.scss +++ b/web/cobrands/sass/_base.scss @@ -1194,13 +1194,10 @@ input.final-submit { // that appears in Inspector form, when closing a report as a duplicate. .item-list--inspect-duplicates { border-bottom: none; + background-color: rgba(255, 255, 255, 0.5); - .item-list__item { - background-color: rgba(255, 255, 255, 0.5); - } - - .item-list--reports__item--selected, - .js & .item-list--reports__item--selected.expanded:hover { + .item-list__item--selected, + .js & .item-list__item--selected.expanded:hover { border: 0.25em solid $primary; background-color: #fff; } diff --git a/web/cobrands/sass/_report_list_pins.scss b/web/cobrands/sass/_report_list_pins.scss index 55ef1cf56..f6fcb46f9 100644 --- a/web/cobrands/sass/_report_list_pins.scss +++ b/web/cobrands/sass/_report_list_pins.scss @@ -27,7 +27,7 @@ $pin_prefix: '/i/' !default; background-image: url('#{$pin_prefix}pin-orange-small.png'); } } -.item-list--reports__item--selected { +.item-list__item--selected { background: $base_bg; a, a:hover, a:focus { |