[Northamptonshire] improve external id mapping script

Now uses FixMyStreet id as the lookup based on external_id was much too
slow in practice

1 files changed, 7 insertions, 1 deletions

diff --git a/bin/northamptonshire/update_ids_for_v2 b/bin/northamptonshire/update_ids_for_v2
index eac52b938..2876bb0d8 100755
--- a/bin/northamptonshire/update_ids_for_v2
+++ b/bin/northamptonshire/update_ids_for_v2
@@ -22,6 +22,7 @@ use Text::CSV;
 
 my $NEW_ID = 'alloy_item_id';
 my $OLD_ID = 'res_id';
+my $FMS_ID = 'fms_id';
 
 my ($commit, $file);
 GetOptions(
@@ -42,14 +43,19 @@ my $northants = FixMyStreet::DB->resultset("Body")->find({ name => 'Northamptons
 if ($northants) {
     while (my $report = $csv->getline_hr( $fh ) ) {
         next unless $report->{$OLD_ID};
-        my $p = FixMyStreet::DB->resultset('Problem')->to_body( $northants->id )->search({ external_id => $report->{$OLD_ID} })->first;
+        my $p = FixMyStreet::DB->resultset('Problem')->to_body( $northants->id )->search({ id => $report->{$FMS_ID} })->first;
         next unless $p;
+        if ( $p->external_id ne $report->{$OLD_ID} ) {
+            warn "mismatch for " . $report->{$FMS_ID} . "\n";
+            next;
+        }
 
         if ($commit) {
             $p->set_extra_metadata('old_external_id', $p->external_id);
             $p->external_id($report->{$NEW_ID});
             $p->update;
         }
+        say "Processed $count" if $count % 100 == 0;
         $count++;
     }