[Zurich] Tweaks to redirect

See mysociety/FixMyStreet-Commercial#690

I understand redirection to summary page was introduced at ZWN's request,
to make it easy to
process reports and then quickly move onto the next one.

However, during testing now, Tobias has mentioned this is a) slowing
things down and b) confusing because it's not obvious that the report
has been saved.

I've tried to address (b) by adding the "Aktualisiert!" message when
you are redirected.

Also, for (a) I've removed the redirection from a few cases, and
disabled it for superuser.  If need be, I can remove redirection from
more (or all) cases.

Fix Official answer/Reply to user

 - hide label for status update on state change
 - correct wording on button for closure (single wording)
 - correct wording on label for user reply (either "Official answer" or "Reply to user" as appropriate)
 - Make sure the official response texts are shown for edit/static as appropriate, and test.
 - javascript improvements
 - honour public status update for Extern/Wunsch too
 - don't show public message for Wunsch
 - Ignore all other fields when rotating photos.
   (See mysociety/FixMyStreet-Commercial#718)

1 files changed, 9 insertions, 1 deletions

diff --git a/perllib/FixMyStreet/App/Controller/Admin.pm b/perllib/FixMyStreet/App/Controller/Admin.pm
index 5ebeffc11..677aa66d7 100644
--- a/perllib/FixMyStreet/App/Controller/Admin.pm
+++ b/perllib/FixMyStreet/App/Controller/Admin.pm
@@ -683,7 +683,15 @@ sub report_edit : Path('report_edit') : Args(1) {
 
     if (my $rotate_photo_param = $self->_get_rotate_photo_param($c)) {
         $self->rotate_photo($c,  @$rotate_photo_param);
-        return 1;
+        if ( $c->cobrand->moniker eq 'zurich' ) {
+            # Clicking the photo rotation buttons should do nothing
+            # except for rotating the photo, so return the user
+            # to the report screen now.
+            $c->res->redirect( $c->uri_for( 'report_edit', $problem->id ) );
+            return;
+        } else {
+            return 1;
+        }
     }
 
     if ( $c->cobrand->moniker eq 'zurich' ) {