Migrate recent_photos to new ResultSet, nice joining with problem_find_nearby procedure.

1 files changed, 37 insertions, 2 deletions

diff --git a/perllib/FixMyStreet/DB/ResultSet/Problem.pm b/perllib/FixMyStreet/DB/ResultSet/Problem.pm
index ea146cd54..0ca8d1127 100644
--- a/perllib/FixMyStreet/DB/ResultSet/Problem.pm
+++ b/perllib/FixMyStreet/DB/ResultSet/Problem.pm
@@ -51,18 +51,53 @@ sub recent {
     my $key = "recent:$site_key";
     my $result = Memcached::get($key);
     unless ($result) {
-        $result = $rs->search( {
+        $result = [ $rs->search( {
             state => [ 'confirmed', 'fixed' ]
         }, {
             columns => [ 'id', 'title' ],
             order_by => { -desc => 'confirmed' },
             rows => 5,
-        } )->count;
+        } )->all ];
         Memcached::set($key, $result, 3600);
     }
     return $result;
 }
 
+sub recent_photos {
+    my ( $rs, $num, $lat, $lon, $dist ) = @_;
+    my $probs;
+    my $query = {
+        state => [ 'confirmed', 'fixed' ],
+        photo => { '!=', undef },
+    };
+    my $attrs = {
+        columns => [ 'id', 'title' ],
+        order_by => { -desc => 'confirmed' },
+        rows => $num,
+    };
+    if (defined $lat) {
+        my $dist2 = $dist; # Create a copy of the variable to stop it being stringified into a locale in the next line!
+        my $key = "recent_photos:$site_key:$num:$lat:$lon:$dist2";
+        $probs = Memcached::get($key);
+        unless ($probs) {
+            $attrs->{bind} = [ $lat, $lon, $dist ];
+            $attrs->{join} = 'nearby';
+            $probs = [ mySociety::Locale::in_gb_locale {
+                $rs->search( $query, $attrs )->all;
+            } ];
+            Memcached::set($key, $probs, 3600);
+        }
+    } else {
+        my $key = "recent_photos:$site_key:$num";
+        $probs = Memcached::get($key);
+        unless ($probs) {
+            $probs = [ $rs->search( $query, $attrs )->all ];
+            Memcached::set($key, $probs, 3600);
+        }
+    }
+    return $probs;
+}
+
 # Problems around a location
 
 sub around_map {