Escape data attributes in template.

This fixes a bug whereby a double quote in an item would not be JSON-escaped
due to being HTML-escaped first, meaning it would not parse as JSON on the
client.

1 files changed, 2 insertions, 3 deletions

diff --git a/perllib/FixMyStreet/DB/ResultSet/ResponseTemplate.pm b/perllib/FixMyStreet/DB/ResultSet/ResponseTemplate.pm
index aa070daa3..46fcba153 100644
--- a/perllib/FixMyStreet/DB/ResultSet/ResponseTemplate.pm
+++ b/perllib/FixMyStreet/DB/ResultSet/ResponseTemplate.pm
@@ -2,7 +2,6 @@ package FixMyStreet::DB::ResultSet::ResponseTemplate;
 use base 'DBIx::Class::ResultSet';
 
 use Moo;
-use HTML::Entities;
 
 with('FixMyStreet::Roles::ContactExtra');
 
@@ -17,8 +16,8 @@ sub name_column {
 sub map_extras {
     my ($rs, @ts) = @_;
     return map {
-        my $out = { id => encode_entities($_->text), name => encode_entities($_->title) };
-        $out->{state} = encode_entities($_->state) if $_->state;
+        my $out = { id => $_->text, name => $_->title };
+        $out->{state} = $_->state if $_->state;
         $out;
     } @ts;
 }