aboutsummaryrefslogtreecommitdiffstats
path: root/perllib
diff options
context:
space:
mode:
authorMatthew Somerville <matthew-github@dracos.co.uk>2015-12-02 09:26:26 +0000
committerMatthew Somerville <matthew-github@dracos.co.uk>2015-12-09 09:43:55 +0000
commit4a4a80ae1f93dbca893830088f03e054bbfa77ea (patch)
tree2c7d0ae792a181207accd54d1743136c641c2fff /perllib
parent8ad7ab656466469e16403935e175c22438480ef8 (diff)
Make sure email and name are given in admin form.
Diffstat (limited to 'perllib')
-rw-r--r--perllib/FixMyStreet/App/Controller/Admin.pm22
1 files changed, 14 insertions, 8 deletions
diff --git a/perllib/FixMyStreet/App/Controller/Admin.pm b/perllib/FixMyStreet/App/Controller/Admin.pm
index a61032988..9a6c7bded 100644
--- a/perllib/FixMyStreet/App/Controller/Admin.pm
+++ b/perllib/FixMyStreet/App/Controller/Admin.pm
@@ -1076,16 +1076,18 @@ sub user_add : Path('user_edit') : Args(0) {
$c->forward('get_token');
$c->forward('fetch_all_bodies');
- return 1 unless $c->get_param('submit');
+ return unless $c->get_param('submit');
$c->forward('check_token');
- if ( $c->cobrand->moniker eq 'zurich' and $c->get_param('email') eq '' ) {
+ unless ($c->get_param('email')) {
$c->stash->{field_errors}->{email} = _('Please enter a valid email');
- return 1;
+ return;
+ }
+ unless ($c->get_param('name')) {
+ $c->stash->{field_errors}->{name} = _('Please enter a name');
+ return;
}
-
- return unless $c->get_param('name') && $c->get_param('email');
my $user = $c->model('DB::User')->find_or_create( {
name => $c->get_param('name'),
@@ -1133,12 +1135,16 @@ sub user_edit : Path('user_edit') : Args(1) {
$user->from_body( $c->get_param('body') || undef );
$user->flagged( $c->get_param('flagged') || 0 );
- if ( $c->cobrand->moniker eq 'zurich' and $user->email eq '' ) {
+ unless ($user->email) {
$c->stash->{field_errors}->{email} = _('Please enter a valid email');
- return 1;
+ return;
+ }
+ unless ($user->name) {
+ $c->stash->{field_errors}->{name} = _('Please enter a name');
+ return;
}
- $user->update;
+ $user->update;
if ($edited) {
$c->forward( 'log_edit', [ $id, 'user', 'edit' ] );
}