diff options
author | Matthew Somerville <matthew-github@dracos.co.uk> | 2018-12-20 09:43:38 +0000 |
---|---|---|
committer | Matthew Somerville <matthew-github@dracos.co.uk> | 2018-12-20 14:24:51 +0000 |
commit | 5724c6adf8db7cca611fcc000e6fa4e995fcc2bd (patch) | |
tree | 5d2dfe04d5606d07413e113af9f2ea0ddbac9d6f /t/app | |
parent | 649692298b0b870b161a3f8b755f46b16b534e48 (diff) |
Show all questionnaire responses lacking updates.
Since questionnaire responses were recorded on email link click, we
should have been showing those that reopened or fixed reports, not
just steady-state "Still open" ones.
Diffstat (limited to 't/app')
-rw-r--r-- | t/app/controller/report_updates.t | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/t/app/controller/report_updates.t b/t/app/controller/report_updates.t index 9a95c296e..76594a74a 100644 --- a/t/app/controller/report_updates.t +++ b/t/app/controller/report_updates.t @@ -186,6 +186,20 @@ subtest "several updates shown in correct order" => sub { old_state => 'confirmed', new_state => 'fixed - user', }, + { # One reopening, no associated update + problem_id => $report_id, + whensent => '2011-03-16 08:12:36', + whenanswered => '2011-03-16 08:12:36', + old_state => 'fixed - user', + new_state => 'confirmed', + }, + { # One marking fixed, no associated update + problem_id => $report_id, + whensent => '2011-03-17 08:12:36', + whenanswered => '2011-03-17 08:12:36', + old_state => 'confirmed', + new_state => 'fixed - user', + }, ) { my $q = FixMyStreet::App->model('DB::Questionnaire')->find_or_create( $fields @@ -240,13 +254,15 @@ subtest "several updates shown in correct order" => sub { $mech->get_ok("/report/$report_id"); my $meta = $mech->extract_update_metas; - is scalar @$meta, 6, 'number of updates'; + is scalar @$meta, 8, 'number of updates'; is $meta->[0], 'Posted by Other User at 12:23, Thu 10 March 2011', 'first update'; is $meta->[1], 'Posted by Main User at 12:23, Thu 10 March 2011 Still open, via questionnaire', 'second update'; is $meta->[2], 'Still open, via questionnaire, 12:23, Fri 11 March 2011', 'questionnaire'; is $meta->[3], 'Still open, via questionnaire, 12:23, Sat 12 March 2011', 'questionnaire'; is $meta->[4], 'State changed to: Fixed', 'third update, part 1'; is $meta->[5], 'Posted anonymously at 08:12, Tue 15 March 2011', 'third update, part 2'; + is $meta->[6], 'Still open, via questionnaire, 08:12, Wed 16 March 2011', 'reopen questionnaire'; + is $meta->[7], 'Questionnaire filled in by problem reporter; State changed to: Fixed, 08:12, Thu 17 March 2011', 'fix questionnaire'; $report->questionnaires->delete; }; |