diff options
| author | Matthew Somerville <matthew-github@dracos.co.uk> | 2019-03-01 17:04:50 +0000 |
|---|---|---|
| committer | Matthew Somerville <matthew-github@dracos.co.uk> | 2019-03-05 13:08:51 +0000 |
| commit | c029ec15c481cfe153670c735a1d4ca35b3153f9 (patch) | |
| tree | 774ec135781366875045eb1f218ae9f03310cc14 /t/app | |
| parent | 86827c23436fef52b6b38d3fbc357fb0bf20f0c6 (diff) | |
Use relative report links where possible.
On some UK council cobrands, some reports listed might not have been sent
to that council, so links to those must go to the national site. However,
using absolute URLs for all these reports means that sometimes you change
domain when you don't need to (eg. if you’re on osm.fixmystreet.com or an
aliased version of the site), which can cause confusion. State when we’re
happy to use a relative link (ie. web-facing report links, not emails, or
share links) and do that when we can.
Diffstat (limited to 't/app')
| -rw-r--r-- | t/app/controller/report_new.t | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/app/controller/report_new.t b/t/app/controller/report_new.t index d50a682cf..d9fae5fbc 100644 --- a/t/app/controller/report_new.t +++ b/t/app/controller/report_new.t @@ -1719,7 +1719,7 @@ subtest "test Hart" => sub { if ( $test->{confirm} ) { is $mech->uri->path, "/report/new"; my $base = 'www.fixmystreet.com'; - $base = "hart.fixmystreet.com" unless $test->{national}; + $base = '"' unless $test->{national}; $mech->content_contains("$base/report/" . $report->id, "links to correct site"); } else { # receive token @@ -1746,7 +1746,7 @@ subtest "test Hart" => sub { }; my $base = 'www.fixmystreet.com'; - $base = 'hart.fixmystreet.com' unless $test->{national}; + $base = '"' unless $test->{national}; $mech->content_contains( $base . '/report/' . $report->id, 'confirm page links to correct site' ); |