aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--perllib/FixMyStreet/App/Controller/Around.pm2
-rw-r--r--perllib/FixMyStreet/App/Controller/Report/New.pm2
-rw-r--r--perllib/FixMyStreet/App/Controller/Reports.pm2
-rw-r--r--perllib/FixMyStreet/Map/OSM.pm5
-rw-r--r--web/js/map-OpenLayers.js12
5 files changed, 14 insertions, 9 deletions
diff --git a/perllib/FixMyStreet/App/Controller/Around.pm b/perllib/FixMyStreet/App/Controller/Around.pm
index ac8e0e719..e110cf8d7 100644
--- a/perllib/FixMyStreet/App/Controller/Around.pm
+++ b/perllib/FixMyStreet/App/Controller/Around.pm
@@ -189,7 +189,7 @@ sub display_location : Private {
{
latitude => $p->latitude,
longitude => $p->longitude,
- colour => $p->is_fixed ? 'green' : 'red',
+ colour => 'yellow', # $p->is_fixed ? 'green' : 'red',
id => $p->id,
title => $p->title,
}
diff --git a/perllib/FixMyStreet/App/Controller/Report/New.pm b/perllib/FixMyStreet/App/Controller/Report/New.pm
index 9eefc9396..a222b950d 100644
--- a/perllib/FixMyStreet/App/Controller/Report/New.pm
+++ b/perllib/FixMyStreet/App/Controller/Report/New.pm
@@ -1031,7 +1031,7 @@ sub generate_map : Private {
pins => [ {
latitude => $latitude,
longitude => $longitude,
- colour => 'yellow',
+ colour => 'green', # 'yellow',
} ],
);
}
diff --git a/perllib/FixMyStreet/App/Controller/Reports.pm b/perllib/FixMyStreet/App/Controller/Reports.pm
index 5305b23b4..f8302f93e 100644
--- a/perllib/FixMyStreet/App/Controller/Reports.pm
+++ b/perllib/FixMyStreet/App/Controller/Reports.pm
@@ -436,7 +436,7 @@ sub add_row {
push @$pins, {
latitude => $problem->{latitude},
longitude => $problem->{longitude},
- colour => FixMyStreet::DB::Result::Problem->fixed_states()->{$problem->{state}} ? 'green' : 'red',
+ colour => 'yellow', # FixMyStreet::DB::Result::Problem->fixed_states()->{$problem->{state}} ? 'green' : 'red',
id => $problem->{id},
title => $problem->{title},
};
diff --git a/perllib/FixMyStreet/Map/OSM.pm b/perllib/FixMyStreet/Map/OSM.pm
index be185c35c..8ca5949d8 100644
--- a/perllib/FixMyStreet/Map/OSM.pm
+++ b/perllib/FixMyStreet/Map/OSM.pm
@@ -116,7 +116,10 @@ sub map_pins {
# id => $p->id,
# title => $p->title,
#}
- [ $p->latitude, $p->longitude, $p->is_fixed ? 'green' : 'red', $p->id, $p->title ]
+ [ $p->latitude, $p->longitude,
+ 'yellow', # $p->is_fixed ? 'green' : 'red',
+ $p->id, $p->title
+ ]
} @$around_map, @$nearby;
return (\@pins, $around_map_list, $nearby, $dist);
diff --git a/web/js/map-OpenLayers.js b/web/js/map-OpenLayers.js
index 2375d5eb8..f9c2efcaf 100644
--- a/web/js/map-OpenLayers.js
+++ b/web/js/map-OpenLayers.js
@@ -392,7 +392,7 @@ OpenLayers.Control.Click = OpenLayers.Class(OpenLayers.Control, {
/* Already have a pin */
fixmystreet.markers.features[0].move(lonlat);
} else {
- var markers = fms_markers_list( [ [ lonlat.lat, lonlat.lon, 'yellow' ] ], false );
+ var markers = fms_markers_list( [ [ lonlat.lat, lonlat.lon, 'green' ] ], false );
fixmystreet.bbox_strategy.deactivate();
fixmystreet.markers.removeAllFeatures();
fixmystreet.markers.addFeatures( markers );
@@ -406,7 +406,7 @@ OpenLayers.Control.Click = OpenLayers.Class(OpenLayers.Control, {
$('#hide_pins_link').click();
}
if (fixmystreet.page == 'new') {
- return true;
+ return false;
}
$.getJSON('/report/new/ajax', {
latitude: $('#fixmystreet\\.latitude').val(),
@@ -420,11 +420,12 @@ OpenLayers.Control.Click = OpenLayers.Class(OpenLayers.Control, {
$('#form_category').change( form_category_onchange );
}
});
- return false;
+ return lonlat;
},
locate_report_mobile: function(e) {
- if (this.locate_report_pin_and_council(e)) {
+ var lonlat = this.locate_report_pin_and_council(e);
+ if (!lonlat) {
return;
}
fixmystreet.page = 'new';
@@ -432,7 +433,8 @@ OpenLayers.Control.Click = OpenLayers.Class(OpenLayers.Control, {
},
locate_report: function(e) {
- if (this.locate_report_pin_and_council(e)) {
+ var lonlat = this.locate_report_pin_and_council(e);
+ if (!lonlat) {
return;
}
$('#side-form, #site-logo').show();