aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--perllib/FixMyStreet/SendReport/Open311.pm7
-rw-r--r--perllib/Open311.pm5
2 files changed, 6 insertions, 6 deletions
diff --git a/perllib/FixMyStreet/SendReport/Open311.pm b/perllib/FixMyStreet/SendReport/Open311.pm
index 70bce3d47..8d7a418af 100644
--- a/perllib/FixMyStreet/SendReport/Open311.pm
+++ b/perllib/FixMyStreet/SendReport/Open311.pm
@@ -96,7 +96,7 @@ sub send {
if ($row->cobrand eq 'fixmybarangay') {
# FixMyBarangay endpoints expect external_id as an attribute
- $row->extra( [ { 'name' => 'external_id', 'value' => $row->id } ] );
+ $row->extra( [ { 'name' => 'external_id', 'value' => $row->id } ] );
}
my $resp = $open311->send_service_request( $row, $h, $contact->email );
@@ -109,6 +109,11 @@ sub send {
if ( $resp ) {
$row->external_id( $resp );
$row->send_method_used('Open311');
+ if ($row->cobrand eq 'fixmybarangay') {
+ # currently the only external body using Open311 is DPS
+ # (this will change when we have 'body' logic in place, meanwhile: hardcoded)
+ $row->external_body("DPS");
+ }
$result *= 0;
$self->success( 1 );
} else {
diff --git a/perllib/Open311.pm b/perllib/Open311.pm
index d27e2ae5c..52e17e99d 100644
--- a/perllib/Open311.pm
+++ b/perllib/Open311.pm
@@ -55,11 +55,6 @@ sub send_service_request {
my $extra = shift;
my $service_code = shift;
- # all FMB Open311 requests are current ly marked DPS (actually could check for Streetlight category too)
- if (defined($problem->cobrand) && $problem->cobrand eq "fixmybarangay") {
- $problem->update({external_body => "DPS" }); # hardcoded for FMB, pending bodies table
- }
-
my $params = $self->_populate_service_request_params(
$problem, $extra, $service_code
);