diff options
| -rw-r--r-- | CHANGELOG.md | 2 | ||||
| -rw-r--r-- | web/cobrands/fixmystreet/fixmystreet.js | 12 |
2 files changed, 12 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index b3b0b3c8d..9af06e8df 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Improved 403 message, especially for private reports. - Mobile users can now filter the pins on the `/around` map view. #2366 - Maintain whitespace formatting in email report/update lists. + - Improve keyboard accessibility. - Admin improvements: - Add new roles system, to group permissions and apply to users. - New features: @@ -16,6 +17,7 @@ - Set fixmystreet.bodies sooner client-side, for two-tier locations. - Fix front-end testing script when run with Vagrant. - Handle missing category when sending open311 reports #2502 + - Fix label associations with category groups. - Development improvements: - Upgrade the underlying framework and a number of other packages. - Add feature cobrand helper function. diff --git a/web/cobrands/fixmystreet/fixmystreet.js b/web/cobrands/fixmystreet/fixmystreet.js index 2f0a48385..041d23c9e 100644 --- a/web/cobrands/fixmystreet/fixmystreet.js +++ b/web/cobrands/fixmystreet/fixmystreet.js @@ -490,6 +490,7 @@ $.extend(fixmystreet.set_up, { } var $group_select = $("<select></select>").addClass("form-control validCategory").attr('id', 'category_group'); + var $category_label = $("#form_category_label"); var $subcategory_label = $("#form_subcategory_label"); var $empty_option = $category_select.find("option").first(); @@ -501,7 +502,7 @@ $.extend(fixmystreet.set_up, { $category_select.val($(this).val()).change(); } else { $("#" + subcategory_id).show().change(); - $("#form_subcategory_label").removeClass("hidden"); + $subcategory_label.removeClass("hidden").attr('for', subcategory_id); } }); @@ -546,6 +547,7 @@ $.extend(fixmystreet.set_up, { $category_select.hide(); $group_select.insertAfter($category_select); + $category_label.attr('for', 'category_group'); $category_select.find("optgroup, > option").each(function() { if (this.tagName.toLowerCase() === 'optgroup') { add_optgroup(this); @@ -630,7 +632,7 @@ $.extend(fixmystreet.set_up, { var $context = $(this); var $originalLabel = $('[for="form_photo"], .js-photo-label', $context); var $originalInput = $('#form_photos, .js-photo-fields', $context); - var $dropzone = $('<div>').addClass('dropzone'); + var $dropzone = $('<div tabindex=0>').addClass('dropzone'); $originalLabel.removeAttr('for'); $('[data-plural]', $originalLabel).text( @@ -698,6 +700,12 @@ $.extend(fixmystreet.set_up, { } }); + $dropzone.on('keydown', function(e) { + if (e.keyCode === 13 || e.keyCode === 32) { + $dropzone.click(); + } + }); + $.each($('input[name=upload_fileid]', $context).val().split(','), function(i, f) { if (!f) { return; |