| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
| |
These tests sometimes fail on Travis; e.g. fetching /report/1 returns a
non-logged in version of the page, or the Inspector login works but you
are still logged in as the previous user. See if we can stabilise it by
doing a full login rather than a cy.request() one, and logging out / in
rather than going directly to re-login.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the past Oxfordshire had a way for inspectors to "instruct a defect",
which generated a CSV which got emailed to Oxfordshire with a list of
defects.
They now want to bring this functionality back, but instead of emailing
a CSV they want it to call an API.
As a first step towards that goal, this change adds back some of the
instruct defect functionality that was removed in 68e18ff.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stopper checking code is triggered using the category_change event
which, by default also calls the duplicate check code. This meant that
when an extra question dropdown with an associated stopper was updated
the duplicate check re-ran and the duplicate reports panel was re-shown.
The invocation of category_change on the extra questions now includes
the skip_duplicates parameter to avoid this.
Fixes mysociety/fixmystreet-commercial#2007
|
|
|
|
| |
cope with change to staging assets URL
|
| |
|
|
|
|
| |
change resolution and zoom level for asset layers
|
| |
|
|
|
|
| |
Temporary measure while Alloy is down for upgrade
|
|
|
|
| |
Not on StreetView/OpenMap Local based, which are not available.
|
| |
|
| |
|
|
|
|
|
|
| |
Co-Authored-By: Struan Donald <struan@exo.org.uk>
For https://github.com/mysociety/fixmystreet-commercial/issues/1808
|
|
|
|
|
| |
With the refactor to make sure asset message always uses the default, no
need for these specific config lines any more.
|
| |
|
|
|
|
| |
You need to install the @cypress/code-coverage package alongside cypress.
|
|
|
|
|
|
|
|
|
|
| |
Resetting using the class could cause an incorrect "you can pick an
$item from the map" message to be display when asset_groups were being
used. This was happening when the unselect event was firing after the
category change event and then updating the new message using the
message from the unselected layer.
Fixes mysociety/fixmystreet-commercial#1888
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you clicked on a non-HE location (so showing non-HE categories), then
moved the pin to a HE location, the HE message box would show and update
categories (but there would be no HE ones at the time). The server would
return the new categories (including HE ones), but as the issue location
had now not changed on this second call, the categories would not update
to hide non-HE ones (it would show both HE and non-HE categories).
So, instead of going off a location, check the road name - if it has not
changed, do not recreate the whole HE message box, but do call the right
HE selected/not selected function to update the categories.
Note that this, if "Somewhere else" is selected, then causes an infinite
loop, because the highways_change event triggers a category_change event
which fires the layer's road found function, and then repeat.
The highways_change->category_change event firing, according to the code
comment, is so that asset selection can take place, or to remove stopper
messages being shown. Previously, HE did not have its own categories but
overrode the body to be sent to; HE now does have categories of its own,
so I think this code can be removed.
|
|
|
|
|
|
|
|
|
|
| |
Once a location is fixed, we never want to regenerate the Highways
England question, as that can lose the selected category. Store the
location regardless of the HE question answer, so any category
change, as opposed to a location change, does not do anything.
We also do not want to clear category_meta, as that is where the extra
data fields appear.
|
|
|
|
|
|
|
|
|
| |
Instead of sending off-road flytipping reports to the district, now that
Buckinghamshire is unitary we instead recategorise them into a new email
specific “Flytipping (off-road)” category which is handled in the same
way as other ex-district categories with the borough_email_addresses
cobrand feature, and omitted from the dropdown by the
categories_restriction cobrand method.
|
|
|
|
| |
New unitary branding, and remove County from name.
|
|
|
|
|
| |
The server is now returning HE categories for us near a HE road, so
display/hide them as appropriate.
|
|
|
|
|
|
| |
Since we require the user to enter their full name Buckinghamshire have
asked us to change the text to "Full name" to make it clearer that the
full name is required to complete the form.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change, you can safely add the TfL body to other councils
(namely the ones surrounding London that include TfL bus stops);
clicking in those councils on other cobrands will have no change, as the
TfL body will be fully ignored on a non-London council, but on the TfL
cobrand it will allow it for e.g. the selection of bus stops outside
London.
It removes the body rather than just all its categories to prevent a "We
do not have details of the other body covering this area" message
appearing.
|
| |
|
|
|
|
|
| |
Because trees now allow you to click on a highway as well as a tree it's
simpler to switch the tests to a different type
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
I want to change the `updateUSRNField` method so that it can accept an
array of objects in the `usrn` key, but before doing that I want to add
a test to ensure the existing behaviour is tested, to ensure I'm not
breaking anything.
|
|
|
|
|
|
| |
As there are two category drop-downs in this situation (one in the
hidden reporting form, one in the inspect form), the correct entry
needs to be specified.
|
|
|
|
|
|
|
| |
If the duplicates.js file is loaded, then its mechanisms come into play,
and it fetches duplicates and hides the reporting form if there are any.
So we only want this to happen in the same situations as it being loaded
elsewhere, on a relevant cobrand and not just after signing in.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Co-authored-by: Matthew Somerville <matthew@mysociety.org>
Configured to allow:
- updates only from original reporter
- close updates from fetch reports
- use OSM geocoder
|
|
|
|
|
| |
The question was being asked for even when it should not, because
the error key had been changed to start with an 'x' in 120b57d1.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This should make it easier to add browser tests as you won't have to
get the click precisely on the right pixel in order to have it match
the correct area.
|
|
|
|
|
| |
Due to refactoring in 12d2346, this was loading prior
to the main asset code and thus not activating.
|
|
|
|
|
|
|
| |
This makes it clearer that all details for a report made in a private
category will not be shown publicly.
Fixes mysociety/fixmystreet-commercial#1405
|
|
|
|
|
| |
Allow users on narrow screens to filter the pins displayed on the
map page, using the regular `.report-list-filters`.
|
|\ \ |
|
| | | |
|
| |/
|/| |
|
| | |
|
|/
|
|
|
|
|
|
|
| |
There is a small bug where if you go to a two-tier location, pick a
category that is sent to one of the two ("These will be sent to" text
updates to only show that one), then click elsewhere on the map, the
"These will be sent to" text resets to show both bodies. This happens
because fixmystreet.bodies is reset after the text has been correctly
set by the category change() setup (called on pin move also).
|