| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
|
| |
/around will now show all reports all the time, but we are about to
introduce pagination to stop that.
|
|
|
|
|
| |
Both /reports and /my work by using the same URL with ajax=1. We should
use the same on /around for consistency.
|
|
|
|
|
|
|
| |
This should fix #1886, which was caused by the update of Module::Build
as part of f97088d6 removing Module::Build::ModuleInfo which was still
being required by Module::ScanDeps. This was passing on Travis because
Module::ScanDeps was already installed.
|
|
|
|
|
|
|
|
|
|
| |
If a user is trying to remove a problem from their shortlist we should
always allow it regardless of the state of the problem. Previously if a
problem wasn't displayed on the site then it could not be removed from
the shortlist which was an issue with council cobrands and reports that
had changed body.
Fixes mysociety/fixmystreetforcouncils#243
|
|
|
|
| |
This removes unnecessary whitespace to reduce the output size.
|
|
|
|
| |
otherwise the login doesn't work post sms auth changes.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Make sure that all relevant options in the filter status drop down are
checked to handle staff users who can see the full set of states and not
just open, closed and fixed
Also restore custom label for no states checked.
Fixes mysociety/forcouncils#227
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
|/
|
|
|
|
|
| |
It was possible to mark a report as a duplicate in the inspector panel
without providing an id of the duplicate. This prevents that.
Fixes mysociety/fixmystreetforcouncils#236
|
|
|
|
|
| |
Do not try and redirect to a report that won't be viewable on the
cobrand being used.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Create a comment on a problem when the admin is used to change the state
of the problem. If only the state is changed then create a comment with
blank text. If the category and state are changing then include details
of the category change in the comment.
Not all the state changes are displayed at the template level by
default.
Fixes #1846
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Don't think the return data ever needs decoding.
|
| | |
| | |
| | |
| | | |
This means variables do not need decoding in a few places.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When the tests are run normally, using bin/run-tests, 00-check-config.t
is pointless as the config will have been newly set up from the example
file. To prevent running except through run-tests, check when test_mode
is set, dying if the live config file has been used.
|
| | |
| | |
| | |
| | | |
An unneeded "END" was introduced in c7d98f98, sorry.
|
| |/
|/|
| |
| |
| | |
Any map bar the already-full-screen /around map could benefit from
the expand map option, especially the list of your reports.
|
| |
| |
| |
| |
| |
| | |
A full modal made it hard to perform multiple zooms/pans, making
the site slower to use than necessary. Tell the user the site is
updating, but let them interact with the map at the same time.
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
URLs have to be manually constructed, but specifying multiple ward names
separated by "|" will show all those wards and their reports on the map.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If there was a normal email alert, and then an alert for an update with
no text (so no email should be sent), it would still try to send the
blank email, and then die because no e.g. $data{cobrand} set.
This moves the skip-blank-update check higher up, above any email
sending code.
|
| | | |
|
| | | |
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | | |
We have no way of knowing whether a +1 geographic number is fixed
line or mobile, so accept them all as potentially mobile.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This lookup is often performed by inspectors with appcache switched on,
which means they were getting the intercepted Glitch page rather than a
404; give them a no results page instead.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes a crash when leaving an update on the Oxfordshire cobrand or
signing up for an alert, as the _email_sent_extra.html template didn’t
have a report to pass through to the cobrand in order to display the
expected response time.
|
|/ /
| |
| |
| |
| |
| | |
It was possible to trigger an SQL error by entering a value larger than
that permitted by the `integer` SQL type. This commit instead returns a
404 in that case.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This resolves two issues when updating the report category in the
staff users inspect form:
* report category is only updated if the rest of the form is valid
* only one update on the report is left
Previously changing the category would create an update in addition to
any public update created, and the category was always updated even when
validation errors occurred elsewhere in the form.
|
| |
| |
| |
| |
| | |
If no problems have changed status then set the average to -1 so we can
cope with an average status change of 0 days.
|
|/
|
|
|
|
|
|
|
|
|
| |
Doing this calculation in code turns out to be much too slow.
As part of this also fix an issue where if a report changed state last
month but had a further comment this month that was counted as being
a state change this month.
Also tweak the 'last month' start date to be midnight so the stats don't
change throughout the day.
|
|
|
|
|
|
| |
By default encode_entities uses named entities, which don't exist
by default in XML. It seemed nicer to switch to only escaping the
minimum rather than switching to numeric entities.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This expands the 'change email' functionality to work with phone
number also, allow addition of missing details, and verifying of
unverified details.
|