aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Add pagination to around page.Matthew Somerville2017-11-06-48/+177
|
* Remove Show all pins link and on_map_list_limit.Matthew Somerville2017-11-06-142/+15
| | | | | /around will now show all reports all the time, but we are about to introduce pagination to stop that.
* Have /around ajax use same format as others.Matthew Somerville2017-11-02-23/+28
| | | | | Both /reports and /my work by using the same URL with ajax=1. We should use the same on /around for consistency.
* Update Module::ScanDeps dependency.Matthew Somerville2017-10-31-21/+8
| | | | | | | This should fix #1886, which was caused by the update of Module::Build as part of f97088d6 removing Module::Build::ModuleInfo which was still being required by Module::ScanDeps. This was passing on Travis because Module::ScanDeps was already installed.
* always allow problems to be removed from shortlistStruan Donald2017-10-27-8/+165
| | | | | | | | | | If a user is trying to remove a problem from their shortlist we should always allow it regardless of the state of the problem. Previously if a problem wasn't displayed on the site then it could not be removed from the shortlist which was an issue with council cobrands and reports that had changed body. Fixes mysociety/fixmystreetforcouncils#243
* Add collapse filter to translation JavaScript.Matthew Somerville2017-10-25-0/+2
| | | | This removes unnecessary whitespace to reduce the output size.
* [demo] set email_verified to true when creating demo usersStruan Donald2017-10-23-5/+5
| | | | otherwise the login doesn't work post sms auth changes.
* Merge branch 'reports-dashboard-councils'Matthew Somerville2017-10-20-115/+456
|\
| * [fixmystreet.com] Council pages only from council.Matthew Somerville2017-10-20-11/+231
| |
| * Front end way of viewing council dashboard.Matthew Somerville2017-10-20-26/+77
| |
| * update-all-reports operate per body optionally.Matthew Somerville2017-10-20-59/+121
| |
| * Allow testing override of /reports data.Matthew Somerville2017-10-16-27/+35
| |
* | [Borsetshire] Update password-less login for new "username" fieldZarino Zappia2017-10-20-2/+2
| |
* | Merge branch 'issues/forcouncils/227-all-filter'Struan Donald2017-10-20-10/+42
|\ \
| * | select all applicable filter states on report pageStruan Donald2017-10-18-10/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure that all relevant options in the filter status drop down are checked to handle staff users who can see the full set of states and not just open, closed and fixed Also restore custom label for no states checked. Fixes mysociety/forcouncils#227
* | | Remove hidden from default staff state dropdown.Matthew Somerville2017-10-18-1/+1
| | |
* | | Tidy up report page permission checkings.Matthew Somerville2017-10-18-20/+10
| | |
* | | [Bromley] Remove override display template.Matthew Somerville2017-10-18-69/+31
| | |
* | | [Oxfordshire] Add initials/traffic to RDI desc.Matthew Somerville2017-10-18-24/+32
| | |
* | | Fix example dashboard categories/states.Matthew Somerville2017-10-18-14/+14
|/ /
* / make sure duplicate id provided when marking as duplicateStruan Donald2017-10-17-8/+71
|/ | | | | | | It was possible to mark a report as a duplicate in the inspector panel without providing an id of the duplicate. This prevents that. Fixes mysociety/fixmystreetforcouncils#236
* Redirect inspectors correctly on creation.Matthew Somerville2017-10-16-2/+7
| | | | | Do not try and redirect to a report that won't be viewable on the cobrand being used.
* Merge branch 'sms-mssid-error'Matthew Somerville2017-10-16-84/+71
|\
| * Factor the three SMS code checking fns together.Matthew Somerville2017-10-12-27/+9
| |
| * Add option to use a Twilio Messaging Service.Matthew Somerville2017-10-12-1/+8
| |
| * Spot errors coming back when sending text.Matthew Somerville2017-10-12-56/+54
| |
* | log all state changes in admin as commentsStruan Donald2017-10-16-20/+338
| | | | | | | | | | | | | | | | | | | | | | | | Create a comment on a problem when the admin is used to change the state of the problem. If only the state is changed then create a comment with blank text. If the category and state are changing then include details of the category change in the comment. Not all the state changes are displayed at the template level by default. Fixes #1846
* | Merge branch 'bit-of-yaml-tidying'Matthew Somerville2017-10-11-76/+27
|\ \
| * | Simplify geocode cache read/writing.Matthew Somerville2017-10-10-14/+17
| | | | | | | | | | | | Don't think the return data ever needs decoding.
| * | Upgrade commonlib to read in config as Unicode.Matthew Somerville2017-10-10-11/+7
| | | | | | | | | | | | This means variables do not need decoding in a few places.
| * | Better testing for tests run on live site.Matthew Somerville2017-10-10-51/+3
| | | | | | | | | | | | | | | | | | | | | When the tests are run normally, using bin/run-tests, 00-check-config.t is pointless as the config will have been newly set up from the example file. To prevent running except through run-tests, check when test_mode is set, dying if the live config file has been used.
* | | [FixaMinGata] Fix broken submit email template.Matthew Somerville2017-10-10-1/+0
| | | | | | | | | | | | An unneeded "END" was introduced in c7d98f98, sorry.
* | | Add expand map toggle to more mobile maps.Matthew Somerville2017-10-09-1/+2
| |/ |/| | | | | | | Any map bar the already-full-screen /around map could benefit from the expand map option, especially the list of your reports.
* | Stop loading spinner covering map.Matthew Somerville2017-10-09-21/+27
| | | | | | | | | | | | A full modal made it hard to perform multiple zooms/pans, making the site slower to use than necessary. Tell the user the site is updating, but let them interact with the map at the same time.
* | Merge branch 'issues/forcouncils/231-multi-ward-reports-view'Matthew Somerville2017-10-09-23/+59
|\ \
| * | Allow ward page to show multiple wards.Matthew Somerville2017-10-06-23/+59
| | | | | | | | | | | | | | | URLs have to be manually constructed, but specifying multiple ward names separated by "|" will show all those wards and their reports on the map.
* | | Fix issue sending alerts around no-text update.Matthew Somerville2017-10-06-14/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | If there was a normal email alert, and then an alert for an update with no text (so no email should be sent), it would still try to send the blank email, and then die because no e.g. $data{cobrand} set. This moves the skip-blank-update check higher up, above any email sending code.
* | | generate update text in alerts if problem state has changedStruan Donald2017-10-05-9/+205
| | |
* | | do not send blank problem update alertsStruan Donald2017-10-05-9/+3
| | |
* | | Merge remote-tracking branch 'origin/fix-geographic-mobile-numbers'Matthew Somerville2017-10-05-44/+47
|\ \ \
| * | | Accept +1 geographic numbers as possibly mobile.Matthew Somerville2017-10-05-44/+47
| |/ / | | | | | | | | | | | | We have no way of knowing whether a +1 geographic number is fixed line or mobile, so accept them all as potentially mobile.
* | | Return page with "No results" if no ref found.Matthew Somerville2017-10-05-15/+23
| | | | | | | | | | | | | | | | | | This lookup is often performed by inspectors with appcache switched on, which means they were getting the intercepted Glitch page rather than a 404; give them a no results page instead.
* | | [Oxfordshire] Stop crash on alert signup/update.Dave Arter2017-10-05-1/+2
| | | | | | | | | | | | | | | | | | | | | This fixes a crash when leaving an update on the Oxfordshire cobrand or signing up for an alert, as the _email_sent_extra.html template didn’t have a report to pass through to the cobrand in order to display the expected response time.
* | | Fix crash if large number given in postcode field.Dave Arter2017-10-05-2/+9
|/ / | | | | | | | | | | It was possible to trigger an SQL error by entering a value larger than that permitted by the `integer` SQL type. This commit instead returns a 404 in that case.
* | correctly handle category changes in inspector formStruan Donald2017-10-04-14/+150
| | | | | | | | | | | | | | | | | | | | | | This resolves two issues when updating the report category in the staff users inspect form: * report category is only updated if the rest of the form is valid * only one update on the report is left Previously changing the category would create an update in addition to any public update created, and the category was always updated even when validation errors occurred elsewhere in the form.
* | correctly handle average state changes of 0 days in area statsStruan Donald2017-10-04-2/+19
| | | | | | | | | | If no problems have changed status then set the average to -1 so we can cope with an average status change of 0 days.
* | move area stats page problems by status calc into databaseStruan Donald2017-10-04-9/+22
|/ | | | | | | | | | | Doing this calculation in code turns out to be much too slow. As part of this also fix an issue where if a report changed state last month but had a further comment this month that was counted as being a state change this month. Also tweak the 'last month' start date to be midnight so the stats don't change throughout the day.
* In RSS, only escape the necessary five/ctrl chars.Matthew Somerville2017-10-02-5/+15
| | | | | | By default encode_entities uses named entities, which don't exist by default in XML. It seemed nicer to switch to only escaping the minimum rather than switching to numeric entities.
* Merge branch 'phone-number-work'Matthew Somerville2017-09-30-1137/+3471
|\
| * Allow verify/change/add email/phone in profile.Matthew Somerville2017-09-30-38/+362
| | | | | | | | | | | | This expands the 'change email' functionality to work with phone number also, allow addition of missing details, and verifying of unverified details.