aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* [Buckinghamshire] Move important para higher up.Matthew Somerville2018-04-23-8/+9
| | | | | This also moves the 'this will be public' text next to the fields it applies to.
* Don’t trigger response templates unless problem state changesDave Arter2018-04-23-15/+38
| | | | | | | Response templates won't be triggered unless the problem state or external status code is changed. Fixes #2075
* hide deleted contacts by defaultStruan Donald2018-04-23-1/+6
| | | | | | | If JavaScript is enabled hide the deleted contacts from the list on the body page. Display as normal if no JavaScript. Fixes #1962
* [Buckinghamshire] Increase fallback USRN lookup radius to 10MDave Arter2018-04-20-1/+1
| | | | | It’s not quite a ‘radius’ as it’s a square box, but this does bring it closer in line with the cobrand JS behaviour.
* Ensure USRN asset lookup JS is run on /report/newDave Arter2018-04-20-9/+41
| | | | | | | | | If the user visits /report/new directly and doesn't change the pin location, then the assets:selected/maps:update_pin events are never fired and fixmystreet.usrn.select is never called. This results in a report whose location was never looked up against the USRN layer, which can cause issues for Open311 endpoints that require a USRN value.
* Update Vagrantfile to use Xenial.Matthew Somerville2018-04-18-8/+2
|
* [Open311] avoid spurious warning when params are undefStruan Donald2018-04-17-8/+66
| | | | | | | If there was an undefined parameter passed to `_post` then generating the debug string would generate a warning about an undefined value in a concatenation. So, check for undefined params and substitute empty string to avoid.
* Merge branch '2079-check-latest-deploy'Matthew Somerville2018-04-17-4/+15
|\
| * Abort if a script is run in an old deploy.Matthew Somerville2018-04-16-4/+15
| |
* | [Open311] correctly handle one word names when splittingStruan Donald2018-04-17-2/+16
|/ | | | | | If a name only had a single word we were failing to split it and not setting `first_name`. Also refactor splitting out to a function so the regex is only in one place.
* Always set memcached namespace.Matthew Somerville2018-04-16-12/+4
| | | | | | The namespace was only being set in the web loop, so cron scripts were accessing different memcached keys. In particular, the state list would be shared between instances on the same host.
* [Oxfordshire] Fix admin exor download page.Matthew Somerville2018-04-16-5/+5
| | | | | 07906f40 changed the HTML date input form, but did not update the server parsing of the format.
* [FixaMinGata] Remove a state label from the staff dropdown menuJon Kristensen2018-04-13-0/+8
|
* Merge branch 'mapit-proxy-api-key'Matthew Somerville2018-04-13-2/+27
|\
| * Provide API key to MapIt proxy if present.Matthew Somerville2018-04-12-2/+27
| |
* | Merge remote-tracking branch 'github/faq-anonymise'Matthew Somerville2018-04-13-1/+5
|\ \
| * | Add info on anonymisation featureabimysoc2018-04-11-1/+5
| | | | | | | | | Since https://github.com/mysociety/fixmystreet/pull/1554 it has been possible for a user to hide their name on their reports and updates, rather than having to contact support. This PR updates the FAQ to mention that.
* | | [Open311] Pretty print all request parameters.Matthew Somerville2018-04-13-4/+10
| | |
* | | Don’t send alert emails when archiving old reportsDave Arter2018-04-12-1/+51
| |/ |/|
* | Merge branch 'open311-update-problem-state'Matthew Somerville2018-04-11-17/+18
|\ \ | |/ |/|
| * [Open311] Generally store update state.Matthew Somerville2018-04-10-17/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, an update's problem_state was set via an Open311 update if: * the update timestamp was equal or greater to the report's last update; * the new state was visible, and not equal to the report's current state; * the update wouldn't change the report from a fixed state to another fixed state; * (Oxfordshire) the update wouldn't change the report from any open state to Open. It would also set the report's state to match if the report was currently visible. This mostly worked, but could lead to issues if e.g. the report started life in a non-confirmed state (e.g. we pulled it in already fixed from an external source), as then the update did not record its state and the update display got confused as to the state history. However it did mean there wasn't confusion if a later update than the Open311 update was made on the site itself. This new code will set an update's problem_state if: * the new state is visible; * the update wouldn't change the report from a fixed state to another fixed state; * (Oxfordshire) the update wouldn't change the report from any open state to Open. It will also set the report's state to match if the report is currently visible, changing state, and the update timestamp is equal or greater to the report's last update. So when the report state changes is unchanged, all the conditions still apply, but the update's problem_state is set more often (it will be set regardless of whether the timestamps align, or whether the state matches the report's current state). This could theoretically lead to issues elsewhere, e.g. if an update is left on a report on FixMyStreet and then an Open311 update is pulled in later (but with an earlier timestamp) that changes the state, the report state will not be updated due to the later update being made, though the Open311 update will list the state change, and then the later update might say it changed it back (if it recorded the current state in its problem_state), even though it technically did not. I think this issue is less worrying than the current situation, which can state that a random update has fixed a report when it was the previous update that did, and there will always be such issues with multiple sources of truth for a report status. An alternative would be to allow the Open311 update to override.
* | [BANES] Add Google Analytics scriptDave Arter2018-04-11-0/+13
| |
* | admin UI to configure fetch_all_problems Open311 optionStruan Donald2018-04-11-5/+71
| | | | | | | | | | | | UI to update the fetch_all_problems setting in extra for a body. This also adds handling for extra body values in the Admin in a similar manner to the way other body params are handled.
* | [Open311] fetch_all option for open311 problem fetchingStruan Donald2018-04-11-8/+59
| | | | | | | | | | | | | | | | | | If a body has a `fetch_all_reports` setting in the extra metadata then all reports are fetched over Open311 and processed regardless of age. This is useful for bodies where the API endpoint always returns all the reports as it suppresses the error messages you would otherwise get about reports with invalid dates.
* | group the open 311 endpoint options in admin interfaceStruan Donald2018-04-11-55/+64
| | | | | | | | | | Makes a bit more sense to group those relating to sending/receiving comments together and those relating to fetching comments together.
* | add extra column to body tableStruan Donald2018-04-11-4/+22
| | | | | | | | Adds and extra column for bodies and the associated Extra role.
* | Add link to edit current report in adminDave Arter2018-04-11-0/+29
| | | | | | | | | | | | | | I find myself wanting to view the current report in the admin all the time - this commit adds a link to the top of the inspector column that goes right there. Only visible for superusers and staff users with permission to actually view the admin.
* | [BANES] Limit categories visible on cobrandDave Arter2018-04-10-0/+17
|/
* Reliably sort send methods in admin.Matthew Somerville2018-04-10-2/+2
|
* [BANES] Update archive email template wordingDave Arter2018-04-10-6/+8
|
* Lower case/strip whitespace from email addresses during user importDave Arter2018-04-10-0/+2
|
* Fix again test script running on PostgreSQL 9.1.Matthew Somerville2018-04-10-2/+4
| | | | | It was not enough to move the schema to a separate run, the two fixtures need to be separate too.
* Update DateTime::TimeZone.Matthew Somerville2018-04-10-440/+489
|
* [BANES] Add cobrand base_urlDave Arter2018-04-10-0/+6
|
* Merge branch 'issues/commercial/795-bath-demo'Dave Arter2018-04-10-161/+3426
|\
| * [BANES] Hide email address from contact formDave Arter2018-04-10-6/+0
| |
| * [BANES] Add archive email templateDave Arter2018-04-10-0/+81
| |
| * [BANES] Update contact addressDave Arter2018-04-10-1/+1
| |
| * [BANES/Buckinghamshire] Make it simpler to override report form elementsDave Arter2018-04-10-135/+17
| |
| * [BANES/Buckinghamshire] Share ‘report sent’ emails between cobrandsDave Arter2018-04-10-198/+15
| |
| * Add layer attribution to attribution controlStruan Donald2018-04-10-0/+6
| | | | | | | | | | If a layer has an attribution option then add it to the attribution control when the layer becomes visible.
| * [BANES] add attribution details to road layerStruan Donald2018-04-10-1/+2
| |
| * [BANES] remove fill from LLPG layer labelsStruan Donald2018-04-10-2/+1
| |
| * [BANES] Rejig front page layout to put emergency text beneath postcode fieldDave Arter2018-04-10-5/+16
| |
| * [BANES] Pass fixed search string back to geocoderDave Arter2018-04-10-0/+1
| |
| * Geocoders: allow cobrands to fixup user's search stringDave Arter2018-04-10-0/+6
| | | | | | | | | | This is useful, for example, if the cobrand has a list of common typos that you want to account for.
| * [BANES] Include FMS ID as council ref on sent reportsDave Arter2018-04-10-0/+17
| |
| * [BANES] Tweaks to text display.Matthew Somerville2018-04-10-4/+10
| | | | | | | | Note use of inline style.
| * Factor out show name tickbox, used same everywhere.Matthew Somerville2018-04-10-14/+8
| |
| * [BANES] Send email when Open311 update submitted.Matthew Somerville2018-04-10-4/+62
| |
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-25 10:27:54 +0000