| Commit message (Collapse) | Author | Age | Lines |
... | |
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | | |
Add an update with each report closure.
|
|/ /
| |
| |
| | |
This makes it clearer what is being shown.
|
| |
| |
| |
| |
| | |
Our fork was merged upstream.
This reverts commit 77d4d709.
|
| | |
|
|/
|
|
|
| |
When running on a Mac, the dev server only
watches changes to directories, not files.
|
|\ |
|
| |
| |
| |
| |
| | |
The code for moving a report to the intermediary state was running
even if the report was in a closed state and had not been changed.
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Plus remove some now-unneeded CSS.
|
| | |
| | |
| | |
| | |
| | | |
If you rotated a photo, updates and the category list weren't loaded. If you
changed a report's state, the map pin colour was derived from the old state.
|
| | | |
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 5px cellpadding on the wrapper table was resulting in 15px of white
space either side of emails when viewed on narrow screens. Which, on a
window that could be as narrow as 320px, is a lot of wasted space!
We only wanted the 15px of horizontal padding to be removed from the
sides of the "main" content, leaving the top and bottom "hints" with
some padding so that their text doesn’t crash up against the edge of
the window on narrow screens.
The easiest way to achieve this was to split the top and bottom "hints"
out into their own slightly wider tables, with built-in cell padding.
To make things simpler, the min- and max-widths are now stored in
variables, and the changes also meant we could simplify the media
queries controlling mobile breakpoints in modern email clients.
Fixes #1928.
|
|
|
|
| |
Looks like sq was missed due to incorrect last-modified date.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Y-axis labels in the Dashboard ranking tables now break onto multiple
lines if they are more than 4 words long.
/web/vendor/chart.min.js showing as modified because we updated it to
include a recent fix to label alignment on vertical scales:
https://github.com/mysociety/Chart.js/commit/4130c31
|
|/
|
|
|
|
|
|
| |
The tiny buttons could prove hard to trigger, especially on touchscreen
devices, and with large screens now more commonplace, there’s no reason
not to give them a few more pixels.
One of a number of enhancements suggested in #1462.
|
|
|
|
|
| |
The addition of e.g. questionnaire_id to an update's
extra field means this check has to be more nuanced.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using grouped categories on the new report form, the selected
category was being lost when dragging the pin or clicking elsewhere on
the map. This was causing the asset layers to be hidden as well as the
report extra input to be lost.
I'd assumed that cloning an <option> element that was selected and
adding it to the parent <select> would set the value of that <select>
correctly, but that doesn't seem to be the case. Instead, this commit
explicitly sets the <select>'s value after appending a selected <option>
element.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some cobrands require reports to include the USRN of the clicked
road. This commit allows an asset layer to be added and designated
as a 'USRN provider' by setting its `usrn_field` property when calling
fixmystreet.assets.add.
Initially this feature used OpenLayers' getFeatureFromEvent method,
however that doesn't work if the layer isn't topmost. This is because it
uses the clicked element in the DOM to determine which feature was
clicked. This doesn't work if the layer you're trying to get the feature
from wasn't actually the DOM element that was clicked.
Instead, we add a new method, OpenLayers.Layer.Vector.getFeatureAtPoint
method which takes a Point object and iterates through the features'
geometries to find the matching point.
To make things a little more user-friendly, if an asset isn't clicked
directly we find the closest to the clicked point and use that for the
USRN. To accomplish this, this commit factors out the ‘select nearest
asset’ code into a new method OpenLayers.Layer.Vector.getNearestFeature,
which takes a Point and a distance threshold and finds the nearest
feature.
|
|
|
|
| |
layer
|
|
|
|
|
|
|
|
|
| |
We’re interested in seeing whether people are mistakenly clicking the
(inert) "Click map to report a problem" banner on the `/around` page.
This will record a Google Analytics event if and when they do.
Fixes mysociety/fixmystreet-commercial#963.
|
|
|
|
|
|
|
|
| |
The underlying DOM structure returned from /report/xx/nearby.json had
changed, meaning the "Which report is it a duplicate of?" list on the
inspector form wasn't displaying any reports. This commit introduces a
template specifically for the nearby URL instead of overloading the
on_map_list_items template.
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This means the questionnaire is considered 'answered' as soon as
a (HTML) link is clicked, which I think is okay. Then filling in
the questionnaire form will update the same questionnaire.
|
| | |
|
| |
| |
| |
| |
| | |
This means we don't show separate 'Still open' messages
when an update was also left at the same time.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
This reverts commit 549d1cc66e591cf2da6b5243fbd28c7f40e75f14.
|
| |
| |
| |
| |
| |
| |
| | |
This simplifies the asset layer loading code to allow multiple layers to
be created and added to the map at the correct time. This also means
always_visible layers are, in fact, always visible, and not hidden
when the map is clicked or a category-specific asset layer is shown.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit allows asset layers to be added to the map that have more
complex behaviours than simply 'click a marker'.
- Layers can be non-interactive and/or always visible
Previously an asset layer would only be shown when its associated
category was chosen from the dropdown. You can now add layers which
are always visible, as well as ignoring user input. Useful for, e.g.
showing an LLPG overlay on the map.
- Stylemaps can be provided for individual layers
This means you can, for example, have custom rules for styling
features based on their attributes or other complex rules.
- Functions can be used for the feature/report field mapping
Instead of a one-to-one mapping between feature attributes and
fields on the new report form, you can provide a callback function
which can provide a calculated value to the report form.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit makes it easier to customise the way asset layers are loaded
over WFS, including:
- Adds support for WFS layers via GET method
The standard HTTP method for WFS GetFeature requests is POST, but
some WFS services only support GET. OpenLayers.Protocol.WFS is
hardcoded to use POST, but we can use OpenLayers.Protocol.HTTP
instead to use GET.
The options passed to fixmystreet.add_assets should include a
'http_options' object which configures the HTTP protocol.
- Allows HTTP asset layers to provide their own format
This makes it simpler to use GeoJSON, for example, instead of the
default of GML.
- Asset layers can provide their own loading strategy
The default strategy can be overridden if, for example, you want to
use a BBOX strategy with a smaller ratio in order to load fewer
features at a time.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It seems that the projectInverse/projectForward methods in
OpenLayers.Layer.SphericalMercator have been renamed which was causing
problems.
Additionally this gem was buried in the OpenLayers.Projection.transform
docs:
Returns point - [...] The original point is modified.
The previous code didn't seem to modify the original point which was
confusing OpenLayers.
|
|\ \
| |/
|/| |
|
| | |
|