| Commit message (Collapse) | Author | Age | Lines |
... | |
| | |
| | |
| | |
| | | |
Fixes mysociety/FixMyStreet-Commercial#1024.
|
|/ /
| |
| |
| |
| |
| |
| | |
If a new user registers during the report/update process
and their password starts or ends with whitespace or has
consecutive whitespace chars then those would be stripped
and the entered password wouldn’t work for subsequent logins.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous approach of requesting a small bounding box from the
WFS server and using the first asset, if any, wasn’t sufficiently
tolerant of reports that were made more than 5M away from a road,
of which there were many. The problem with extending the bounding
box used to fetch assets from the server is that the order of the
returned assets didn’t have any bearing on their proximity to the
centre of the bounding box (i.e., the location of the report). As
an alternative approach this commit changes the method to instead
fetch all assets within a much wider bounding box surrounding the
report and iterates across the returned features in order to find
the closest point and uses the site_code value from that feature.
|
|/
|
|
|
|
|
|
| |
Instead of just a Yes/No display a formatted list of values in extra.
Has special handling for known fields otherwise just prints them out
dumbly.
Fixes #1809
|
|
|
|
|
|
|
|
|
| |
Previously send-comments errors would only be printed the first time
they occurred so there was no visibility of ongoing errors. This brings
send-comments in line with send-reports by emitting errors if the script
is called with --verbose.
Fixes #2091
|
|\ |
|
| | |
|
| |
| |
| |
| | |
This makes it easier to override them.
|
| | |
|
| |
| |
| |
| |
| | |
One to alter the category after initially set, one to change
any details of the report before saving to the database.
|
| | |
|
| |
| |
| |
| |
| | |
This allows a cobrand to e.g. display a subset
of bodies based on a query parameter.
|
| |
| |
| |
| | |
This allows a cobrand to categorise the reports however it wishes.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Add a more helpful error message when a problem fetched over Open311 is
rejected for problems with the date.
|
| | |
|
| | |
|
| |
| |
| |
| | |
This hopefully works around some odd test failures on Travis.
|
| |
| |
| |
| |
| | |
This also moves the 'this will be public'
text next to the fields it applies to.
|
| |
| |
| |
| |
| |
| |
| | |
Response templates won't be triggered unless the problem state or
external status code is changed.
Fixes #2075
|
| |
| |
| |
| |
| |
| |
| | |
If JavaScript is enabled hide the deleted contacts from the list on the
body page. Display as normal if no JavaScript.
Fixes #1962
|
| |
| |
| |
| |
| | |
It’s not quite a ‘radius’ as it’s a square box, but this does
bring it closer in line with the cobrand JS behaviour.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the user visits /report/new directly and doesn't change the pin
location, then the assets:selected/maps:update_pin events are never
fired and fixmystreet.usrn.select is never called. This results in a
report whose location was never looked up against the USRN layer,
which can cause issues for Open311 endpoints that require a USRN
value.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
If there was an undefined parameter passed to `_post` then generating
the debug string would generate a warning about an undefined value in a
concatenation. So, check for undefined params and substitute empty
string to avoid.
|
|\ \ |
|
| |/ |
|
|/
|
|
|
|
| |
If a name only had a single word we were failing to split it and not
setting `first_name`. Also refactor splitting out to a function so the
regex is only in one place.
|
|
|
|
|
|
| |
The namespace was only being set in the web loop, so cron scripts
were accessing different memcached keys. In particular, the state
list would be shared between instances on the same host.
|
|
|
|
|
| |
07906f40 changed the HTML date input form, but did
not update the server parsing of the format.
|
| |
|
|\ |
|
| | |
|
|\ \ |
|
| | |
| | |
| | | |
Since https://github.com/mysociety/fixmystreet/pull/1554 it has been possible for a user to hide their name on their reports and updates, rather than having to contact support. This PR updates the FAQ to mention that.
|
| | | |
|
| |/
|/| |
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, an update's problem_state was set via an Open311 update if:
* the update timestamp was equal or greater to the report's last update;
* the new state was visible, and not equal to the report's current state;
* the update wouldn't change the report from a fixed state to another fixed state;
* (Oxfordshire) the update wouldn't change the report from any open state to Open.
It would also set the report's state to match if the report was currently visible.
This mostly worked, but could lead to issues if e.g. the report started life in
a non-confirmed state (e.g. we pulled it in already fixed from an external
source), as then the update did not record its state and the update display got
confused as to the state history. However it did mean there wasn't confusion if
a later update than the Open311 update was made on the site itself.
This new code will set an update's problem_state if:
* the new state is visible;
* the update wouldn't change the report from a fixed state to another fixed state;
* (Oxfordshire) the update wouldn't change the report from any open state to Open.
It will also set the report's state to match if the report is currently
visible, changing state, and the update timestamp is equal or greater to the
report's last update.
So when the report state changes is unchanged, all the conditions still apply,
but the update's problem_state is set more often (it will be set regardless of
whether the timestamps align, or whether the state matches the report's current
state).
This could theoretically lead to issues elsewhere, e.g. if an update is left on
a report on FixMyStreet and then an Open311 update is pulled in later (but with
an earlier timestamp) that changes the state, the report state will not be
updated due to the later update being made, though the Open311 update will list
the state change, and then the later update might say it changed it back (if it
recorded the current state in its problem_state), even though it technically
did not. I think this issue is less worrying than the current situation, which
can state that a random update has fixed a report when it was the previous
update that did, and there will always be such issues with multiple sources of
truth for a report status. An alternative would be to allow the Open311 update
to override.
|
| | |
|
| |
| |
| |
| |
| |
| | |
UI to update the fetch_all_problems setting in extra for a body. This also
adds handling for extra body values in the Admin in a similar manner to the
way other body params are handled.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a body has a `fetch_all_reports` setting in the extra metadata then
all reports are fetched over Open311 and processed regardless of age.
This is useful for bodies where the API endpoint always returns all the
reports as it suppresses the error messages you would otherwise get
about reports with invalid dates.
|
| |
| |
| |
| |
| | |
Makes a bit more sense to group those relating to sending/receiving
comments together and those relating to fetching comments together.
|
| |
| |
| |
| | |
Adds and extra column for bodies and the associated Extra role.
|
| |
| |
| |
| |
| |
| |
| | |
I find myself wanting to view the current report in the admin all the time -
this commit adds a link to the top of the inspector column that goes right there.
Only visible for superusers and staff users with permission to actually view the
admin.
|
|/ |
|