| Commit message (Collapse) | Author | Age | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
|
| |
Dealing with the map UI changes earlier leads to a better display
position, and we add a global variable check to allow cobrands to
not use this behaviour. Fixes #1863.
|
| |
|
|
|
| |
The scroll position wa being remmbered, meaning
the full-page map was not being shown correctly.
|
| |\ |
|
| | |
| |
| |
| |
| |
| | |
This can cause issues with e.g. multi-language sites, and was
only needed for cases where the admin was proxied, which we do
not suggest any more.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On a mobile device that implements pointer events, there are two events that
can happen on an /around page – touching the map starts a new report (or goes
back to the map if already on a report page); touching a pin pulls in that
report’s page. The map touch, which uses an OpenLayers.Handler.Click, operates
on click, whereas the pin touch, which uses an OpenLayers.Handler.Feature,
operates on touchstart. Neither event cancels the other, which means you can
end up either starting a new report, and then it tries to pull in an undefined
pin ID report and errors, or the pin report loads and then you instantly go
back to the map page.
In order to work around this, we disable the map click control when the feature
control event starts, and reactivate once the report data has been loaded.
|
| | |
| |
| |
| |
| | |
Return an error if an id for either a hidden update or one not
associated with the problem id is passed to the contact form.
|
| |/
|
|
|
|
| |
We get quite a few emails to support that are about a specific problem
but fail to include a link to that problem. This adds some text to the
contact form to ask people to do so.
|
| |\ |
|
| | |
| |
| |
| |
| | |
Otherwise a non-interactive layer applying to the same category
as an asset layer can cause an ‘undefined’ message to appear.
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
|
| |
Going back to /around from /report/new can trigger loadend (and the
spinner hiding function) twice (if the strategy activation starts a
read), with triggerRead aborting that read and triggering the event
itself. This means the spinner is not displayed, as the count falls
below 0. We could pin the count above 0, but instead let’s log each
layer ID while ‘active’ and switch off when they’re all gone.
|
| | |
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| | |
The inactive report script can mark matched reports as closed for updates.
This removes the update form and signing up for updates from a report page.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
This fixes a bug whereby a double quote in an item would not be JSON-escaped
due to being HTML-escaped first, meaning it would not parse as JSON on the
client.
|
| |/
|
|
| |
Fixes #2124.
|
| |
|
|
|
| |
This maps better to the states shown in the front end
and prevents e.g. multiple fixed states appearing.
|
| |
|
|
| |
Fixes mysociety/fixmystreetforcouncils#231
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
This is shown when reporting and in map list filters.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since #map_sidebar no longer disappears behind #site_header, there is
no need for .internal-link-fixed-header to compensate for the height
of the header. Just an arbitrary 2em offset is enough to prevent it
butting up against the top of the #map_sidebar scrollable element.
Meanwhile, moving the .internal-link-fixed-header anchor element to
the top of its parent list item means it no longer has to compensate
for the height of the moderation form elements, because those elements
(indeed, the entire list item <form>) now comes *after* the anchor.
Fixes mysociety/fixmystreet-commercial#1027.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
If a new user registers during the report/update process
and their password starts or ends with whitespace or has
consecutive whitespace chars then those would be stripped
and the entered password wouldn’t work for subsequent logins.
|
| |
|
|
|
|
|
|
| |
Instead of just a Yes/No display a formatted list of values in extra.
Has special handling for known fields otherwise just prints them out
dumbly.
Fixes #1809
|
| |
|
|
|
|
|
|
|
| |
Previously send-comments errors would only be printed the first time
they occurred so there was no visibility of ongoing errors. This brings
send-comments in line with send-reports by emitting errors if the script
is called with --verbose.
Fixes #2091
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
If JavaScript is enabled hide the deleted contacts from the list on the
body page. Display as normal if no JavaScript.
Fixes #1962
|
| |/ |
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, an update's problem_state was set via an Open311 update if:
* the update timestamp was equal or greater to the report's last update;
* the new state was visible, and not equal to the report's current state;
* the update wouldn't change the report from a fixed state to another fixed state;
* (Oxfordshire) the update wouldn't change the report from any open state to Open.
It would also set the report's state to match if the report was currently visible.
This mostly worked, but could lead to issues if e.g. the report started life in
a non-confirmed state (e.g. we pulled it in already fixed from an external
source), as then the update did not record its state and the update display got
confused as to the state history. However it did mean there wasn't confusion if
a later update than the Open311 update was made on the site itself.
This new code will set an update's problem_state if:
* the new state is visible;
* the update wouldn't change the report from a fixed state to another fixed state;
* (Oxfordshire) the update wouldn't change the report from any open state to Open.
It will also set the report's state to match if the report is currently
visible, changing state, and the update timestamp is equal or greater to the
report's last update.
So when the report state changes is unchanged, all the conditions still apply,
but the update's problem_state is set more often (it will be set regardless of
whether the timestamps align, or whether the state matches the report's current
state).
This could theoretically lead to issues elsewhere, e.g. if an update is left on
a report on FixMyStreet and then an Open311 update is pulled in later (but with
an earlier timestamp) that changes the state, the report state will not be
updated due to the later update being made, though the Open311 update will list
the state change, and then the later update might say it changed it back (if it
recorded the current state in its problem_state), even though it technically
did not. I think this issue is less worrying than the current situation, which
can state that a random update has fixed a report when it was the previous
update that did, and there will always be such issues with multiple sources of
truth for a report status. An alternative would be to allow the Open311 update
to override.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
If a body has a `fetch_all_reports` setting in the extra metadata then
all reports are fetched over Open311 and processed regardless of age.
This is useful for bodies where the API endpoint always returns all the
reports as it suppresses the error messages you would otherwise get
about reports with invalid dates.
|
| |/
|
|
|
|
|
| |
I find myself wanting to view the current report in the admin all the time -
this commit adds a link to the top of the inspector column that goes right there.
Only visible for superusers and staff users with permission to actually view the
admin.
|
| |
|
|
|
| |
If a layer has an attribution option then add it to the attribution
control when the layer becomes visible.
|
| |\ |
|
| | |
| |
| |
| |
| | |
Fixes positioning bugs in all versions of IE due
to calculating the wrong horizontal position.
|
| |/
|
|
|
| |
Also stop caching lat/lon specific alert photo lists, and improve
Memcached code.
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Fixes #2018 by making the #sub_map_links bigger.
But the greater win here is that we’re using fewer ID selectors in our
CSS, and both #sub_map_links and #mob_sub_map_links now share the same
styling – both of which are good for maintainability.
|
