| Commit message (Collapse) | Author | Age | Lines |
... | |
| |
| |
| |
| |
| |
| | |
A move between fixed states (presumably from fixed-user to fixed-council)
should not count as a state change for the purposes of generating comment
text from templates.
|
|/
|
|
|
|
|
|
| |
add a do_not_send parameter to reports which allows the front end to specify a
comma separated list of bodies that reports should not be sent to even if
there is a valid contact match. This enables asset layers to override backend
body processing, e.g. if a body only accepts reports that are on a road this
allows the front end to specify that.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2180.
Input placeholders are a generally problematic UI convention, and we’ve
accidentally started using them in more and more parts of FMS over the
last few years.
In some cases, the placeholders simply repeated text from the input’s
existing label element. In cases like those, the placeholder attribute
could just be removed.
In other cases, we broke the placeholder text out into a .form-hint
element, between the input and its label, so that the text is easily
accessible and falls into the top-to-bottom reading flow.
Notable changes:
* Form hint on main postcode search form, instead of placeholder.
* Form hint on alert search form, instead of placeholder.
* Form hints in reporting form (problem summary and description),
instead of placeholders.
* Removed placeholders from most login/password inputs.
* The character limit for "Inspector" report updates is no longer
displayed in the textarea placeholder.
* Form hints now `#666` grey, and better spaced when immediately
following a label element.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Users who double click links were seeing an error when visiting the
questionnaire page. This change gives a grace period of two minutes
for revisiting the questionnaire page.
Fixes #2123.
|
| |
|
|
|
|
| |
Fixes #2185.
|
|
|
|
| |
The code thought it was fetching the category extra, which it is not.
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Add a checkbox to show older reports, plus if we get to the end of the new
reports then instead of a Next button show a "show older" button that will
reload the current page but with older reports also loaded. Wire it all up
into the pushState code as well.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Hitherto when creating a body or ward alert on a UK site,
the MapIt area ID has been stored instead of the body ID.
This is okay for www.fixmystreet.com which for historical
reasons does have body IDs that match MapIt area IDs, but
other UK-based sites may well not. The alert lookup looks
for body ID, meaning those alerts will not work. Save the
body ID instead, plus fix some tests that were making the
same assumption.
|
|
|
|
| |
Fixes mysociety/fixmystreetforcouncils#275
|
|
|
|
|
|
|
|
|
| |
Add a button to the user edit page that sends a login token email to the
user. Helpful for user support situations where someone is having
trouble logging in. Also for situations where you have added a user and
want to get them logged in.
Fixes #2041
|
|
|
|
| |
And there are entries in the defect type dropdown.
|
|
|
|
|
| |
As with priorities, they depend upon the category and so must be
looked up after that has been updated.
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
Categories could contain commas, so splitting on comma is not good enough.
Let’s escape the fields as if it’s a line in CSV. Fixes #2166.
|
|\ \ |
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Open311 specification has two values for a report's status:
- open: it has been reported.
- closed: it has been resolved.
FixMyStreet previously mapped 'closed' to 'fixed - council', but this
has been causing issues with Open311 endpoints that want to mark a FMS
report as closed but not fixed. The mySociety Open311 additions
introduce extended statuses, some of which represent a 'closed' state
e.g. duplicate, no_further_action, but there are times when a report
should simply be closed without any indication why - for example, if
open311-adapter is being used to integrate with a council system which
has a closed state not represented by the extended statuses. Marking a
report as 'closed' on a council system and displaying that as 'fixed'
on the FixMyStreet front end is not an ideal situation.
This commit changes the mapping of the Open311 'closed' status to the
'closed' FMS state when extended_statuses is enabled.
|
|
|
|
|
|
|
| |
This allows the mobile app to explicitly detect when a body is
unresponsive and display the category_extra text.
For mysociety/fixmystreet-mobile#266
|
|\ |
|
| | |
|
|/
|
|
|
|
|
| |
Add a check in the root controller `auto` to a cobrand hook that denies
access if it returns true. This goes here so that cobrands and users are
set up, which is not the case for `check_login_required`. Used to do
things like deny site access unless the user is a superuser.
|
| |
|
|\ |
|
| |
| |
| |
| | |
The User model now also has a created column.
|
|/
|
|
| |
This was caused by the header overlapping the state banner
|
|
|
|
|
|
|
|
| |
Display fields that are automatically filled in the contact editing form
otherwise the data is lost. Also include the automated field in the
form.
Fixes #2136
|
| |
|
| |
|
|
|
|
|
|
| |
Dealing with the map UI changes earlier leads to a better display
position, and we add a global variable check to allow cobrands to
not use this behaviour. Fixes #1863.
|
|
|
|
|
| |
The scroll position wa being remmbered, meaning
the full-page map was not being shown correctly.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This can cause issues with e.g. multi-language sites, and was
only needed for cases where the admin was proxied, which we do
not suggest any more.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On a mobile device that implements pointer events, there are two events that
can happen on an /around page – touching the map starts a new report (or goes
back to the map if already on a report page); touching a pin pulls in that
report’s page. The map touch, which uses an OpenLayers.Handler.Click, operates
on click, whereas the pin touch, which uses an OpenLayers.Handler.Feature,
operates on touchstart. Neither event cancels the other, which means you can
end up either starting a new report, and then it tries to pull in an undefined
pin ID report and errors, or the pin report loads and then you instantly go
back to the map page.
In order to work around this, we disable the map click control when the feature
control event starts, and reactivate once the report data has been loaded.
|
| |
| |
| |
| |
| | |
Return an error if an id for either a hidden update or one not
associated with the problem id is passed to the contact form.
|
|/
|
|
|
|
| |
We get quite a few emails to support that are about a specific problem
but fail to include a link to that problem. This adds some text to the
contact form to ask people to do so.
|
|\ |
|
| |
| |
| |
| |
| | |
Otherwise a non-interactive layer applying to the same category
as an asset layer can cause an ‘undefined’ message to appear.
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
| |
Going back to /around from /report/new can trigger loadend (and the
spinner hiding function) twice (if the strategy activation starts a
read), with triggerRead aborting that read and triggering the event
itself. This means the spinner is not displayed, as the count falls
below 0. We could pin the count above 0, but instead let’s log each
layer ID while ‘active’ and switch off when they’re all gone.
|
| |
|