| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
|
| |
This prevents leaking of user account phone
number on a failed login attempt.
|
|\ |
|
| | |
|
| | |
|
|\ \ |
|
| | | |
|
|\ \ \
| |_|/
|/| | |
|
| |/ |
|
| | |
|
|/
|
|
|
|
| |
Add by_category output to the /report/new/ajax call, containing all the data
that /report/new/category_extras returns for one category. Then alter the JS
to use that data immediately when needed.
|
| |
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Previously, if you didn’t want a hint to appear under the main "details"
textarea on the new report form, you had to override the entire
`form_report.html` template, or leave the hint element in the markup but
hide it with CSS.
Now, you can set `form_detail_placeholder` to a falsey value, and the
template won’t output the hint element at all. It also amends the
`aria-describedby` attribute on the textarea so it doesn’t end up
referencing a hint element that doesn’t exist.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes #2016.
When you load a page that includes either a problem report, or is
centered on a location, the "Report a problem" button in the nav bar
(that normally takes you to the homepage) becomes a "Report a(nother)
problem here" button, that leads directly to the new report form
for the location in question.
On full map pages (/around and any /report/<id> pages loaded via it)
the reporting form will be rendered client-side, avoiding a full page
reload.
On pages lacking the full map (eg: missing fixmystreet.bbox_strategy),
namely /reports/<area> and any /report/<id> page that hasn’t been
client-side loaded via /around, we fall back to a server-side page load.
Finally, as you’d expect, the text and URL for the button dynamically
update as you move around the map, or switch between the different
client-side states of the reporting flow.
We also hide the button entirely when you’re reporting a problem,
which was something suggested a long time ago.
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| | |
Part of #2012.
Should make it much quicker to report multiple problems in the same
location, one after the other.
|
|/
|
|
|
|
|
|
| |
If an inspector clicks on a report from an around page the code to setup
the pin dragging needs to be called. This adds a method to the map to
allow the setup code to be called on report load.
Fixes #2073
|
|\ |
|
| |
| |
| |
| |
| |
| | |
A move between fixed states (presumably from fixed-user to fixed-council)
should not count as a state change for the purposes of generating comment
text from templates.
|
|/
|
|
|
|
|
|
| |
add a do_not_send parameter to reports which allows the front end to specify a
comma separated list of bodies that reports should not be sent to even if
there is a valid contact match. This enables asset layers to override backend
body processing, e.g. if a body only accepts reports that are on a road this
allows the front end to specify that.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2180.
Input placeholders are a generally problematic UI convention, and we’ve
accidentally started using them in more and more parts of FMS over the
last few years.
In some cases, the placeholders simply repeated text from the input’s
existing label element. In cases like those, the placeholder attribute
could just be removed.
In other cases, we broke the placeholder text out into a .form-hint
element, between the input and its label, so that the text is easily
accessible and falls into the top-to-bottom reading flow.
Notable changes:
* Form hint on main postcode search form, instead of placeholder.
* Form hint on alert search form, instead of placeholder.
* Form hints in reporting form (problem summary and description),
instead of placeholders.
* Removed placeholders from most login/password inputs.
* The character limit for "Inspector" report updates is no longer
displayed in the textarea placeholder.
* Form hints now `#666` grey, and better spaced when immediately
following a label element.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Users who double click links were seeing an error when visiting the
questionnaire page. This change gives a grace period of two minutes
for revisiting the questionnaire page.
Fixes #2123.
|
| |
|
|
|
|
| |
Fixes #2185.
|
|
|
|
| |
The code thought it was fetching the category extra, which it is not.
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Add a checkbox to show older reports, plus if we get to the end of the new
reports then instead of a Next button show a "show older" button that will
reload the current page but with older reports also loaded. Wire it all up
into the pushState code as well.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Hitherto when creating a body or ward alert on a UK site,
the MapIt area ID has been stored instead of the body ID.
This is okay for www.fixmystreet.com which for historical
reasons does have body IDs that match MapIt area IDs, but
other UK-based sites may well not. The alert lookup looks
for body ID, meaning those alerts will not work. Save the
body ID instead, plus fix some tests that were making the
same assumption.
|
|
|
|
| |
Fixes mysociety/fixmystreetforcouncils#275
|
|
|
|
|
|
|
|
|
| |
Add a button to the user edit page that sends a login token email to the
user. Helpful for user support situations where someone is having
trouble logging in. Also for situations where you have added a user and
want to get them logged in.
Fixes #2041
|
|
|
|
| |
And there are entries in the defect type dropdown.
|
|
|
|
|
| |
As with priorities, they depend upon the category and so must be
looked up after that has been updated.
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
Categories could contain commas, so splitting on comma is not good enough.
Let’s escape the fields as if it’s a line in CSV. Fixes #2166.
|
|\ \ |
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Open311 specification has two values for a report's status:
- open: it has been reported.
- closed: it has been resolved.
FixMyStreet previously mapped 'closed' to 'fixed - council', but this
has been causing issues with Open311 endpoints that want to mark a FMS
report as closed but not fixed. The mySociety Open311 additions
introduce extended statuses, some of which represent a 'closed' state
e.g. duplicate, no_further_action, but there are times when a report
should simply be closed without any indication why - for example, if
open311-adapter is being used to integrate with a council system which
has a closed state not represented by the extended statuses. Marking a
report as 'closed' on a council system and displaying that as 'fixed'
on the FixMyStreet front end is not an ideal situation.
This commit changes the mapping of the Open311 'closed' status to the
'closed' FMS state when extended_statuses is enabled.
|
|
|
|
|
|
|
| |
This allows the mobile app to explicitly detect when a body is
unresponsive and display the category_extra text.
For mysociety/fixmystreet-mobile#266
|
|\ |
|
| | |
|