| Commit message (Collapse) | Author | Age | Lines |
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Historically, the FixMyStreet admin was accessed via HTTP Basic Auth and
a secure proxy, so the auth user was used for logging purposes. Nowadays
all admin use is by FixMyStreet user, and any Basic Auth is used for the
purpose of hiding staging sites from bots. This configuration means that
on those staging sites, all admin is logged by the one staging user, not
the actual user, so let's swap that round.
|
|/
|
|
| |
For #2668.
|
|
|
|
| |
Includes an updated version of jquery-multi-select.
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the existing logic to account for the fact that multiple
questions might have the disable form checkbox ticked for one of their
options.
At the moment this just displays one of the messages at a time, with the
first one taking priority. So if you have a "Is this an emergency"
question and a "Is this on private land" question which both disable the
form, and the user has selected "Yes" to both, then only the message for
the first question is displayed. This can potentially be improved in the
future, but seemed out of scope for this change.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes a bit of refactoring of PhotoSet::get_image_data to make
it easier to call subsequent methods on the photo object. We then
do this to get the width and height.
Also adds width/height attributes to FixMyStreet::ImageMagick
Attributes are updated every time the image is transformed and before
the as_blob data, which also undefs the image, is returned so it always
present for subsequent calls.
Fixes #2394.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
If we wait until after to filter the contacts and the constructed
options, then we can end up in the situation where e.g. we've filtered
out all the TfL contacts but the category option is still the TfL one
(with its associated group).
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some contacts (e.g. TfL) don’t have a valid email address but aren’t Open311
categories - the email destination is managed via the borough_email_addresses
feature. This prevents any changes to the contact being made via the admin
due to the email validation error message.
This commit updates the logic to only check that the email address is valid
if it’s been changed from the existing value (which may be blank if a it’s a
new contact).
Fixes https://github.com/mysociety/fixmystreet-freshdesk/issues/108
|
|\ |
|
| | |
|
|/ |
|
|
|
|
|
| |
These categories display a ‘please ring’ message and so
have nowhere to be resent if selected.
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| | |
Remove some unused code.
|
|\ \ |
|
| |/ |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
The only exception is when the category change is between two categories
in the same Symology database, in which case we do not want to resend.
|
| |/ |
|
|/
|
|
|
|
|
|
|
| |
For categories that use the extra metadata fields to just show a notice
message to the user, the ‘help the council fix the problem by providing
extra information’ text was a bit out of place. This commit hides it
unless there are actual UI elements also included in the markup.
Fixes #2811.
|
|
|
|
| |
This was most likely the cause of #2815.
|
| |
|
|
|
|
|
|
| |
If a staff user uses the anonymous button, it does not otherwise record
which staff user did that; using Report As would store their user as the
report's user.
|
|
|
|
| |
This also lets it be cobrand specific.
|
| |
|
|
|
|
|
|
|
|
|
| |
On fixmystreet.com, you cannot view reports made on the TfL cobrand,
apart from on reporting seeing pins labelled with the report's category,
linking through to the TfL cobrand.
Output the pin's base URL if different from normal, so e.g. app can link
appropriately.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
If the disable form message is being shown, the normal list is hidden,
so there's no point in outputting the same message there.
(This also helps with a TfL issue where we want to show a disable form
on a red route, but not elsewhere, and this means it won't show the
disable form message as a normal extra question.)
|
|
|
|
|
| |
Performs a proper redirect instead of detaching to /my/inspector_redirect
so any request params from sign-in (e.g. password!) aren't carried through.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
We add a way to process a template with no auto-escaping, that can be
used for the text parts of emails, and mark various HTML output as safe.
|
|
|
|
|
|
|
| |
This means any variable used in a template is automatically
HTML-escaped, unless it is marked as safe either in code by
using a SafeString, or in the template with the `mark_safe`
function or the `safe` filter.
|
|
|
|
|
|
|
|
| |
This resolved the problem of checking user body permissions on both
around and report/new by adding a variable to stash specifically for
this purpose. Previously staff users could not see the mark private tick
if the report form was loaded via javascript from the around page as
there was no bodies variable in the stash.
|
| |
|
| |
|
|
|
|
|
| |
If the photo field is updated first, then the cache removal
doesn't think there are any photos to remove.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
If a user belongs to a body override the disabled form check upon
submission as mostly staff users can submit in those categories.
Fixes mysociety/fixmystreet-freshdesk#98
|