| Commit message (Collapse) | Author | Age | Lines |
| |
|
| |
|
|
|
|
| |
The interception of 404s etc is too much of an inconvenience.
|
|
|
|
|
|
|
| |
The list code was checking the photo ID given in the database existed on
disk – this shouldn't ever not be the case, and if it was, all that
would happen would be a broken image when the full photo code looks for
it (this is only for e.g. lists of reports).
|
|
|
|
|
| |
The versioning code wasn't remembering when it had found that a file did
not exist, so was checking for them each time.
|
|
|
|
|
|
|
|
|
|
|
| |
Reports in the generated Exor RDI file need to have an external_id so they can
be linked to existing enquiries (PEMs) when the RDI is imported into Exor.
There is a small window of opportunity for a report to be created, inspected and
downloaded in an RDI before it's been sent to Exor via Open311 and had an
external_id assigned. This commit closes that window by excluding reports from
the RDI that don't have an external_id.
Fixes mysociety/fixmystreetforcouncils#168
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The RDI file format encapsulates information about inspections that have taken
place, and can be uploaded into Exor to create defects in bulk.
This commit adds a page to the Oxfordshire cobrand's admin allowing RDI files
to be generated and downloaded from FMS.
For mysociety/fixmystreetforcouncils#127
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than assigning +1 to a user's reputation every time a report is
inspected, this allows cobrands to specify which states should increment or
decrement the reputation value when a report is inspected.
The default behaviour is for reputation to never be changed, but the Oxfordshire
cobrand will increment the reputation when a report is marked as 'action
scheduled'.
For mysociety/fixmystreetforcouncils#119
|
|
|
|
|
|
| |
A report is now considered 'inspected' if its state was changed by an inspector.
Additionally, an AdminLog entry is created so the time of inspection and
inspector can be recorded.
|
| |
|
| |
|
|
|
|
|
| |
Tokens can include a 'p' field in their data to set query params for the
post-login redirect URL.
|
|
|
|
| |
If the user has a from_body and at least one category set.
|
| |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
Assume that if they inspect and save a report, they want
to go back to their shortlist.
|
|/ |
|
|
|
|
|
| |
Solves a minor bug where it was difficult to create a new user and immediately
assign permissions, as the page didn't show the appropriate permissions UI.
|
|
|
|
|
| |
This is to work around
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8572187/
|
|\ |
|
| |
| |
| |
| |
| |
| | |
If an out-of-date token was passed to check_csrf_token, then no new
token would be output on the error page because csrf_time was still
present.
|
| |
| |
| |
| |
| |
| |
| | |
This includes adding/removing reports from a user's shortlist, and
manual reordering of a shortlist with up/down buttons.
The backend code can cope with an item moving to any point in the list.
|
| | |
|
|/ |
|
|
|
|
| |
This includes a refactor of the state dropdown field into its own template for easy reuse.
|
|
|
|
|
| |
fddf7f95 broke the use of minimized JS files, because it always used an
unchanged $url in the output. Make sure it is updated if $file is.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows the inspect form to be submitted when offline, with the data
saved in localStorage, the number of saved forms shown in the banner,
and the forms to be uploaded when back online.
It copes if you go back to a report after having submitted the form, and
if the back-online submission fails due to CSRF failure, retrying once
with a new token.
|
| |
| |
| |
| |
| | |
Use a list to store JavaScript files, so it can be shared
between the HTML footer and the appcache manifest.
|
| | |
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| | |
Different categories may have a different list of priorities, so store
them all and update as the category changes.
|
| |
| |
| |
| |
| |
| | |
- Record state change when leaving update and marking as duplicate
- Change save button wording to match problem state when inspecting
- Make it clearer that updates marking a report as duplicate actually close the report
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Use Problem->pin_data for single report page
- Promote markers_highlight to fixmystreet.maps API
We want to highlight map pins on the duplicate report selection UI, so let's use
what's already there instead of writing something new.
- Make sure duplicate report pins aren’t draggable
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Zurich::admin_type function was setting $c->stash->{body}, meaning that
when trying to edit a superuser the 'fetch_contacts' function wasn't being
called, causing an "Can't call method "all" on an undefined value" error as
$c->stash->{live_contacts} wasn't ever being set.
Fixed by changing the conditional to simply determine whether fetch_contacts
needs to be called.
Included a regression test that meant a small addition to the MapItZurich mock.
|
|
|
|
|
|
| |
The default cobrand does not have a template directory, so the
directory change to it was not working. Use the root directory
of the repository instead.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Includes newest, oldest, least/most recently updated, and most comments.
The default remains the same, which is last updated on /reports, and
newest on /my and /around (the latter plus not-in-view
sorted-by-distance ones).
|
|\ |
|
| | |
|
| | |
|
|/
|
|
|
| |
- A user can be assigned to any number of its body's categories
- The category ids are stored as a list in the user's extra field
|