aboutsummaryrefslogtreecommitdiffstats
path: root/perllib/FixMyStreet
Commit message (Collapse)AuthorAgeLines
* [fixmystreet.com] Improve two-tier unresponsive.Matthew Somerville2019-02-11-20/+20
| | | | | | | Similarly to 1f69e28c, we were previously only checking the first matching entry, which led to confusing behaviour in places. Include consequential amendments for e.g. one body being unresponsive, the other not.
* [Oxfordshire] Limit appears to be lower than 70.Matthew Somerville2019-02-08-2/+2
|
* Merge branch '2242-automatic-permalink'Matthew Somerville2019-02-05-49/+3
|\
| * Improve use of OL ArgParser/missing zoom in URL.Matthew Somerville2019-02-04-49/+1
| | | | | | | | | | | | Remove the server-side zoom-in-url fix, instead use an ArgParser subclass to default to the provided data if nothing in URL. Then we can switch to using short lat/lon in geocoder URLs.
| * Update URL whenever map moves, using replaceState.Dave Arter2019-02-04-0/+2
| | | | | | | | | | | | Fixes #2242. Co-authored-by: Matthew Somerville <matthew@mysociety.org>
* | Merge branch 'fix-code-starting-underscore-display'Matthew Somerville2019-02-05-3/+3
|\ \
| * | Allow Open311 codes starting with ‘_’ to function.Matthew Somerville2019-02-04-3/+3
| | | | | | | | | | | | | | | | | | Template Toolkit treats keys starting with ‘_’ as private and does not expose them. It is possible for an Open311 server to return fields starting with an underscore, and we want to use those in the template.
* | | Make front page cache time configurable.Matthew Somerville2019-02-04-5/+10
| |/ |/| | | | | | | Add a configuration variable to use for the front page stats/ recent list, plus the max-age of `/reports`.
* | No need to pass c to cobrand function.Matthew Somerville2019-02-01-1/+2
|/
* Merge branch 'bucks-topic-question-all'Matthew Somerville2019-02-01-20/+20
|\
| * [UK Councils] Get topic when reporting abuse.Matthew Somerville2019-01-31-20/+20
| |
* | Add CSRF and time to contact form.Matthew Somerville2019-02-01-12/+25
|/
* Allow searching for <email> in admin.Matthew Somerville2019-01-29-0/+9
|
* Spot moderation conflicts.Matthew Somerville2019-01-25-2/+28
| | | | | If someone tries to moderate after someone else has, re-show the form and an error.
* Stop redirecting on moderation error.Matthew Somerville2019-01-25-30/+38
| | | | This will also be used by the moderation conflict code.
* [Buckinghamshire] Stop road-placement being sent.Matthew Somerville2019-01-25-0/+11
| | | | | The server doesn't need to know about it, it was only for us to pick the appropriate body.
* [Buckinghamshire] Script to close old district flytipping reports.Matthew Somerville2019-01-23-18/+26
|
* [Buckinghamshire] Question for on-road flytipping.Matthew Somerville2019-01-23-0/+52
| | | | | | | | This adds a question to check whether a flytipping report concerns flytipping on a road or not. Client-side, it is asked when a road is selected and destination adjusted according to the answer; server side it uses the answer to direct any both-tier submissions (from e.g. non-JavaScript or phone app).
* [Open311] Refactor cobrand specific code.Matthew Somerville2019-01-23-0/+47
|
* Factor out two identical loops.Matthew Somerville2019-01-21-19/+5
|
* Don’t show creation diffs with old history entries.Matthew Somerville2019-01-17-0/+2
| | | | | Old moderation history entries will have blank category/co-ords, and we don’t want to say they’ve changed on appearance.
* Merge branch 'allow-state-moderation'Matthew Somerville2019-01-16-1/+36
|\
| * Allow state editing via moderation.Matthew Somerville2019-01-16-1/+36
| | | | | | | | | | If a state is passed in (on a cobrand), update problem state and add a comment to record this (as state changes are updates not moderations).
* | Merge branch 'moderation-in-front-end-updates'Matthew Somerville2019-01-16-1/+26
|\ \
| * | Include moderation history in report updates.Matthew Somerville2019-01-16-0/+25
| | | | | | | | | | | | | | | | | | If the user has moderating permission, or a cobrand allows the viewing of moderation history, show moderation history within the updates on a report page.
| * | Only show extra items that diff in moderation.Matthew Somerville2019-01-15-1/+1
| |/
* / [Oxfordshire] length checking for names, emails and phone NosStruan Donald2019-01-16-0/+12
|/ | | | | | | Add in validation to check names, email and phone numbers don't exceed maximum lengths permitted by HIAMS. Fixes mysociety/fixmystreet-commercial#1244
* Call confirm() during token confirmation.Matthew Somerville2019-01-14-2/+1
| | | | So state/confirmed setting in one place.
* Use pin_new_report_colour server-side too.Matthew Somerville2019-01-14-1/+1
|
* Remove any use of `my $x if $foo`.Matthew Somerville2019-01-14-4/+7
| | | | | | | | As perlsyn says, "NOTE: The behaviour of a `my`, `state`, or `our` modified with a statement modifier conditional or loop construct (for example, `my $x if ...`) is undefined. The value of the `my` variable may be `undef`, any previously assigned value, or possibly anything else."
* Delete cache photos upon photo moderation.Matthew Somerville2019-01-10-0/+1
|
* Check cached reports have photos before showing.Matthew Somerville2019-01-10-1/+1
|
* Allow override search to /report/new => /around.Matthew Somerville2019-01-10-1/+7
| | | | | | This is so you can have a search box on an around page (wrapped in a form going to /report/new) to start a new search, ignoring the lat/lon that will also be submitted.
* add private only report filterStruan Donald2019-01-04-11/+32
|
* [Buckinghamshire] add report description filteringStruan Donald2019-01-04-0/+17
| | | | | | Add a method to do some basic filtering of emails and phone numbers from report descriptions. To be used on reports pulled in from Confirm as a first pass at removing personal information.
* Show all questionnaire responses lacking updates.Matthew Somerville2018-12-20-6/+33
| | | | | | Since questionnaire responses were recorded on email link click, we should have been showing those that reopened or fixed reports, not just steady-state "Still open" ones.
* [Buckinghamshire] Get topic when reporting abuse.Matthew Somerville2018-12-19-0/+19
|
* [fixmystreet.com] Get topic when reporting abuse.Matthew Somerville2018-12-19-3/+0
|
* cobrand hook for extra processing upon report inspectionStruan Donald2018-12-17-0/+2
| | | | | Add a hook to enable the cobrand to do some extra processing when saving a report on the inspect report screen.
* add a cobrand hook to save extra user dataStruan Donald2018-12-17-0/+4
| | | | | Enable the cobrand to save extra data when creating/editing users in the admin.
* Modernise report "status" bannerZarino Zappia2018-12-13-3/+3
| | | | | | | | | | | | | * Simplify markup required for the status banner. * Simplify styles - the banner is now identical on all screen sizes. * Move the banner from `report/display.html` into `report/_main.html` so that it can appear after `.problem-back` in the source order. * Use real pin icon instead of `pin-flat-white-small.png`. * Set a default `$col_fixed_label` colour in `_base.scss`, so cobrands don’t have to define it themselves if they’re happy with green. * Introduce `$col_fixed_label_light`, with a sensible default for all cobrands, even ones that have a custom `$col_fixed_label`. * Remove `$col_fixed_label_dark` – no longer needed.
* [Zurich] Add 2019/2020 extra holidays.Matthew Somerville2018-12-11-0/+2
|
* Make sure locale path specified in JS controller.Matthew Somerville2018-12-08-1/+3
| | | | | This doesn't appear to cause any issues on Linux, but on Mac it fails to find the translation file without this. Matches the code in App.pm.
* [fixmystreet.com] More categories in fixture.Matthew Somerville2018-12-08-2/+18
|
* Merge branch '642-new-report-flow-changes'Matthew Somerville2018-12-05-27/+10
|\
| * Move email input nearer password input on forms.Zarino Zappia2018-12-05-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves the email input from `user_loggedout.html` closer to the password inputs in `user_loggedout_{by_email,password}.html`, because we want to emphasise the connection between your login email/username and your password, and, now that only one "Yes I have an account / No I do not have an account" fieldset is displayed at a time, there was no reason to ask for the email/username up front. This, however, now means the form includes two username inputs, so: * `Report/New.pm` and `Report/Update.pm` now pick the first non-empty username param and use that. * `user_loggedout_email.html` now expects a `name` parameter, so that we can give the two username inputs unique ids in the markup. Also: * The "optional" phone and email inputs in user_loggedout_by_email.html are printed *after* the main username input if SMS login is enabled (since one or other of them is unhidden by javascript, based on whether you entered a phone number or and email address into the "username" input, and it would look weird to have an input become unhidden *above* the input you’re currently editing).
| * Remove “Keep me signed in” box.Matthew Somerville2018-12-04-25/+0
| |
* | Fix moderation without JavaScript.Matthew Somerville2018-12-04-0/+23
|/
* Associate moderation history with admin log.Matthew Somerville2018-11-27-63/+80
|
* Show moderation history in report/update admin.Matthew Somerville2018-11-26-2/+132
|