| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
| |
but only send if the problem as a customer reference and use that as the
external id reference
|
|
|
|
|
| |
we no longer need some of the hardcoded oxfordshire Open311 overrides so
remove them
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Open311 specification has two values for a report's status:
- open: it has been reported.
- closed: it has been resolved.
FixMyStreet previously mapped 'closed' to 'fixed - council', but this
has been causing issues with Open311 endpoints that want to mark a FMS
report as closed but not fixed. The mySociety Open311 additions
introduce extended statuses, some of which represent a 'closed' state
e.g. duplicate, no_further_action, but there are times when a report
should simply be closed without any indication why - for example, if
open311-adapter is being used to integrate with a council system which
has a closed state not represented by the extended statuses. Marking a
report as 'closed' on a council system and displaying that as 'fixed'
on the FixMyStreet front end is not an ideal situation.
This commit changes the mapping of the Open311 'closed' status to the
'closed' FMS state when extended_statuses is enabled.
|
| |
|
|
|
|
|
|
|
| |
If there was an undefined parameter passed to `_post` then generating
the debug string would generate a warning about an undefined value in a
concatenation. So, check for undefined params and substitute empty
string to avoid.
|
|
|
|
|
|
| |
If a name only had a single word we were failing to split it and not
setting `first_name`. Also refactor splitting out to a function so the
regex is only in one place.
|
| |
|
|
|
|
|
|
|
|
| |
Per cobrand configurable option to send multiple photos over open311
instead of just a single one. Does this by sending multiple media_url
parameters in the POST body.
The default remains to send the first photo associated with a report.
|
|
|
|
|
|
|
|
|
|
| |
This enables the display of existing reports from the back end on FMS
if the body is configured to do this.
Reports will not be created if they are missing an id, a lat or a long,
if the lat/long is outside the area covered by the body, if there is
already a report with a matching id, or if we can't parse out the
request time.
|
|
|
|
|
| |
The addition of e.g. questionnaire_id to an update's
extra field means this check has to be more nuanced.
|
| |
|
|
|
|
|
|
| |
This includes stopping some emails being sent (moderation, alert,
questionnaire), dealing with Open311/email report sending, and
tokenised_url.
|
| |
|
|
|
|
|
| |
Add hook for post-title field content in report form.
Update translations.
|
| |
|
|
|
|
|
| |
There are a couple of servers we currently talk to that
error not that infrequently but work in the end.
|
| |
|
| |
|
|
|
|
|
| |
Parse the XML in such a way other parts of the code do not have to worry
about single-value folding or the like.
|
|
|
|
|
|
|
| |
Store image type along with hash in photo column, and use that when
outputting images / generating URLs. Make sure all public photo URL
generation goes through appropriate functions, and change temp URLs
so the filename can be output directly from the list.
|
|
|
|
| |
And create default cobrand class without all of Moose.
|
|
|
|
| |
Command line scripts don't need a full blown app, just database.
|
|
|
|
|
|
|
|
|
| |
Historically, the extra field has been used in two different ways by
different cobrands, both as a list (e.g. Open311 category fields) and a
hash (e.g. the Zurich cobrand).
This commit consolidates usage, adding an API to make use of the field
easier and always returning a hash for the code to use. Fixes #1018.
|
|
|
|
| |
Also remove some unused variables.
|
|
|
|
|
|
| |
So don't request '...services.xml?jurisdiction_id=' as that can lead to
an error from an Open311 server that expects either no parameter at all
or a stated jurisdiction_id.
|
|
|
|
|
|
|
| |
This parameter was added in 3eb93cea4acd5f9b76efdc0910466363a0b9b445
and is superfluous (as jurisdiction*_id* is the correct parameter,
and is already sent.) That commit mentions only api_key so understand
this wrong parameter is an artefact.
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
bin/update-schema
locale/sv_SE.UTF-8/LC_MESSAGES/FixMyStreet.po
perllib/FixMyStreet/DB/Result/Body.pm
|
| |
| |
| |
| | |
This could be made cobrand-customisable in future.
|
|/ |
|
|
|
|
|
| |
Open311 was using the name in the user table for it's reports when it
should be the one in the problem table.
|
|
|
|
| |
database.
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
bin/send-comments
conf/crontab.ugly
db/schema.sql
perllib/FixMyStreet/App/Controller/Admin.pm
perllib/FixMyStreet/DB/Result/Open311conf.pm
perllib/FixMyStreet/DB/ResultSet/Problem.pm
perllib/Open311.pm
t/app/controller/report_updates.t
t/open311.t
templates/web/default/report/display.html
templates/web/default/report/updates.html
templates/web/fixmystreet/report/display.html
|
| |
| |
| |
| |
| |
| | |
than the state of the problem in case a second update has changed the
problem state since. On the of chance that there is no problem_state
for the comment then fall back to the state of the problem
|
| |
| |
| |
| |
| | |
as logged in council users don't have the same restrictions
also, fix open311 status name of unable to fix
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
updates fails
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.gitignore
bin/make_css
conf/crontab.ugly
perllib/FixMyStreet/Cobrand/Default.pm
perllib/Open311.pm
templates/web/fixmystreet/around/postcode_form.html
|
| | |
| | |
| | |
| | | |
correctly for display
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
posting the service request as having failed
|