| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Bristol's Open311 endpoint still seems to be returning empty metadata
for some services that claim to have metadata. They have made changes to
their published services since the change was made to exclude their
endpoint, which is causing issues for new reports.
Rather than exclude their endpoint entirely from being updated, this
commit just silences the noisy error message for Bristol.
Reverts the change made in 491eb26e4.
|
| |
|
|
|
|
|
|
|
| |
If an Open311 service request update with an empty description field is
received and there is a matching ResponseTemplate for the problem's
category & state (and it's marked as auto-response) then the text from
that ResponseTemplate will be used for the created update.
|
| |
|
| |
|
|
|
|
| |
Store a schema object on FixMyStreet::DB instead.
|
| |
|
|
|
|
|
| |
A new 'state' column replaces confirmed and deleted, allowing
categories to be unconfirmed, confirmed, deleted or inactive.
|
| |
|
| |
|
| |
|
|
|
|
| |
For mysociety/FixMyStreet-Commercial#766.
|
|
|
|
|
| |
We have seen e.g. an endpoint that is returning 'serviceAttributes' as
the child of 'attributes', rather than 'attribute'.
|
|
|
|
| |
The service code could be "0".
|
| |
|
|
|
|
|
| |
Parse the XML in such a way other parts of the code do not have to worry
about single-value folding or the like.
|
|
|
|
|
| |
Even when we ask for a specific range of dates, we sometimes get given
more in the response.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following modules had bugs that have been fixed for working in
recent perls:
* List::MoreUtils
* Guard
* PadWalker
* aliased
* URI
* Convert::NLS_DATE_FORMAT
The CGI module was removed from core in 5.20, so include it in the
snapshot (I don't think it's actually used, but is a dependency).
"{" needs to be escaped in regular expressions, and ~~ should not be
used.
Fix some tests that expect e.g. a certain hash ordering, to use sorted
output or better comparisons.
|
|
|
|
| |
Fixes #1337.
|
|
|
|
| |
Fixes #1315.
|
|
|
|
|
|
| |
Travis has Cpanel::JSON::XS preinstalled, which means that the build
would fail there, as JSON::MaybeXS would try and upgrade JSON::XS to
version 3 which the snapshot did not contain.
|
| |
|
|
|
|
| |
And create default cobrand class without all of Moose.
|
|
|
|
| |
Command line scripts don't need a full blown app, just database.
|
|
|
|
|
|
|
| |
Make dashboard work properly in two-tier councils, showing reports sent
to both. Create an index on the array of the bodies_str column to speed
up performance, and use that throughout the code replacing all LIKE
scans. This also enables a simplifying tidy of the restriction code.
|
|
|
|
|
| |
This override is not used anywhere, it dates from a very old long-gone
test script, and causes issues with database query planning.
|
|
|
|
|
|
|
|
|
| |
Historically, the extra field has been used in two different ways by
different cobrands, both as a list (e.g. Open311 category fields) and a
hash (e.g. the Zurich cobrand).
This commit consolidates usage, adding an API to make use of the field
easier and always returning a hash for the code to use. Fixes #1018.
|
|
|
|
|
|
|
|
| |
If an Open311 server responded with e.g. '<services></services>', you
got a strange hash error as the code treated it as one undef service.
Spot this at the same point we check anything was returned.
Also remove a couple of warnings due to lc of a maybe-undef variable.
|
|
|
|
|
|
| |
as WCC is (during beta) mixed email (manually updated) and Open311,
override the behaviour to delete contacts not returned by service list,
to ignore ones that look like email addresses.
|
|
|
|
|
|
|
| |
- Tweaks required to get things working in WCC environment
- update Open311 to onsite changes
- updated Open311 parameters after WCC's Bentley and County Highways workshop.
- ... including ce_cpr_id
|
|
|
|
|
| |
Uses LWP::Protocol::PSGI to avoid having to spawn external processes
in order to test these end to end.
|
|
|
|
|
| |
If https://github.com/mysociety/fixmystreet/pull/792 is accepted
then this should be rewritten in terms of that.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
::Integration::Warwick subclasses ::Integration::Exor
refactor request_class and new_request
Exor service
Warwickshire updates retrieval, with datetimes
stubbing out of Oracle constants, for local testing
We also edit FMS's core PopulateServiceList routine to hide system
fields from FMS:
Bromley/Warwickshire send metadata in their services/FOO.xml
advising that you can pass, e.g. attributes[easting].
FMS by default shows all of these to the user to fill in, however
we don't *want* the user to supply these, rather they are added
by the cobrand.
Bromley had an exception for this (keyed by $body->areas->id).
We write this more generally for Warwickshire too, keying instead
by $body->name (as this is far less likely to be overridden for
installs using global or custom Mapit's)
|
|
|
|
|
|
|
|
| |
See also MooX::ConfigFromFile, but that's underdocumented and
seems overengineered -- may be worth implementing if requirements
become more complex however. (See also Config::Any, which is
well worth doing in future, using YAML only reflects current
usage in FMS though.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Get Service Request Updates
This requires a new object ::Service::Request::Update, which of course
is not part of standard spec. So, in order to make the core not too
contaminated by :
* the endpoint should instantiate ::Service::Request::mySociety objects
which know about updates
* have added a learn_additional_types callback from Schema to Endpoint,
so that core doesn't need to know about /open311/service_request_update
* (but ::Spark knows about the exception for updates... meh, but is 1-line)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsystems include
* ::Spark encoding conventions for xml/json
* ::Schema using Rx to validate form of inputs and outputs,
including validation for, e.g., dates and CSV as part of Open311
Handles following paths:
* Open311 attributes for Service Definition
http://wiki.open311.org/GeoReport_v2#GET_Service_Definition
* POST service request
* GET Service Requests
* GET Service Request
Objects:
* ::Service
* ::Service::Request
|
|
|
|
| |
Add some comments to the top of the open311 bin scripts.
|
|
|
|
|
|
| |
This tests that the default string used by the old-style Open311 update
code if there is no incoming string and the report is marked fixed, is
translated.
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
bin/update-schema
locale/sv_SE.UTF-8/LC_MESSAGES/FixMyStreet.po
perllib/FixMyStreet/DB/Result/Body.pm
|
| |
| |
| |
| | |
So that e.g. 'Closed by council' is translated.
|
| |
| |
| |
| |
| |
| | |
This commit reverses the "Remove unused Open311 GetUpdates code." commit.
FixaMinGata, the Swedish FixMyStreet cobrand, is still using
open311-update-reports.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes #677. The query to fetch the related alert sometimes:
* retrieves no result, causing an error on $alert->id
* retrieves multiple results, causing deprecation warnings
(e.g. which may at some point become future errors in DBIC)
This commit turns the resultset('DB::Alert')->find(...) into a
search(...) and loops over the results, to suppress them.
|
|/ |
|
|
|
|
| |
instead
|
| |
|
|
|
|
| |
database.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
bin/open311-populate-service-list
bin/send-comments
bin/update-all-reports
conf/crontab.ugly
db/schema.sql
perllib/FixMyStreet/App/Controller/Admin.pm
perllib/FixMyStreet/App/Controller/Report/New.pm
perllib/FixMyStreet/App/Controller/Reports.pm
perllib/FixMyStreet/Cobrand/Default.pm
perllib/FixMyStreet/Cobrand/LichfieldDC.pm
perllib/FixMyStreet/DB/Result/Open311conf.pm
perllib/FixMyStreet/DB/Result/Problem.pm
perllib/FixMyStreet/DB/ResultSet/Problem.pm
perllib/FixMyStreet/SendReport.pm
perllib/FixMyStreet/SendReport/Email.pm
perllib/FixMyStreet/SendReport/Open311.pm
perllib/Open311/GetServiceRequestUpdates.pm
perllib/Open311/PopulateServiceList.pm
t/app/controller/report_new.t
t/app/controller/rss.t
templates/web/bromley/report/display.html
templates/web/default/admin/council_contacts.html
templates/web/default/common_header_tags.html
templates/web/default/dashboard/index.html
templates/web/default/front/stats.html
templates/web/default/report/_main.html
templates/web/default/report/update-form.html
templates/web/emptyhomes/index.html
templates/web/emptyhomes/report/display.html
templates/web/emptyhomes/report/new/councils_text_all.html
templates/web/emptyhomes/reports/body.html
templates/web/emptyhomes/reports/index.html
templates/web/fixmystreet/report/new/fill_in_details_form.html
templates/web/fixmystreet/report/update-form.html
web/cobrands/fixmystreet/fixmystreet.js
web/js/fixmystreet.js
|
| |
| |
| |
| | |
than one body.
|