| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
| |
For #344 and #935.
|
|
|
|
|
|
| |
Fixes #357.
Also consolidate almost-identical fill_in_details.html template
(for #344).
|
|
|
|
|
| |
Only show "select..." if more than one body, and only mention greyed out
lines if there are any. Fixes #869.
|
|
|
|
|
| |
Also, s///r isn't present in 5.10, and FixMyStreet should still install
on squeeze.
|
|
|
|
|
|
| |
Try and save other people the potential pain of installing SOAP::Lite;
only UK FixMyStreet and Zurich geocoder use it, so set it as an optional
feature in the cpanfile instead.
|
|
|
|
| |
In case it contains an ampersand or somesuch.
|
|
|
|
| |
If you know to change the URL, anyway, for now.
|
|
|
|
|
|
|
|
| |
This changes the default flow to show no pins and a message about
reporting, with the second tab displaying existing problems (and showing
map pins). Those existing problems are the ones that would currently be
on "problems on the map" followed by those currently on "problems
nearby".
|
|
|
|
| |
This gave no conclusive results, which was interesting.
|
|
|
|
|
|
| |
as WCC is (during beta) mixed email (manually updated) and Open311,
override the behaviour to delete contacts not returned by service list,
to ignore ones that look like email addresses.
|
|
|
|
|
|
|
| |
- Tweaks required to get things working in WCC environment
- update Open311 to onsite changes
- updated Open311 parameters after WCC's Bentley and County Highways workshop.
- ... including ce_cpr_id
|
|
|
|
|
| |
Uses LWP::Protocol::PSGI to avoid having to spawn external processes
in order to test these end to end.
|
|
|
|
|
| |
If https://github.com/mysociety/fixmystreet/pull/792 is accepted
then this should be rewritten in terms of that.
|
|
|
|
|
|
|
| |
This parameter was added in 3eb93cea4acd5f9b76efdc0910466363a0b9b445
and is superfluous (as jurisdiction*_id* is the correct parameter,
and is already sent.) That commit mentions only api_key so understand
this wrong parameter is an artefact.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
::Integration::Warwick subclasses ::Integration::Exor
refactor request_class and new_request
Exor service
Warwickshire updates retrieval, with datetimes
stubbing out of Oracle constants, for local testing
We also edit FMS's core PopulateServiceList routine to hide system
fields from FMS:
Bromley/Warwickshire send metadata in their services/FOO.xml
advising that you can pass, e.g. attributes[easting].
FMS by default shows all of these to the user to fill in, however
we don't *want* the user to supply these, rather they are added
by the cobrand.
Bromley had an exception for this (keyed by $body->areas->id).
We write this more generally for Warwickshire too, keying instead
by $body->name (as this is far less likely to be overridden for
installs using global or custom Mapit's)
|
|
|
|
|
|
|
|
| |
See also MooX::ConfigFromFile, but that's underdocumented and
seems overengineered -- may be worth implementing if requirements
become more complex however. (See also Config::Any, which is
well worth doing in future, using YAML only reflects current
usage in FMS though.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Get Service Request Updates
This requires a new object ::Service::Request::Update, which of course
is not part of standard spec. So, in order to make the core not too
contaminated by :
* the endpoint should instantiate ::Service::Request::mySociety objects
which know about updates
* have added a learn_additional_types callback from Schema to Endpoint,
so that core doesn't need to know about /open311/service_request_update
* (but ::Spark knows about the exception for updates... meh, but is 1-line)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsystems include
* ::Spark encoding conventions for xml/json
* ::Schema using Rx to validate form of inputs and outputs,
including validation for, e.g., dates and CSV as part of Open311
Handles following paths:
* Open311 attributes for Service Definition
http://wiki.open311.org/GeoReport_v2#GET_Service_Definition
* POST service request
* GET Service Requests
* GET Service Request
Objects:
* ::Service
* ::Service::Request
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First Warwickshire styling
- imported WCC's header and footer files
- Use Warwickshire colours for page elements
- Include FMS elements in header
- Use correct Warwickshire colours on map
- Use full-screen map on desktop.
- Improve display of homepage elements
- Ensure correct classes are added to body tag
- Make sure site header has correct height on front page
- Tidy-up of unused header content and wrappers
- Improve display of map
- Position map beneath other elements
Improve map display
- Take some CSS from Warwickshire styles to ensure its applied
- Fix container widths on map page
- Make sure map wrapper is the correct width
- Add style overrides to match Warwickshire.gov.uk
- Ensure map controls are visible
Nav and mobile styling
- Make sure sticky sidebar nav is usable
- Improve mobile front page
- Ensure map is full-screen on mobile
- Improve front page display on mobile
- Fix map display on desktop
- Fix Warwickshire and FMS nav on mobile
- Add viewport meta tag for mobile devices
- Tighten up vertical spacing on front page
- Fix header height on tablet size screens
- Set pan/zoom position in CSS, not JS
Styling tweaks
- correct styling of nav for wider screens (previous hidden by media query)
- Add draft Warwickshire FAQ
- Fixes https://github.com/mysociety/FixMyStreet-Commercial/issues/611
- Warwickshire. remove all reports link as requested.
- see https://github.com/mysociety/FixMyStreet-Commercial/issues/609
- Update WCC footer
- see https://github.com/mysociety/FixMyStreet-Commercial/issues/597
Bring WCC css locally, and override
- Override for
https://github.com/mysociety/FixMyStreet-Commercial/issues/612
- favicon
https://github.com/mysociety/FixMyStreet-Commercial/issues/616
- update contact details
- custom FAQ
- fix padding on mobile
https://github.com/mysociety/FixMyStreet-Commercial/issues/617
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Replace copy-pasted problems_cause declarations in Hart,
Oxfordshire, and East Sussex with a generic override in
UKCouncils.pm (as a bonus also overrides Stevenage)
|
|/ |
|
|
|
|
|
| |
patch for https://github.com/mysociety/FixMyStreet-Commercial/issues/603
more generic fix to follow
|
|
|
|
|
|
| |
I appear to have left this commented out. Comments from both ESCC
and a district council (Wealden) on same day seem to point to this
as root of error.
|
|
|
|
| |
Fixes #765.
|
|
|
|
| |
This prevents the creation of a category with a blank name. Fixes #556.
|
| |
|
|
|
|
|
|
| |
- yellow for open issues, green otherwise
- pins > 3 months hidden from /around/
- reduced number of pins on /reports/ to 20 (as per Bromley/Hart)
|
|
|
|
|
| |
Fixing issues with Bing geocoding for East Sussex,
for example "Church Street".
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- change front-page text
- rename Category to Type
By overriding report/new/category template snippet. This is hacked
in (including substitution of the "-- Pick a category --" text, as
not sure how to simply do this as a cobrand-specific translation.
- hide footer on mobile view
- pothole field input and display
This is a temporary request, which we hope will be superseded by
full integration in due course.
A command is documented in the cobrand to set the "extra" on the
contact info for the Potholes category. This is then displayed by
the UI. The default process_extras places it in extra, for
potential future processing.
As this is a temporary fix, we are calling this field
"detail_size", as this is automatically included in "Details" and
therefore also sent in the email.
(This means that we may need to update data later on to call this
"pothole_size" or similar in future?)
- contrast tweaks (Via request from Matt Tooke at ESCC.)
Not all handled precisely as he suggests:
* spacing of button nav -- more or less as suggested, but tweaks for
the <span> selected button, and reduced padding on non-frontpage.
* sign-in buttons: fixed using CSS for .green-btn instead of adding
HTML class throughout.
* mobile-footer: edited <footer> css, as suggested by Dave Arter.
- revert problematic CSS (breaks map report page)
- Remove spurious "FixMyStreet" button
- frontpage subheading wording
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use East Sussex-specific position_map.js
- Display map correctly on desktop
- Increase default zoom level and use correct grammar for postcode box
- Tidy up default font size and center elements on postcode form
- Correctly position report form, allow links in sidebar to be seen
- Make map guidance text visible on mobile
- Fix display of site header across all pages
- More sidebar/header fixes
- Override some text on the report sidebar to be more friendly
- Remove unused images
- Use breadcrumb bar for main nav on desktop
- Restore correct background colour to footer
- Tighten up vertical spacing on all pages
- Slacken vertical spacing on home page
- Stop the sidebar clobbering the footer
- Tidy up menu display
- Ensure form errors are shown properly
- Add greeting and 'sign out' link to appropriate place
- Ensure correct width is used on IE8
- Make 'home' breadcrumb a span instead of a link
- Hide top 4px border on mobile
- Remove breadcrumb styling from FMS nav
- Use ellipsis and correct capitalization on confirm page
- Don't uppercase all button labels
- Hide email icon in email fields
- Don't italicise input placeholder text
- Use correct font family, alignment and size for various elements
- Correct box shadow, fix pin alignment, various UI fixes
- Ensure font size isn't too small. Fix header on wide but small screens
- Don't adjust .content height for East Sussex pages
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Tidy up layout of a few elements on front and map pages
- ensure example places are within county
- match council website body width
- Remove 'size2' class from body
This means we don't need lots of little CSS hacks to tweak things back into position
- Restore 'contact us' underline
- Ensure content extends down to footer
- More UI layout tidying
- Make sure error and confirmation pages don't have obscured content
- Improve display of frontpage header on mobile
- Better CSS selector for header display on mobile
- Fix display of map on mobile
- Tidy up display of footer buttons on mobile
- Put mobile-specific styles back into base.scss
- css separate margin-top for map/twothirds pages
- Fix display of languages in footer on mobile
- Removed unused CSS files
- East Sussex doesn't have tracking_code.html, so remove reference to it
|
|
|
|
|
|
|
| |
- Get layout, including map working
- Identified major clash point for CSS
- Move eastsussex resources locally (in part to be able to override
clashing names like .container)
|
| |
|
|
|
|
|
|
|
|
|
| |
The feature to hide reports is still enabled, as it is used by other
`users_can_hide` bodies. As we want to roll out moderation to Bromley,
in this commit we hide the functionality *only* for Bromley. Of course
if we migrate those other users to this moderation method, then we will
need to make equivalent change to general template, and remove the
functionality from Report.pm.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- redaction marked with [...]
- of report and comments
- stores original data
- uses a single form, on the report/_main view
- requires additional permissions (user_body_permissions)
- Hide report functionality
- Moderation notification/contact form
- Moderation writes to admin_log
|
|
|
|
|
| |
Perhaps useful as we might be adding more stuff if the project expands,
e.g., geocoder disambiguation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'from_council' was renamed to 'from_body' and turned into a relationship
in b2aa34b Feb 2013, and the seesomething code was missed.
Though the FMS::DB::Result::User object would (correctly) throw an error
if an invalid method is called, *Catalyst* idea of a user object wraps this
in a Catalyst::Authentication::Store::DBIx::Class which uses AUTOLOAD to
delegate methods and swallows the error. e.g. this code always returns
false, hence the code path is never run.
(I think this is a bug and have opened:
https://rt.cpan.org/Ticket/Display.html?id=97640 )
Added test case and (hopefully) corrected template, will need a check
against site running copy with recent data to check that nothing looks
squiffy. We also had to change the %council_details stash, which was
based on the old code, not sure if suggested fix matches original
intent, but looks plausible. (As discussed with @dracos @stevenday
this is slightly repeated, and should arguably use ->{bodies} but that's
a possible future FIXME)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This street is on boundary of Bromley with Greenwich, so a simple
disambiguation of $town = "chislehurst" falls foul of UKCouncils->
area_check.
It may be worth overriding area_check in general, but in mean time,
setting a specific postcode (on the Bromley side of the administrative
boundary) allows the map to be seen.
|
|
|
|
|
|
| |
Fixes #406. Include Perl modules necessary for Email::Send::SMTP to
handle TLS/SSL, and upgrade Dir::Self due to
https://rt.cpan.org/Public/Bug/Display.html?id=88393
|
| |
|
|
|
|
|
|
| |
Testing two things:
* Putting the email box above the Yes/No, or repeating it inside.
* Showing the contents of the Yes/No sections at first, or not.
|
|
|
|
|
| |
Most cobrands can just inherit from the Default function, with
only those needing an exception specified.
|
|
|
|
| |
This should reduce confusion with the Default cobrand and override order.
|
| |
|
|\
| |
| |
| |
| | |
Conflicts:
web/cobrands/fixmystreet/base.scss
|
| |
| |
| |
| |
| |
| | |
only on FMS and only if from outside the uk
Fixes #571
|