aboutsummaryrefslogtreecommitdiffstats
path: root/perllib
Commit message (Collapse)AuthorAgeLines
* Updates to cpanfile and code for perl 5.20/5.22.Matthew Somerville2016-03-23-9/+9
| | | | | | | | | | | | | | | | | | | | The following modules had bugs that have been fixed for working in recent perls: * List::MoreUtils * Guard * PadWalker * aliased * URI * Convert::NLS_DATE_FORMAT The CGI module was removed from core in 5.20, so include it in the snapshot (I don't think it's actually used, but is a dependency). "{" needs to be escaped in regular expressions, and ~~ should not be used. Fix some tests that expect e.g. a certain hash ordering, to use sorted output or better comparisons.
* Don't double-decode geocoded addresses.Matthew Somerville2016-03-15-3/+6
| | | | | | | | | Perl 5.20 introduced a version of Encode that errors on decoding already decoded content (rather than returning the same string). Whilst this can be taken as a bug in our code (although the decoding exists because some versions of FastCGI silently UTF-8 encode the content), in the changelog for Perl the only reference to this change is the line: "Encode has been upgraded from version 2.49 to 2.60.".
* [fixmystreet.com] Friendly A/B test setup.Zarino Zappia2016-03-11-0/+21
| | | | | | | | Includes a smiley, bright yellow homepage, and updated nav bar and footer across the entire site; a few content changes; request for gender information from users. Fixes #1341.
* Set page stash variable even if map unused.Matthew Somerville2016-03-11-1/+1
| | | | | This variable can then be used by e.g. extra_name.html to know what form it is on.
* Add cobrand-specific custom reporting fields.Matthew Somerville2016-03-09-16/+22
| | | | | | This adds a new cobrand variable, report_form_extras, which contains a list of extra fields that will be saved in the 'extra' metadata of the report. Fields may optionally be marked as required.
* Rename process_extras to process_open311_extras.Matthew Somerville2016-03-08-9/+9
| | | | | It is currently only used for processing extra fields (the list, not the metadata hash) which is really only of relevance to Open311.
* Remember user's last anonymous state.Matthew Somerville2016-03-04-0/+10
| | | | | If a user is logged in, use their last report/update to set the default anonymity state.
* Only load images from disk when needed.Matthew Somerville2016-02-23-47/+44
| | | | Fixes #1337.
* Better handle replies to bounce addresses.Matthew Somerville2016-02-23-33/+68
| | | | | | | | | | Auto unsubscribe alert bounces, forward on report bounces and alert replies to support, and send through to report creator non-bounce replies to their report (for systems that ignore both the From and Reply-To headers). Also forward any totally unparsed bounce to support to possibly then adjust this bounce handling.
* Helper function for fetching database secret.Matthew Somerville2016-02-19-2/+14
|
* Skip sending if any body marks it for skipping.Matthew Somerville2016-02-11-4/+3
| | | | | | | If a report was sent to multiple bodies, one of which was set to skip, (e.g. temporarily turned off due to receiving issues), then the code would still try and send the report due to the other bodies, leading to multiple sendings and an error for the skipped body.
* Merge remote-tracking branch 'mysociety/add-osm-link-to-email'Matthew Somerville2016-02-09-3/+49
|\
| * Add OpenStreetMap URL to report email.Matthew Somerville2016-02-09-0/+47
| |
| * Switch final few JSON uses to JSON::MaybeXS.Matthew Somerville2016-02-09-3/+2
| |
* | Exclude update alerts from summary alert counts.Matthew Somerville2016-02-09-1/+9
|/ | | | | | There might be the odd update alert we are interested in (those not auto-signed up for as part of report or update creation), but they will be rare.
* Fix co-ordinate bug in Google geocoder.Matthew Somerville2016-01-29-1/+1
| | | | a4b6ed0f put the latitude in $longitude and vice-versa.
* Merge branch '1315-open311-update-media_url'Matthew Somerville2016-01-29-0/+14
|\
| * Spot media_url in Open311 GetServiceRequestUpdate.Matthew Somerville2016-01-29-0/+14
| | | | | | | | Fixes #1315.
* | If app user logged in, perform alert signup.Matthew Somerville2016-01-27-0/+1
|/ | | | Thanks to @jonkri for spotting.
* Merge branch '1146-social-login'Matthew Somerville2016-01-27-134/+371
|\ | | | | | | | | | | Conflicts: templates/web/base/report/new/fill_in_details_form.html templates/web/base/report/update-form.html
| * Add login by Facebook on generic auth screen.Matthew Somerville2016-01-22-12/+16
| |
| * Add login by Facebook when updating.Matthew Somerville2016-01-22-38/+129
| | | | | | | | Makes the flow more like new reporting.
| * Add login by Facebook when reporting.Matthew Somerville2016-01-22-45/+189
| |
| * Switch to JSON::MaybeXS, remove JSON::XS.Matthew Somerville2016-01-22-35/+29
| | | | | | | | | | | | Travis has Cpanel::JSON::XS preinstalled, which means that the build would fail there, as JSON::MaybeXS would try and upgrade JSON::XS to version 3 which the snapshot did not contain.
| * Prerequisites (new modules, db, config).Matthew Somerville2016-01-22-2/+8
| |
| * Remove unnecessary shebang lines.Matthew Somerville2016-01-22-2/+0
| |
* | Improve some error pages.Matthew Somerville2016-01-26-5/+1
|/ | | | | Use design of auth/token in generic error, 404, and token server error pages, and use the same error for too old/ token not found errors.
* Add ability to have multiple update photos.Matthew Somerville2016-01-12-10/+15
| | | | Also adds admin ability to rotate update photos.
* Factor multiple photo details into nicer function.Matthew Somerville2016-01-12-137/+65
| | | | | Remove get_photo_params, which only looked at the first photo, make explicit when we're doing that using `.first`.
* Remove most passing of Catalyst to PhotoSet.Matthew Somerville2016-01-12-14/+10
|
* Fix cache busting in photo URL on multiple photos.Matthew Somerville2016-01-08-3/+8
|
* Handle multiple photo rotation/removal in admin.Matthew Somerville2016-01-08-3/+53
|
* [fixmystreet.com] Don't show app step if used app.Matthew Somerville2016-01-06-1/+3
| | | | Fixes #1305.
* Remove unnecessary code, as ID is always a number.Matthew Somerville2016-01-06-6/+0
|
* Fix bug showing reports on Your Reports.Matthew Somerville2015-12-17-2/+2
| | | | | 92dfeac used an incorrect user column name in the new lookup, and there was no test to catch the regression.
* Add multiple photo upload support.Zarino Zappia2015-12-16-12/+35
| | | | | | | | | | Three file inputs, progressively enhanced with dropzone. This moves the photo input higher up, so that photos can upload while you're filling out the form. It standardises and improves photo error handling. [fixmystreet.com] Guidance for what photos should and shouldn’t include.
* Remove risk of infinite loop in PhotoSet.Matthew Somerville2015-12-16-9/+13
| | | | | | Use a separate attribute for data direct from a database row when creating a PhotoSet, so that data will always contain one or more photo IDs.
* Fix cobrand restriction of My/Nearby.Matthew Somerville2015-12-15-44/+58
| | | | | | | | | | | | 5c79337 simplified a bit too far, as after then a particular cobrand could in Nearby and My only filter reports to a particular body, not any other criteria. To fix this, introduce more generic functions in the default cobrand to allow more flexibility. Make sure a few tests delete their bodies fully so that new tests pass when run as part of the suite. Fixes #1289.
* Merge remote-tracking branch 'origin/admin-blank-email-name' into ↵Matthew Somerville2015-12-15-8/+14
|\ | | | | | | admin-blank-email-name
| * Make sure email and name are given in admin form.Matthew Somerville2015-12-09-8/+14
| |
* | Remove unused SOAP::WSDL package.Matthew Somerville2015-12-09-148/+0
|/
* Pass in EmailSend arguments as a hashref.Matthew Somerville2015-12-02-3/+4
| | | | | A fix to bb1e797; when started via a Catalyst model, e.g. send_email in FixMyStreet::App, an empty hashref is passed in.
* Merge branch 'reduce-fixmystreet-app'Matthew Somerville2015-12-02-1055/+1122
|\
| * Move main bin scripts to separate packages.Matthew Somerville2015-12-02-688/+738
| | | | | | | | Maintain old location wrappers.
| * Remove many uses of mySociety::Config.Matthew Somerville2015-12-02-36/+21
| |
| * Only initialize TimeZones if used.Matthew Somerville2015-12-02-3/+6
| |
| * Move from Moose to Moo in non-App code.Matthew Somerville2015-12-02-70/+55
| | | | | | | | And create default cobrand class without all of Moose.
| * Reduce use of FixMyStreet::App.Matthew Somerville2015-12-02-81/+77
| | | | | | | | Command line scripts don't need a full blown app, just database.
| * Move get_photo_params to Utils::Photo.Matthew Somerville2015-12-02-40/+45
| |
| * Move EmailSend out of Catalyst for use elsewhere.Matthew Somerville2015-12-02-182/+225
| |