aboutsummaryrefslogtreecommitdiffstats
path: root/perllib
Commit message (Collapse)AuthorAgeLines
...
* | display the contents of report's extra field in adminStruan Donald2018-04-26-0/+21
|/ | | | | | | | Instead of just a Yes/No display a formatted list of values in extra. Has special handling for known fields otherwise just prints them out dumbly. Fixes #1809
* Merge branch 'collideoscope-anew'Matthew Somerville2018-04-26-22/+41
|\
| * Add way of validating data in report_form_extras.Matthew Somerville2018-04-23-0/+8
| |
| * Add new report hooks for cobrand report munging.Matthew Somerville2018-04-23-0/+3
| | | | | | | | | | One to alter the category after initially set, one to change any details of the report before saving to the database.
| * Have only one bodies_to_list variable.Matthew Somerville2018-04-23-5/+3
| |
| * Add hook to alter list of bodies on /reports page.Matthew Somerville2018-04-23-0/+1
| | | | | | | | | | This allows a cobrand to e.g. display a subset of bodies based on a query parameter.
| * Add a cobrand hook to table dashboard generation.Matthew Somerville2018-04-23-17/+26
| | | | | | | | This allows a cobrand to categorise the reports however it wishes.
* | Sign up inspector, not creator, on inspection.Matthew Somerville2018-04-25-1/+1
| |
* | better diagnostics for rejected Open311 problemsStruan Donald2018-04-25-1/+2
| | | | | | | | | | Add a more helpful error message when a problem fetched over Open311 is rejected for problems with the date.
* | [Rutland] cobrand config changesStruan Donald2018-04-25-0/+9
| |
* | Don’t trigger response templates unless problem state changesDave Arter2018-04-23-15/+26
| | | | | | | | | | | | | | Response templates won't be triggered unless the problem state or external status code is changed. Fixes #2075
* | [Buckinghamshire] Increase fallback USRN lookup radius to 10MDave Arter2018-04-20-1/+1
| | | | | | | | | | It’s not quite a ‘radius’ as it’s a square box, but this does bring it closer in line with the cobrand JS behaviour.
* | [Open311] avoid spurious warning when params are undefStruan Donald2018-04-17-2/+17
| | | | | | | | | | | | | | If there was an undefined parameter passed to `_post` then generating the debug string would generate a warning about an undefined value in a concatenation. So, check for undefined params and substitute empty string to avoid.
* | [Open311] correctly handle one word names when splittingStruan Donald2018-04-17-2/+10
|/ | | | | | If a name only had a single word we were failing to split it and not setting `first_name`. Also refactor splitting out to a function so the regex is only in one place.
* Always set memcached namespace.Matthew Somerville2018-04-16-12/+4
| | | | | | The namespace was only being set in the web loop, so cron scripts were accessing different memcached keys. In particular, the state list would be shared between instances on the same host.
* [Oxfordshire] Fix admin exor download page.Matthew Somerville2018-04-16-1/+1
| | | | | 07906f40 changed the HTML date input form, but did not update the server parsing of the format.
* [FixaMinGata] Remove a state label from the staff dropdown menuJon Kristensen2018-04-13-0/+8
|
* Merge branch 'mapit-proxy-api-key'Matthew Somerville2018-04-13-2/+14
|\
| * Provide API key to MapIt proxy if present.Matthew Somerville2018-04-12-2/+14
| |
* | [Open311] Pretty print all request parameters.Matthew Somerville2018-04-13-4/+9
| |
* | Don’t send alert emails when archiving old reportsDave Arter2018-04-12-1/+16
|/
* Merge branch 'open311-update-problem-state'Matthew Somerville2018-04-11-16/+16
|\
| * [Open311] Generally store update state.Matthew Somerville2018-04-10-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, an update's problem_state was set via an Open311 update if: * the update timestamp was equal or greater to the report's last update; * the new state was visible, and not equal to the report's current state; * the update wouldn't change the report from a fixed state to another fixed state; * (Oxfordshire) the update wouldn't change the report from any open state to Open. It would also set the report's state to match if the report was currently visible. This mostly worked, but could lead to issues if e.g. the report started life in a non-confirmed state (e.g. we pulled it in already fixed from an external source), as then the update did not record its state and the update display got confused as to the state history. However it did mean there wasn't confusion if a later update than the Open311 update was made on the site itself. This new code will set an update's problem_state if: * the new state is visible; * the update wouldn't change the report from a fixed state to another fixed state; * (Oxfordshire) the update wouldn't change the report from any open state to Open. It will also set the report's state to match if the report is currently visible, changing state, and the update timestamp is equal or greater to the report's last update. So when the report state changes is unchanged, all the conditions still apply, but the update's problem_state is set more often (it will be set regardless of whether the timestamps align, or whether the state matches the report's current state). This could theoretically lead to issues elsewhere, e.g. if an update is left on a report on FixMyStreet and then an Open311 update is pulled in later (but with an earlier timestamp) that changes the state, the report state will not be updated due to the later update being made, though the Open311 update will list the state change, and then the later update might say it changed it back (if it recorded the current state in its problem_state), even though it technically did not. I think this issue is less worrying than the current situation, which can state that a random update has fixed a report when it was the previous update that did, and there will always be such issues with multiple sources of truth for a report status. An alternative would be to allow the Open311 update to override.
* | admin UI to configure fetch_all_problems Open311 optionStruan Donald2018-04-11-5/+18
| | | | | | | | | | | | UI to update the fetch_all_problems setting in extra for a body. This also adds handling for extra body values in the Admin in a similar manner to the way other body params are handled.
* | [Open311] fetch_all option for open311 problem fetchingStruan Donald2018-04-11-7/+17
| | | | | | | | | | | | | | | | | | If a body has a `fetch_all_reports` setting in the extra metadata then all reports are fetched over Open311 and processed regardless of age. This is useful for bodies where the API endpoint always returns all the reports as it suppresses the error messages you would otherwise get about reports with invalid dates.
* | add extra column to body tableStruan Donald2018-04-11-3/+9
| | | | | | | | Adds and extra column for bodies and the associated Extra role.
* | [BANES] Limit categories visible on cobrandDave Arter2018-04-10-0/+17
|/
* Reliably sort send methods in admin.Matthew Somerville2018-04-10-2/+2
|
* Lower case/strip whitespace from email addresses during user importDave Arter2018-04-10-0/+2
|
* Fix again test script running on PostgreSQL 9.1.Matthew Somerville2018-04-10-2/+4
| | | | | It was not enough to move the schema to a separate run, the two fixtures need to be separate too.
* [BANES] Add cobrand base_urlDave Arter2018-04-10-0/+6
|
* [BANES] Update contact addressDave Arter2018-04-10-1/+1
|
* [BANES] Pass fixed search string back to geocoderDave Arter2018-04-10-0/+1
|
* Geocoders: allow cobrands to fixup user's search stringDave Arter2018-04-10-0/+6
| | | | | This is useful, for example, if the cobrand has a list of common typos that you want to account for.
* [BANES] Send email when Open311 update submitted.Matthew Somerville2018-04-10-0/+6
|
* [BANES] Rename usrn field to site_codeDave Arter2018-04-10-4/+6
| | | | To match the more generic changes in open311-adapter
* [BANES] Handle common road name typos in geocoder disambiguationDave Arter2018-04-10-0/+21
|
* [BANES] Update wording of front page and report formDave Arter2018-04-10-0/+6
|
* [BANES] Lookup USRN at point of sending report, if not presentDave Arter2018-04-10-0/+51
| | | | | | | Reports made via FMS.com or the app probably won't have a USRN value because we don't display the adopted highways layer on those frontends. Instead we'll look up the closest asset from the WFS service at the point we're sending the report over Open311.
* [BANES] Send confirmation email for all reports upon sending to CouncilDave Arter2018-04-10-1/+1
|
* [BANES] Add report rejection workflowDave Arter2018-04-10-0/+14
| | | | WIP, for mysociety/fixmystreetforcouncils#284
* [BANES] Send report title and detail in individual Open311 attributesDave Arter2018-04-10-0/+16
| | | | | | | | | | The BANES Confirm integration puts the report title and description in different fields within Confirm. Because Open311 has no ‘title’ field for ServiceRequests, FMS will by default send the report title and description (along with a link) in a single string in the ‘description’ ServiceRequest field. The BANES open311-adapter code includes a title and description attribute on all published services, so this commit will fill those with the appropriate FMS fields when sending reports.
* [BANES] OSM geocoder & include full council nameDave Arter2018-04-10-1/+5
|
* [BANES] Add Email::BathNES send method with custom template for street light ↵Dave Arter2018-04-10-0/+23
| | | | reports
* [BANES] Add BathNES map type & assetsDave Arter2018-04-10-3/+31
| | | | | | | | | | | | | BANES have some staff-only assets, so this adds a cobrand hook to enable extra JS to be included on the page for staff users. - Add custom OpenLayers build with GeoJSON support - Add grit bins/street lights/LLPG asset layers - Displays non-BANES street light assets in grey - Add adopted highways to map This means USRNs will be set for reports made by members of the public. To keep the map simple, however, the highways layer is invisible to non-staff users.
* [BANES] Don’t delete non-Open311 categoriesDave Arter2018-04-10-2/+3
|
* [BANES] Add Bath & North East Somerset cobrandDave Arter2018-04-10-0/+54
|
* [fixmystreet.com] Stop non-council email sign-up.Matthew Somerville2018-04-09-4/+4
| | | | 100% false positives so far.
* Allow same-time state change from Open311 updates.Matthew Somerville2018-04-06-1/+2
| | | | | | If we've pulled in a report and an update from an external source, both may have exactly the same timestamp, and we do want to record the problem_state in that case.
* Check recent reports for any hidden since cached.Matthew Somerville2018-04-06-33/+19
| | | | | Also stop caching lat/lon specific alert photo lists, and improve Memcached code.