| Commit message (Collapse) | Author | Age | Lines |
|\ |
|
| |
| |
| |
| | |
It was not being caught by rerun_dbic_loader.pl otherwise.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Times in the database should be stored in the application server's local
timezone, by e.g. using `current_timestamp`, or by setting that timezone
explicitly before storage (the database columns are all without timezone
so any timezone info is silently ignored). Reports & updates fetched via
Open311 and offline updates were being put into the TIME_ZONE setting if
present, meaning they were stored incorrectly for future usage.
|
|/
|
|
|
|
|
| |
Currently, Dorset Council and BCP Council are bodies linked with
the relevant areas of the now-gone district councils; this means
there is no body linked with the area of the old county council,
which causes an error.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, it was unclear how many arguments the function took. When
running tests I saw the error:
Too many arguments for Cpanel::JSON::XS::encode_json at
perllib/FixMyStreet/Map/WMTSBase.pm line 217, near "}"
|
| |
| |
| |
| | |
Instead, load the required module directly.
|
| |
| |
| |
| | |
The only use of File::Slurp was removed in 1c5c614af7a0265bd.
|
| |
| |
| |
| |
| | |
This fixes an issue with slashes in category names in admin (as
PATH_INFO can't tell the difference between / and %2F).
|
| | |
|
|/ |
|
|
|
|
|
| |
If an update has a fixmystreet id in it check that it looks like an
integer and if not issue a warning and skip the update.
|
|
|
|
|
|
| |
Prevent people from using very long titles.
Fixes mysociety/fixmystreet-commercial#1344
|
|\ |
|
| |
| |
| |
| | |
This means GET errors will give better output.
|
|\ \ |
|
| |/ |
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
|
|
|
| |
->first, as used in cd8a5702, uses the iterator, so ->next will then
only return the second onward. Instead, do the needed thing in the
first iteration of the loop. Also check the option is set as some
scripts do not set it.
|
| |
|
|\ |
|
| | |
|
|/
|
|
|
|
| |
Previously if no reports were closed with an email this meant that the
lang setup never ran and you got an error when _ was called in
close_problems. So, we call the lang setup in close_problems too.
|
| |
|
|
|
|
|
| |
It can be hard to see where one error stops and a new one begins in the
send reports error emails so put in a more obvious break between them.
|
|
|
|
|
| |
Co-authored-by: Zarino Zappia <zarino@mysociety.org>
Co-authored-by: Matthew Somerville <matthew@mysociety.org>
|
|
|
|
|
| |
Add a privacy_policy_url function to the cobrand and use that in the
templates instead of hard coding /privacy
|
|
|
|
| |
Fixes mysociety/fixmystreet-commercial#1306
|
|\ |
|
| |
| |
| |
| |
| | |
The test has to now create a new comment object each time as
`get_cobrand_logged` is cached on the object.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If an update has a fixmystreet_id field then use the contents of that in
preference to the external_id field to match an update to a problem.
This handles the case where a report in a third party system passes
through different types (eg inspection and defect), resulting in the
external id changing. In this case it is sometimes possible to include
the fixmystreet id in each type and hence use that to match things up at
the fixmystreet side.
|
| |
| |
| |
| |
| | |
Remove the config that stopped us sending easting/northing if the user
had not clicked the map.
|
| |
| |
| |
| |
| | |
Otherwise running on a site where one body ID is a substring
of another, comments can get processed for the wrong body.
|
| | |
|
|/
|
|
|
| |
After the change in 1cff2a0e, we need to make sure this is set
so that the relevant fields are not shown in the front end.
|
| |
|
|
|
|
| |
Otherwise any such fields are lost upon a manual edit.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without doing this, a call to e.g. $contact->set_extra_fields(@meta)
in PopulateServiceList.pm, with an unchanged meta that contains some
Unicode values, can write to the database (and cause an unneeded row
in the history table), because the column from the database is UTF-8
decoded, whilst the new text is UTF-8 encoded.
It looks like an attempt was made in filter_from_storage to fix this
issue, but the column comparison for marking a column as dirty takes
place without this being called.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Rather than compile it all into on big string for output, write the
output as we go. Also output headers to encourage intermediaries to
stream as well.
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On some UK council cobrands, some reports listed might not have been sent
to that council, so links to those must go to the national site. However,
using absolute URLs for all these reports means that sometimes you change
domain when you don't need to (eg. if you’re on osm.fixmystreet.com or an
aliased version of the site), which can cause confusion. State when we’re
happy to use a relative link (ie. web-facing report links, not emails, or
share links) and do that when we can.
|
|\ \ |
|
| |/ |
|
|/
|
|
|
| |
This simplifies the places where a date range is used;
it also makes Dashboard date parsing more flexible.
|