aboutsummaryrefslogtreecommitdiffstats
path: root/perllib
Commit message (Collapse)AuthorAgeLines
* Merge branch 'moderation-dst-time'Matthew Somerville2019-05-03-465/+355
|\
| * Rename DB::ReportExtraFields to ReportExtraField.Matthew Somerville2019-05-02-9/+13
| | | | | | | | It was not being caught by rerun_dbic_loader.pl otherwise.
| * Use EncodedColumn subclass.Matthew Somerville2019-05-02-343/+129
| |
| * Refactor datetime inflation.Matthew Somerville2019-05-02-185/+283
| |
| * Fix some incorrect timezone code.Matthew Somerville2019-05-02-9/+11
| | | | | | | | | | | | | | | | | | Times in the database should be stored in the application server's local timezone, by e.g. using `current_timestamp`, or by setting that timezone explicitly before storage (the database columns are all without timezone so any timezone info is silently ignored). Reports & updates fetched via Open311 and offline updates were being put into the TIME_ZONE setting if present, meaning they were stored incorrectly for future usage.
* | [UK] Deal with setup where county may be missing.Matthew Somerville2019-04-29-2/+5
|/ | | | | | | Currently, Dorset Council and BCP Council are bodies linked with the relevant areas of the now-gone district councils; this means there is no body linked with the area of the old county council, which causes an error.
* Merge branch 'tidy_up' of https://github.com/tomhukins/fixmystreetMatthew Somerville2019-04-24-7/+5
|\
| * Explicitly pass one argument to encode_json()Tom Hukins2019-04-09-3/+3
| | | | | | | | | | | | | | | | Previously, it was unclear how many arguments the function took. When running tests I saw the error: Too many arguments for Cpanel::JSON::XS::encode_json at perllib/FixMyStreet/Map/WMTSBase.pm line 217, near "}"
| * Avoid string evalTom Hukins2019-04-09-3/+2
| | | | | | | | Instead, load the required module directly.
| * Stop loading an unused moduleTom Hukins2019-04-09-1/+0
| | | | | | | | The only use of File::Slurp was removed in 1c5c614af7a0265bd.
* | Use REQUEST_URI, not PATH_INFO, to infer path.Matthew Somerville2019-04-24-0/+5
| | | | | | | | | | This fixes an issue with slashes in category names in admin (as PATH_INFO can't tell the difference between / and %2F).
* | [BANES] Turn on new duplicate suggesting.Matthew Somerville2019-04-23-0/+2
| |
* | [Open311] Ensures non_public/hidden reports aren’t visible at /open311Dave Arter2019-04-23-1/+4
|/
* [Open311] handle bad FixMyStreet id in updatesStruan Donald2019-04-09-0/+5
| | | | | If an update has a fixmystreet id in it check that it looks like an integer and if not issue a warning and skip the update.
* [Northamptonshire] restrict title to 120 charactersStruan Donald2019-04-09-0/+8
| | | | | | Prevent people from using very long titles. Fixes mysociety/fixmystreet-commercial#1344
* Merge branch 'open311-better-get-error'Matthew Somerville2019-04-05-62/+41
|\
| * [Open311] Factor GET/POST calls together.Matthew Somerville2019-04-05-62/+41
| | | | | | | | This means GET errors will give better output.
* | Merge branch '2435-admin-anonymous-report'Matthew Somerville2019-04-05-10/+10
|\ \
| * | Fix superusers creating anonymous reports.Matthew Somerville2019-04-05-10/+10
| |/
* | [UK] Deal with 2019 local government changes.Matthew Somerville2019-04-04-0/+20
| |
* | Factor to common FixMyStreet::MapIt call.Matthew Somerville2019-04-04-54/+50
|/
* Make sure MapIt generation always used if given.Matthew Somerville2019-04-01-20/+25
|
* [Northamptonshire] do not display district/borough reportsStruan Donald2019-03-28-0/+7
|
* Fix archive report script to not skip first row.Matthew Somerville2019-03-28-7/+8
| | | | | | | ->first, as used in cd8a5702, uses the iterator, so ->next will then only return the second onward. Instead, do the needed thing in the first iteration of the loop. Also check the option is set as some scripts do not set it.
* [Northamptonshire] Update report_sent_confirmation_email.Matthew Somerville2019-03-27-1/+1
|
* Merge branch 'issues/commercial/1273-ref-number-com'Matthew Somerville2019-03-27-5/+15
|\
| * [UK] Council reference in .com confirm sent email.Matthew Somerville2019-03-27-5/+15
| |
* | make sure the archive report script sets up lang etcStruan Donald2019-03-27-0/+8
|/ | | | | | Previously if no reports were closed with an email this meant that the lang setup never ran and you got an error when _ was called in close_problems. So, we call the lang setup in close_problems too.
* [Northamptonshire] only display NCC categories on cobrandStruan Donald2019-03-26-0/+5
|
* more obvious delineation between reports in error emailStruan Donald2019-03-25-1/+1
| | | | | It can be hard to see where one error stops and a new one begins in the send reports error emails so put in a more obvious break between them.
* [Northamptonshire] cobrand config, template and css changesStruan Donald2019-03-25-0/+85
| | | | | Co-authored-by: Zarino Zappia <zarino@mysociety.org> Co-authored-by: Matthew Somerville <matthew@mysociety.org>
* Allow cobrand customisation of privacy URLStruan Donald2019-03-25-0/+8
| | | | | Add a privacy_policy_url function to the cobrand and use that in the templates instead of hard coding /privacy
* [Buckinghamshire] Send drainage reports via email as well as Open311Dave Arter2019-03-20-4/+10
| | | | Fixes mysociety/fixmystreet-commercial#1306
* Merge branch 'open311-hook-update-params'Matthew Somerville2019-03-12-9/+14
|\
| * [Open311] Use cobrand hook for extra update paramsMatthew Somerville2019-03-08-9/+14
| | | | | | | | | | The test has to now create a new comment object each time as `get_cobrand_logged` is cached on the object.
* | [open311] optionally use fixmystreet_id to match update to problemStruan Donald2019-03-12-2/+12
| | | | | | | | | | | | | | | | | | | | | | If an update has a fixmystreet_id field then use the contents of that in preference to the external_id field to match an update to a problem. This handles the case where a report in a third party system passes through different types (eg inspection and defect), resulting in the external id changing. In this case it is sometimes possible to include the fixmystreet id in each type and hence use that to match things up at the fixmystreet side.
* | [Oxfordshire] always send easting/northing over open311Struan Donald2019-03-12-4/+2
| | | | | | | | | | Remove the config that stopped us sending easting/northing if the user had not clicked the map.
* | [Open311] Proper bodies check for sending updates.Matthew Somerville2019-03-12-3/+1
| | | | | | | | | | Otherwise running on a site where one body ID is a substring of another, comments can get processed for the wrong body.
* | Let all cobrands treat hidden_fields as hidden.Matthew Somerville2019-03-12-2/+2
| |
* | [UK Councils] Make sure server_set as appropriate.Matthew Somerville2019-03-12-0/+23
|/ | | | | After the change in 1cff2a0e, we need to make sure this is set so that the relevant fields are not shown in the front end.
* [Bromley] Reduce heatmap default time to one monthMatthew Somerville2019-03-08-1/+1
|
* Show all Open311 extra fields in edit admin.Matthew Somerville2019-03-07-3/+0
| | | | Otherwise any such fields are lost upon a manual edit.
* Make sure raw RABX column is utf8-encoded.Matthew Somerville2019-03-06-4/+8
| | | | | | | | | | | | Without doing this, a call to e.g. $contact->set_extra_fields(@meta) in PopulateServiceList.pm, with an unchanged meta that contains some Unicode values, can write to the database (and cause an unneeded row in the history table), because the column from the database is UTF-8 decoded, whilst the new text is UTF-8 encoded. It looks like an attempt was made in filter_from_storage to fix this issue, but the column comparison for marking a column as dirty takes place without this being called.
* Merge branch 'stream-csv-output'Matthew Somerville2019-03-05-11/+25
|\
| * Stream dashboard CSV output.Matthew Somerville2019-03-05-11/+25
| | | | | | | | | | | | Rather than compile it all into on big string for output, write the output as we go. Also output headers to encourage intermediaries to stream as well.
* | Merge branch 'report-links-same-domain'Matthew Somerville2019-03-05-0/+17
|\ \
| * | Use relative report links where possible.Matthew Somerville2019-03-05-0/+17
| |/ | | | | | | | | | | | | | | | | | | On some UK council cobrands, some reports listed might not have been sent to that council, so links to those must go to the national site. However, using absolute URLs for all these reports means that sometimes you change domain when you don't need to (eg. if you’re on osm.fixmystreet.com or an aliased version of the site), which can cause confusion. State when we’re happy to use a relative link (ie. web-facing report links, not emails, or share links) and do that when we can.
* | Merge branch '374-default-show-name'Matthew Somerville2019-03-05-9/+1
|\ \
| * | Default to unchecked for default_show_name.Matthew Somerville2019-03-04-9/+1
| |/
* / Add DateRange class.Matthew Somerville2019-03-04-45/+109
|/ | | | | This simplifies the places where a date range is used; it also makes Dashboard date parsing more flexible.