| Commit message (Collapse) | Author | Age | Lines |
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
It is possible that the category of a report no longer exists and in
that case the Open311 send process was falling over. This checks that
we've found a contact and if not sets the error and skips the report.
|
| |
|
| |
|
|
|
|
|
| |
The test has to now create a new comment object each time as
`get_cobrand_logged` is cached on the object.
|
|
|
|
|
|
|
| |
Includes an option to send to the council instead for e.g. reports on
underpasses or bridges.
Fixes #736
|
| |
|
|
|
|
|
| |
we no longer need some of the hardcoded oxfordshire Open311 overrides so
remove them
|
| |
|
| |
|
|
|
|
|
| |
has_permission_to() is called in Reports.pm and requires the cobrand to be
set on the schema. The test was manually doing this which hid the problem.
|
| |
|
| |
|
| |
|
|
|
|
| |
Store a schema object on FixMyStreet::DB instead.
|
|
|
|
|
| |
A new 'state' column replaces confirmed and deleted, allowing
categories to be unconfirmed, confirmed, deleted or inactive.
|
|
|
|
| |
This means that the tests can be run in parallel.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Historically in UK cobrands, bodies have had IDs the same as the MapIt
area ID they cover. This can be confusing (if you are setting up a dev
environment, say) and should not be necessary. This commit removes the
requirement entirely, by switching any ID checks to either the name of
the body, or the actual area it covers.
One note: the body name in the test has to match so that we do not get
two bodies both covering 2237 created. This will not be necessary when
the tests are compartmentalized in the next commit.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid doing cobrand-specific logic within SendReport::Open311.
The hooks defined are:
open311_config: set extra fields
open311_pre_send: set endpoints and munge data
These are tested in the new t/app/sendreport/open311.t, which does
not send any actual reports, but just checks that all the data is
munged into the expected format. (tests under t/open311* should
already test the actual sending)
Remove unused Open311 special cases.
|
| |
|
|
|
|
|
| |
When a trusted user makes a report in a category that requires inspection, it'll
be sent immediately (i.e. without being inspected first).
|
|
|
|
|
|
|
|
|
|
|
| |
Categories can now require reports to be marked as 'inspected' via the frontend
before they're sent by send-reports.
A side-effect here is that send-reports will perform an extra n queries for each
report, where n is the number of bodies that report is being sent to, but
hopefully in practice this won't matter as it's an offline cronjob.
See mysociety/fixmystreetforcouncils#50
|
| |
|
| |
|
|
|
|
| |
Command line scripts don't need a full blown app, just database.
|
| |
|
|
|
|
|
| |
This means that e.g. SMTP authentication is used when set up by all
emails, not just non-cron ones. Fixes #988.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
bin/open311-populate-service-list
bin/send-comments
bin/update-all-reports
conf/crontab.ugly
db/schema.sql
perllib/FixMyStreet/App/Controller/Admin.pm
perllib/FixMyStreet/App/Controller/Report/New.pm
perllib/FixMyStreet/App/Controller/Reports.pm
perllib/FixMyStreet/Cobrand/Default.pm
perllib/FixMyStreet/Cobrand/LichfieldDC.pm
perllib/FixMyStreet/DB/Result/Open311conf.pm
perllib/FixMyStreet/DB/Result/Problem.pm
perllib/FixMyStreet/DB/ResultSet/Problem.pm
perllib/FixMyStreet/SendReport.pm
perllib/FixMyStreet/SendReport/Email.pm
perllib/FixMyStreet/SendReport/Open311.pm
perllib/Open311/GetServiceRequestUpdates.pm
perllib/Open311/PopulateServiceList.pm
t/app/controller/report_new.t
t/app/controller/rss.t
templates/web/bromley/report/display.html
templates/web/default/admin/council_contacts.html
templates/web/default/common_header_tags.html
templates/web/default/dashboard/index.html
templates/web/default/front/stats.html
templates/web/default/report/_main.html
templates/web/default/report/update-form.html
templates/web/emptyhomes/index.html
templates/web/emptyhomes/report/display.html
templates/web/emptyhomes/report/new/councils_text_all.html
templates/web/emptyhomes/reports/body.html
templates/web/emptyhomes/reports/index.html
templates/web/fixmystreet/report/new/fill_in_details_form.html
templates/web/fixmystreet/report/update-form.html
web/cobrands/fixmystreet/fixmystreet.js
web/js/fixmystreet.js
|
| |
| |
| |
| | |
than one body.
|
| | |
|
| |
| |
| |
| | |
Add foreign key constraint from contacts to body.
|
|/
|
|
| |
warnings.
|
|
|