| Commit message (Collapse) | Author | Age | Lines |
|---|
| ... | |
| |/
|
|
|
| |
This functionality isn't needed here, and causes an issue with the main
form submitting due to a form inside a form.
|
| |
|
|
|
|
|
|
|
|
| |
If a user is trying to remove a problem from their shortlist we should
always allow it regardless of the state of the problem. Previously if a
problem wasn't displayed on the site then it could not be removed from
the shortlist which was an issue with council cobrands and reports that
had changed body.
Fixes mysociety/fixmystreetforcouncils#243
|
| |\ |
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
| |
It was possible to mark a report as a duplicate in the inspector panel
without providing an id of the duplicate. This prevents that.
Fixes mysociety/fixmystreetforcouncils#236
|
| |\ |
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Create a comment on a problem when the admin is used to change the state
of the problem. If only the state is changed then create a comment with
blank text. If the category and state are changing then include details
of the category change in the comment.
Not all the state changes are displayed at the template level by
default.
Fixes #1846
|
| |\ |
|
| | |
| |
| |
| |
| | |
URLs have to be manually constructed, but specifying multiple ward names
separated by "|" will show all those wards and their reports on the map.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
If there was a normal email alert, and then an alert for an update with
no text (so no email should be sent), it would still try to send the
blank email, and then die because no e.g. $data{cobrand} set.
This moves the skip-blank-update check higher up, above any email
sending code.
|
| | | |
|
| | | |
|
| |\ \ |
|
| | |/
| |
| |
| |
| | |
We have no way of knowing whether a +1 geographic number is fixed
line or mobile, so accept them all as potentially mobile.
|
| |/
|
|
|
|
| |
This lookup is often performed by inspectors with appcache switched on,
which means they were getting the intercepted Glitch page rather than a
404; give them a no results page instead.
|
| |
|
|
|
|
|
|
|
|
|
| |
This resolves two issues when updating the report category in the
staff users inspect form:
* report category is only updated if the rest of the form is valid
* only one update on the report is left
Previously changing the category would create an update in addition to
any public update created, and the category was always updated even when
validation errors occurred elsewhere in the form.
|
| |
|
|
|
| |
If no problems have changed status then set the average to -1 so we can
cope with an average status change of 0 days.
|
| |
|
|
|
|
|
|
|
|
|
| |
Doing this calculation in code turns out to be much too slow.
As part of this also fix an issue where if a report changed state last
month but had a further comment this month that was counted as being
a state change this month.
Also tweak the 'last month' start date to be midnight so the stats don't
change throughout the day.
|
| |
|
|
|
|
| |
By default encode_entities uses named entities, which don't exist
by default in XML. It seemed nicer to switch to only escaping the
minimum rather than switching to numeric entities.
|
| |
|
|
|
|
| |
This expands the 'change email' functionality to work with phone
number also, allow addition of missing details, and verifying of
unverified details.
|
| | |
|
| |
|
|
|
|
|
| |
This includes search/flagging users, editing user on the report
and update edit pages, and user adding/editing itself.
Add some more tests for user adding/editing.
|
| |
|
|
| |
A confirmation code is sent via Twilio to be entered on the site.
|
| |
|
|
|
| |
These are so we can state whether a user's email address or phone number
have been verified by confirmation email/text.
|
| |
|
|
|
|
| |
Move the social auth functions to Auth::Social, and the
change email/password functions to Auth::Profile. There
are no actual code changes.
|
| |
|
|
|
|
| |
This test would pass offline (as query would fail without error),
and online was passing because Nominatim was presumably returning
no results before today?
|
| |
|
|
|
|
|
| |
If we've stored the nearest address then display that at the top of the
inspector panel.
Fixes mysociety/fixmystreetforcouncils#234
|
| | |
|
| |
|
|
|
|
|
|
| |
RDI files have a 180 character limit for the description so limit the
description to 172 to allow for the ID which is also included in this
field.
Fixes mysociety/fixmystreetforcouncils#228
|
| |
|
|
|
|
|
|
|
| |
Admin page to show some simple summary stats for an area.
If the user has been assigned to an area then they will see the stats
for that area. Superusers can pick which area they want to view.
For mysociety/fixmystreetforcouncils#2
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was possible for _hardcoded_states to be reached with no locale
selected (e.g. bin/update-all-reports), causing an error trying to
translate Open/Closed. But translating those there wasn't correct,
because that would then be cached and returned even if a different
language was being used. Caching was ignored in testing, which did
not help.
We no longer translate the state names in their objects, only upon
display at the point that we will know the locale. We can't simply
return the translation of Open/Closed because there may be entries
in the translation table as well.
|
| |
|
|
|
| |
Couple of missed strings for translation, and prevent a couple of
warnings in tests.
|
| | |
|
| | |
|
| |
|
|
|
| |
And update the tests to avoid a random failure caused by inconsistent
ordering.
|
| |
|
|
|
|
| |
Alert options on the /alert/list page are now in an order that is easier
to parse, with a slightly clearer message for users in two-tier
locations, and a more prominent email subscription CTA.
|
| |
|
|
|
|
| |
This test assumed /reports would load, which it wouldn't if run in
parallel and the data hadn't been generated by reports.t. Test a
different page instead.
|
| |
|
|
| |
Fixes mysociety/fixmystreetforcouncils#221
|
| |
|
|
|
|
|
| |
Adds a Ward column to the council dashboard CSV export with the name of
the ward.
Fixes mysociety/fixmystreetforcouncils#220
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
State display names are now got from the database wherever they are
displayed, including admin dropdowns, list filters, and update meta
statements. This also covers the open/closed/fixed 'groups'.
This also fixes a bug whereby if e.g. an update has problem_state
investigating, the next update has no problem_state, and the last
update has investigating again, it was previously showing a state
change to investigating on that third update.
|
| | |
| |
| |
| |
| | |
We keep the internal states hardcoded, plus the core open (confirmed)
and closed ones, but the remainder are moved to the database.
|
| | |
| |
| |
| | |
Allows easy display of Open311 field values for problems in templates
|
| | | |
|
| | |
| |
| |
| | |
If set to 1, this restricts all pages on the site to logged-in users.
|
