| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update:
* Catalyst
* Specify Catalyst::DispatchType::Regex explicitly
* Remove Catalyst::Plugin::Unicode::Encoding
* Catalyst::Plugin::SmartURI
* Specify URI::SmartURI explicitly
* Catalyst::Plugin::Static::Simple
* CGI
* Class::Load
* DateTime
* DateTime::TimeZone
* DBD::Pg
* DBIx::Class
* DBIx::Class::EncodedColumn.
* Email::Address.
* Email::MIME
* ExtUtils::MakeMaker
* ExtUtils::ParseXS (for Params::Classify upgrade)
* File::ChangeNotify
* Image::Size
* IO::Socket::SSL
* local::lib
* Moo
* Moose (and some related others due to deprecations)
* namespace::autoclean
* Net::Server
* Net::SSLeay
* Number::Phone
* Plack
* Starman
* Template
* Test::PostgreSQL
* Test::WWW::Mechanize::Catalyst
* Text::CSV
* YAML
carton install was run on a wheezy box, the oldest that is supported, to
make sure the required minimal vesions of core modules weren't removed
from the snapshot. Cpanel::JSON::XS, Devel::GlobalDestruction::XS, and
MooseX::NonMoose were then put back in the snapshot, in case another
system needs them (e.g. system Perl on Mac looks for MooseX::NonMoose).
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Simplify markup required for the status banner.
* Simplify styles - the banner is now identical on all screen sizes.
* Move the banner from `report/display.html` into `report/_main.html`
so that it can appear after `.problem-back` in the source order.
* Use real pin icon instead of `pin-flat-white-small.png`.
* Set a default `$col_fixed_label` colour in `_base.scss`, so cobrands
don’t have to define it themselves if they’re happy with green.
* Introduce `$col_fixed_label_light`, with a sensible default for all
cobrands, even ones that have a custom `$col_fixed_label`.
* Remove `$col_fixed_label_dark` – no longer needed.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* Stop red warning being output by S3 bucket creation failure test
* Make sure 'num_old_reports' is always a number on /around pages
* Stop 'category_extra' being generated when unnecessary
* Prevent warning printed in getservicerequestupdates.t
* Prevent info lines from being output in develop.t
* Remove line of #s in root.t
* And an ID diag in zurich.t
|
| |
|
| |
|
|
|
|
|
|
|
| |
The Zurich code was written a long time ago, and used overriding so that
e.g. the hard-coded 'investigating' state referred to Wunsch (wish). Now
that states are stored in the database, we can create ones specially for
Zurich and use them instead. Hooray!
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
The code for moving a report to the intermediary state was running
even if the report was in a closed state and had not been changed.
|
|/ |
|
|\ |
|
| |
| |
| |
| |
| | |
When more than one photo has been uploaded, allow each one to
be published/not independently.
|
|/ |
|
| |
|
|
|
|
|
|
| |
Simplify chaining of body/category admin URLs so that all
categories are treated the same, with `/` or without, and
the template will then always have its CSRF token.
|
|
|
|
|
| |
Update the map/list if the map is zoomed/panned, and make sure the
updated HTML list is returned.
|
|
|
|
|
| |
A new 'state' column replaces confirmed and deleted, allowing
categories to be unconfirmed, confirmed, deleted or inactive.
|
|
|
|
| |
This means that the tests can be run in parallel.
|
| |
|
|
|
|
|
|
| |
To deal with a recipient mail server not allowing inbound email
using the same domain as an internal domain, e.g.
https://community.mimecast.com/docs/DOC-1419
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Zurich::admin_type function was setting $c->stash->{body}, meaning that
when trying to edit a superuser the 'fetch_contacts' function wasn't being
called, causing an "Can't call method "all" on an undefined value" error as
$c->stash->{live_contacts} wasn't ever being set.
Fixed by changing the conditional to simply determine whether fetch_contacts
needs to be called.
Included a regression test that meant a small addition to the MapItZurich mock.
|
|
|
|
|
| |
This is less confusing than redirecting to /auth and then to /my
(as they're logged in). Fixes #1566.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Also takes the opportunity to fix the incorrectly-encoded sender name which
was appearing to some clients as "Züri Wie Neu".
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following modules had bugs that have been fixed for working in
recent perls:
* List::MoreUtils
* Guard
* PadWalker
* aliased
* URI
* Convert::NLS_DATE_FORMAT
The CGI module was removed from core in 5.20, so include it in the
snapshot (I don't think it's actually used, but is a dependency).
"{" needs to be escaped in regular expressions, and ~~ should not be
used.
Fix some tests that expect e.g. a certain hash ordering, to use sorted
output or better comparisons.
|
| |
|
|
|
|
| |
Command line scripts don't need a full blown app, just database.
|
|
|
|
|
|
|
|
| |
The 'public response' to a problem was being omitted from the email sent to the
user when the problem is closed, because the email was sent before the report's
'extra' field was updated with the response body text.
This commit sets the public response on the problem before sending the email.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See mysociety/FixMyStreet-Commercial#690
I understand redirection to summary page was introduced at ZWN's request,
to make it easy to
process reports and then quickly move onto the next one.
However, during testing now, Tobias has mentioned this is a) slowing
things down and b) confusing because it's not obvious that the report
has been saved.
I've tried to address (b) by adding the "Aktualisiert!" message when
you are redirected.
Also, for (a) I've removed the redirection from a few cases, and
disabled it for superuser. If need be, I can remove redirection from
more (or all) cases.
Fix Official answer/Reply to user
- hide label for status update on state change
- correct wording on button for closure (single wording)
- correct wording on label for user reply (either "Official answer" or "Reply to user" as appropriate)
- Make sure the official response texts are shown for edit/static as appropriate, and test.
- javascript improvements
- honour public status update for Extern/Wunsch too
- don't show public message for Wunsch
- Ignore all other fields when rotating photos.
(See mysociety/FixMyStreet-Commercial#718)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requirements:
=============
1: DM to be able to mark a problem as Wish, Extern, Not contactable,
Hidden, Jurisdiction unknown
2: SDM to be able to mark a problem as Not contactable.
3: DM to be able to add information to such a problem, and trigger
emails to external agencies, and to user, closing the problem at the
same time.
4: Closed reports must be categorized as Wish/Extern/NC/Hidden/JU for
statistical reporting
5: Non-closed reports must appear as open, to allow DM to see them in
the list, similar to what is currently done for Ruckmeldung Ausstehend
(Feedback outstanding).
5b: however "Hidden" problems must be immediately hidden from public
view.
Proposal:
=========
a) Requirement 1 will be carried out in exactly the same way by
DM. e.g. Category dropdown select
b) Requirement 2 will be carried out in exactly the same way by SDM.
e.g. "Not contactable" button
c) BUT, for a), c), the category will be diverted to "Ruckmeldung
Ausstehend" (Feedback outstanding), and metadata will be saved with the
appropriate closure type.
d) NOTE: this means the report will still be visible to public as "In
bearbeitung" (Except for Hidden reports, as per 5b)
e) The extra fields will be presented on the "Ruckmeldung Ausstehend"
page, just as defined in the PDF, depending on the metadata. e.g.
- Wish: Zustaendige Stelle + Message
- Extern: External body + Message2
- Not contactable: (no extra info)
- Hidden: (no extra info)
- Jurisdiction unknown: (no extra info)
f) When the DM publishes the answer (e.g. "Antwort Veroeffentlichen"
button), the state will normally change to Fixed. BUT in the new cases,
the metadata saved in step c) will be checked, and the report will
change state to Wish/Extern/Not contactable/Hidden/Jurisdiction unknown,
as appropriate. The report will now be visible/hidden as previously
discussed depending on the new state.
g) If the report is edited again (in /admin/report_edit) it will be in
the relevant state, and any extra fields will be visible as per e).
Those fields may be updated.
Alternatively, the state may be changed, possibly triggering a) again,
and clearing any metadata.
- Fix javascript interactions 690
- show new statuses in summary
- fix photos on SDM page
- fix Planned => Planned+metadata transition
- stop "assignation .select" js affecting templates
- fix redirection for Extern and generally
See mysociety/FixMyStreet-Commercial#672, mysociety/FixMyStreet-Commercial#690
|
|
|
|
|
|
|
| |
- submit-external-wish.txt includes a link with report's coordinates, template values are interpolated
Conflicts:
perllib/FixMyStreet/SendReport/Zurich.pm
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See mysociety/FixMyStreet-Commercial#690
- external_message for Extern/Wunsch states
- as per PDF mockups, the "public response" field is now editable
from more states, namely:
- Ruckmeldung ausstehend
- Extern
- Zustandigkeit unbekannt
- Wunsch
- Nicht kontaktierbar
- Unsichtbar
- test fixes
NB: slight hack to reorder Zurich report_display tests
As these remove 'investigating' from hidden_states, these break
tests for default cobrand (the FMS::App code expects to be called
once on request start, not multiple times within one test)
- Not contactable button
and tests for this and the similar `send_back` functionality
(previously untested).
NB: Unsure why we need to specify form_number=2 just for these submits,
but test won't find the buttons otherwise.
- Make sure SDMs' "time_spent" figure is recorded.
(See mysociety/FixMyStreet-Commercial#718)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mechanism is general, but current implementation only used
for Zurich.
- Zurich: Record time_spent field mysociety/FixMyStreet-Commercial#676
- template changes (including jQuery spinner)
- backend changes to save data are made:
- in log_edit, if supplied
- and time on category change (and arbitrary actions)
- Add update_admin_log to all paths for DM, ensuring that it gets called,
while resetting the `time_spent` parameter, to make sure that
there is never a duplicate record created.
- Also quell warning about using DateTime values in query.
- Also add (seemingly unrelated) parens to stop misparsing of OK line in
questionnaire test now that DT::Format::Pg is used in Zurich cobrand
See mysociety/FixMyStreet-Commercial#676
|
|
|
|
| |
See mysociety/FixMyStreet-Commercial#675
|
|
|
|
|
|
|
|
|
|
|
| |
- Save 'photo_required' value in Contact->extra from admin edit form
- Enforce per-category photo requirement on new reports
A new step has been added to the photo upload process that
ensures a photo is present if any of the categories chosen for
the report require it.
If the photo is missing an error is displayed to the user in the
same manner as if the photo upload was invalid.
- Add test of mandatory photo categories
|
|
|
|
|
|
|
|
| |
For Zurich, see mysociety/FixMyStreet-Commercial#664.
This commit includes a new PhotoSet class (NB: called Model:: though not
really a model), should handle binary data (e.g. old style photos in
database), fileids (40-char hash), and Catalyst::Upload objects.
|
|
|
|
|
|
|
| |
Admin CR4 https://github.com/mysociety/FixMyStreet-Commercial/issues/673
seems like admin_pages should be able to generate the menu, but
this change also needs template change.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Original Report description
- Amended Report description (unsure what this is)
- Media URL (currently one picture, in the future 1-3 pictures)
- Interface used (see open311)
- Requested datetime (see open311) (seems to be same as
created)
- Agency sent datetime (see open311)
- Updated datetime (see open311)
- Council-Response
- title
as per https://github.com/mysociety/FixMyStreet-Commercial/issues/678
|