| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
|
|
| |
Fixes #357.
Also consolidate almost-identical fill_in_details.html template
(for #344).
|
|
|
|
|
|
|
| |
- Tweaks required to get things working in WCC environment
- update Open311 to onsite changes
- updated Open311 parameters after WCC's Bentley and County Highways workshop.
- ... including ce_cpr_id
|
|
|
|
|
| |
Uses LWP::Protocol::PSGI to avoid having to spawn external processes
in order to test these end to end.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
::Integration::Warwick subclasses ::Integration::Exor
refactor request_class and new_request
Exor service
Warwickshire updates retrieval, with datetimes
stubbing out of Oracle constants, for local testing
We also edit FMS's core PopulateServiceList routine to hide system
fields from FMS:
Bromley/Warwickshire send metadata in their services/FOO.xml
advising that you can pass, e.g. attributes[easting].
FMS by default shows all of these to the user to fill in, however
we don't *want* the user to supply these, rather they are added
by the cobrand.
Bromley had an exception for this (keyed by $body->areas->id).
We write this more generally for Warwickshire too, keying instead
by $body->name (as this is far less likely to be overridden for
installs using global or custom Mapit's)
|
|
|
|
|
|
|
|
| |
See also MooX::ConfigFromFile, but that's underdocumented and
seems overengineered -- may be worth implementing if requirements
become more complex however. (See also Config::Any, which is
well worth doing in future, using YAML only reflects current
usage in FMS though.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Get Service Request Updates
This requires a new object ::Service::Request::Update, which of course
is not part of standard spec. So, in order to make the core not too
contaminated by :
* the endpoint should instantiate ::Service::Request::mySociety objects
which know about updates
* have added a learn_additional_types callback from Schema to Endpoint,
so that core doesn't need to know about /open311/service_request_update
* (but ::Spark knows about the exception for updates... meh, but is 1-line)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsystems include
* ::Spark encoding conventions for xml/json
* ::Schema using Rx to validate form of inputs and outputs,
including validation for, e.g., dates and CSV as part of Open311
Handles following paths:
* Open311 attributes for Service Definition
http://wiki.open311.org/GeoReport_v2#GET_Service_Definition
* POST service request
* GET Service Requests
* GET Service Request
Objects:
* ::Service
* ::Service::Request
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First Warwickshire styling
- imported WCC's header and footer files
- Use Warwickshire colours for page elements
- Include FMS elements in header
- Use correct Warwickshire colours on map
- Use full-screen map on desktop.
- Improve display of homepage elements
- Ensure correct classes are added to body tag
- Make sure site header has correct height on front page
- Tidy-up of unused header content and wrappers
- Improve display of map
- Position map beneath other elements
Improve map display
- Take some CSS from Warwickshire styles to ensure its applied
- Fix container widths on map page
- Make sure map wrapper is the correct width
- Add style overrides to match Warwickshire.gov.uk
- Ensure map controls are visible
Nav and mobile styling
- Make sure sticky sidebar nav is usable
- Improve mobile front page
- Ensure map is full-screen on mobile
- Improve front page display on mobile
- Fix map display on desktop
- Fix Warwickshire and FMS nav on mobile
- Add viewport meta tag for mobile devices
- Tighten up vertical spacing on front page
- Fix header height on tablet size screens
- Set pan/zoom position in CSS, not JS
Styling tweaks
- correct styling of nav for wider screens (previous hidden by media query)
- Add draft Warwickshire FAQ
- Fixes https://github.com/mysociety/FixMyStreet-Commercial/issues/611
- Warwickshire. remove all reports link as requested.
- see https://github.com/mysociety/FixMyStreet-Commercial/issues/609
- Update WCC footer
- see https://github.com/mysociety/FixMyStreet-Commercial/issues/597
Bring WCC css locally, and override
- Override for
https://github.com/mysociety/FixMyStreet-Commercial/issues/612
- favicon
https://github.com/mysociety/FixMyStreet-Commercial/issues/616
- update contact details
- custom FAQ
- fix padding on mobile
https://github.com/mysociety/FixMyStreet-Commercial/issues/617
|
|
|
|
|
|
| |
Replace copy-pasted problems_cause declarations in Hart,
Oxfordshire, and East Sussex with a generic override in
UKCouncils.pm (as a bonus also overrides Stevenage)
|
|
|
|
| |
Group things together more simply. Fixes #738.
|
|
|
|
| |
This prevents the creation of a category with a blank name. Fixes #556.
|
|
|
|
| |
Looks like Travis doesn't like connections back to itself.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'from_council' was renamed to 'from_body' and turned into a relationship
in b2aa34b Feb 2013, and the seesomething code was missed.
Though the FMS::DB::Result::User object would (correctly) throw an error
if an invalid method is called, *Catalyst* idea of a user object wraps this
in a Catalyst::Authentication::Store::DBIx::Class which uses AUTOLOAD to
delegate methods and swallows the error. e.g. this code always returns
false, hence the code path is never run.
(I think this is a bug and have opened:
https://rt.cpan.org/Ticket/Display.html?id=97640 )
Added test case and (hopefully) corrected template, will need a check
against site running copy with recent data to check that nothing looks
squiffy. We also had to change the %council_details stash, which was
based on the old code, not sure if suggested fix matches original
intent, but looks plausible. (As discussed with @dracos @stevenday
this is slightly repeated, and should arguably use ->{bodies} but that's
a possible future FIXME)
|
| |
|
|
|
|
|
|
| |
Hopefully this will reduce the chance of a timeout:
* Wrap admin body tests in MapIt override.
* Use full hostname to save a redirect each time.
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add a type parameter to the /reports/body page to restrict list by
problem category.
Only link to report categories that have entries.
Fixes #798
|
|/
|
|
|
|
|
| |
Council redirects, BASE_URL comparisons, hard coded links, email
signatures
For #488
|
|
|
|
|
|
|
|
|
| |
If your browser autocompleted form fields, you could fill in the signing
in part of the form but still be sent a confirmation email. This commit
will now default to trying to sign in if the sign in button is clicked
or there is data in the signing in password field.
Fixes #816.
|
| |
|
|\ |
|
| |
| |
| |
| | |
And FixMyStreet.com specific open questionnaire page.
|
| |
| |
| |
| |
| |
| | |
Otherwise, when MapIt Global is updated, the 'point' lookup, as it only
returns the current generation by default, might no longer return the
areas present in the whitelist.
|
|/
|
|
|
|
|
|
|
|
|
| |
Instead of counting the number of lines output by dashboard CSV export,
the content is parsed as CSV and the number of rows present is checked.
Also includes a problem report that's split across multiple lines, testing
the fix for mysociety/FixMyStreet-Commercial#494 introduced in
d75e161c151c4f1e6dced24eae3170e01f9b7ba6.
Closes #780.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In order to try and cut down on people mistakingly using this form to
try and contact their council all some 'who are you trying to contact'
options to the form that display appropriate messaged unless the 'FMS
team option is selected.
Add the validation code for this in the cobrand module.
Fixes #41
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In order to allow us to do funnel analysis in google analytics we need
to send a differnt page url when a user completes a report. To do this
we add a report_created=1 to the query string on either the report page
or the report confirmation page for logged in and confirm by email users
respectively.
There's a bit of complication as we don't want to set a session cookie
everywhere as that will break caching so we set a stash variable,
although if the user is logged in this is controlled by a variable in
the flash as there is already a session cookie at this point.
also, removes the code that sends an event upon report completion as
this was no use for funnel analysis.
|
| |
| |
| |
| |
| |
| |
| | |
The test relies on a body for westminster council existing which is
crated in an earlier test if you run the whole test suite. However it's
not present if you run only this test against an empty database so add
it to the list of created bodies.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is useful for sites where the updates aren't published on the site
so you need a bit more context in the email alerts.
Add inlude_time_in_update_alerts to default cobrand, off as default
If this is set then the date is added after the name string in the
email, passing in 'alert' as the type to dt_prettify in order to allow
the cobrand to format it accordingly.
This does require pulling out the alert confirmed time from the database
in the send_alerts code where it wasn't before.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add never_confirm_updates setting to cobrand that, when set to 0 means
that comments are confirmed with no confirmation step. Essentially
behaves as it would if the user was logged in.
Also add a flag to the flash that indicates the comment was accepted to
you can display a message on the report page if required
|
|/
|
|
| |
Make sure mapit_id_whitelist set for tests that submit
|
|
|
|
|
|
|
| |
Fixes #365 (how appropriate) by mocking datetime to allow the
dashboard test's assumptions (that we're not so near beginning
of year that a report from X days ago isn't still in same year)
to hold.
|
|
|
|
| |
Add some comments to the top of the open311 bin scripts.
|
|
|
|
|
| |
Otherwise oddities arise due to summer time differences
putting a BST now-6d23h time behind a UTC now+1s-1w.
|
|
|
|
|
| |
This is very old, no-one seems to want/need it any more,
and more than one reuser does not want it. Fixes #715.
|
| |
|
|
|
|
|
|
| |
This tests that the default string used by the old-style Open311 update
code if there is no incoming string and the report is marked fixed, is
translated.
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
bin/update-schema
locale/sv_SE.UTF-8/LC_MESSAGES/FixMyStreet.po
perllib/FixMyStreet/DB/Result/Body.pm
|
| |
| |
| |
| | |
This could be made cobrand-customisable in future.
|
| |
| |
| |
| |
| |
| | |
This commit reverses the "Remove unused Open311 GetUpdates code." commit.
FixaMinGata, the Swedish FixMyStreet cobrand, is still using
open311-update-reports.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Provide a button to download the details and text of reports
at the second "Look up" button on /dashboard.
Provides acknowledged, fixed, closed dates by parsing updates.
Fixes #692 (and mysociety/FixMyStreet-Commercial#399)
Email is not shown, and name honours anonymous flag: as /dashboard
is accessible to people who are from_body (who still do not see
anon-users name and email in the FMS web app.)
A basic test is provided as per Zurich's similar report.
|
| |
| |
| |
| |
| |
| |
| |
| | |
The tests have been commented out due to long-running failure. It looks
like the failures happen if working copy MAPIT_URL is not pointing at
live site. Have updated with an override_config setting this to live
site (which is obviously suboptimal, but seems to be widespread practice
across t/ at the moment.)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Originally copied from template of Bromley code, substituting logo,
council ID, geolocation data, and renaming .scss variables etc.
(NB: this was a bad idea. As per notes/cobranding.txt, should have
started with less copying of files, as this required more cleanup.
Bromley's code has some particularities, like smaller map, split
First/Last name fields and so on.
The current branch has been rebased to present a slightly idealised
picture of the process.)
(Includes contributions by @davea and @stevenday)
* Some code cleanup and added is_two_tier
* Add Hart-specific links to footer
* Shift FMS nav out of the main header
* Update styling to follow design more closely
* Flip nav colours to better indicate links
* Make header banner entire width of the page
* Stretch footer bg to entire width of page
* Add top-level nav links
* Correct header height on mobile
* Correct wording of top menu item
* Remove FMS logo from top of page
* Shift top level nav to correct position
* Invert media query so IE8 displays header properly
* hide folding triangle, as makes no sense on this cobrand
* Some more renaming of Bromley to Hart
* Treat Hart the same as Bromley in the JS
* Whitespace/formatting fixes
* Basic test for cobrand
* Javascript #map_box fixes
* Make sure #map_box is not in desk-only
* ensure there is only single map (one .wrapper only)
* colour tweaks
* Fix example places (postcode, spelling)
* Basic FAQ text
* Set Zoom level 3
* CSS/HTML/JS tweaks removing Bromley customizations
* Switch templates to put navigation in footer, as FMS.com does
* remaining HTML/CSS changes for large map
* replace favicon
* move site-logo scss to one place
* make small logo transparent
|
|\ \ |
|