aboutsummaryrefslogtreecommitdiffstats
path: root/t
Commit message (Collapse)AuthorAgeLines
* Allow zurich tests to run without network.Matthew Somerville2016-03-23-11/+58
|
* Updates to cpanfile and code for perl 5.20/5.22.Matthew Somerville2016-03-23-35/+70
| | | | | | | | | | | | | | | | | | | | The following modules had bugs that have been fixed for working in recent perls: * List::MoreUtils * Guard * PadWalker * aliased * URI * Convert::NLS_DATE_FORMAT The CGI module was removed from core in 5.20, so include it in the snapshot (I don't think it's actually used, but is a dependency). "{" needs to be escaped in regular expressions, and ~~ should not be used. Fix some tests that expect e.g. a certain hash ordering, to use sorted output or better comparisons.
* Merge branch '1341-friendly-ab-test'Matthew Somerville2016-03-11-0/+6
|\
| * [fixmystreet.com] Friendly A/B test setup.Zarino Zappia2016-03-11-0/+6
| | | | | | | | | | | | | | | | Includes a smiley, bright yellow homepage, and updated nav bar and footer across the entire site; a few content changes; request for gender information from users. Fixes #1341.
* | Fix test that fetched page removed in last commit.Matthew Somerville2016-03-11-2/+2
|/
* Add cobrand-specific custom reporting fields.Matthew Somerville2016-03-09-0/+85
| | | | | | This adds a new cobrand variable, report_form_extras, which contains a list of extra fields that will be saved in the 'extra' metadata of the report. Fields may optionally be marked as required.
* Remember user's last anonymous state.Matthew Somerville2016-03-04-0/+61
| | | | | If a user is logged in, use their last report/update to set the default anonymity state.
* Better handle replies to bounce addresses.Matthew Somerville2016-02-23-0/+20
| | | | | | | | | | Auto unsubscribe alert bounces, forward on report bounces and alert replies to support, and send through to report creator non-bounce replies to their report (for systems that ignore both the From and Reply-To headers). Also forward any totally unparsed bounce to support to possibly then adjust this bounce handling.
* Merge remote-tracking branch 'mysociety/add-osm-link-to-email'Matthew Somerville2016-02-09-18/+11
|\
| * Switch final few JSON uses to JSON::MaybeXS.Matthew Somerville2016-02-09-18/+11
| |
* | Exclude update alerts from summary alert counts.Matthew Somerville2016-02-09-2/+2
|/ | | | | | There might be the odd update alert we are interested in (those not auto-signed up for as part of report or update creation), but they will be rare.
* Merge branch '1315-open311-update-media_url'Matthew Somerville2016-01-29-15/+60
|\
| * Spot media_url in Open311 GetServiceRequestUpdate.Matthew Somerville2016-01-29-0/+45
| | | | | | | | Fixes #1315.
| * Move test mocks to their own directory.Matthew Somerville2016-01-27-15/+15
| |
* | If app user logged in, perform alert signup.Matthew Somerville2016-01-27-0/+38
|/ | | | Thanks to @jonkri for spotting.
* Merge branch '1146-social-login'Matthew Somerville2016-01-27-18/+195
|\ | | | | | | | | | | Conflicts: templates/web/base/report/new/fill_in_details_form.html templates/web/base/report/update-form.html
| * Add tests of social login.Matthew Somerville2016-01-22-0/+195
| |
| * Remove unnecessary shebang lines.Matthew Somerville2016-01-22-18/+0
| |
* | Improve some error pages.Matthew Somerville2016-01-26-1/+1
|/ | | | | Use design of auth/token in generic error, 404, and token server error pages, and use the same error for too old/ token not found errors.
* Add ability to have multiple update photos.Matthew Somerville2016-01-12-32/+92
| | | | Also adds admin ability to rotate update photos.
* Factor multiple photo details into nicer function.Matthew Somerville2016-01-12-2/+9
| | | | | Remove get_photo_params, which only looked at the first photo, make explicit when we're doing that using `.first`.
* Handle multiple photo rotation/removal in admin.Matthew Somerville2016-01-08-1/+2
|
* Fix bug showing reports on Your Reports.Matthew Somerville2015-12-17-1/+6
| | | | | 92dfeac used an incorrect user column name in the new lookup, and there was no test to catch the regression.
* Add multiple photo upload support.Zarino Zappia2015-12-16-35/+78
| | | | | | | | | | Three file inputs, progressively enhanced with dropzone. This moves the photo input higher up, so that photos can upload while you're filling out the form. It standardises and improves photo error handling. [fixmystreet.com] Guidance for what photos should and shouldn’t include.
* Remove risk of infinite loop in PhotoSet.Matthew Somerville2015-12-16-2/+2
| | | | | | Use a separate attribute for data direct from a database row when creating a PhotoSet, so that data will always contain one or more photo IDs.
* Fix cobrand restriction of My/Nearby.Matthew Somerville2015-12-15-6/+62
| | | | | | | | | | | | 5c79337 simplified a bit too far, as after then a particular cobrand could in Nearby and My only filter reports to a particular body, not any other criteria. To fix this, introduce more generic functions in the default cobrand to allow more flexibility. Make sure a few tests delete their bodies fully so that new tests pass when run as part of the suite. Fixes #1289.
* Secret always created as part of test run setup.Matthew Somerville2015-12-15-8/+0
|
* Switch template plugin for nice numbers.Matthew Somerville2015-12-09-1/+18
| | | | | Template::Plugin::Number::Format works internationally, whilst Template::Plugin::Comma does not.
* Move main bin scripts to separate packages.Matthew Somerville2015-12-02-3/+1
| | | | Maintain old location wrappers.
* Remove many uses of mySociety::Config.Matthew Somerville2015-12-02-17/+8
|
* Reduce use of FixMyStreet::App.Matthew Somerville2015-12-02-152/+153
| | | | Command line scripts don't need a full blown app, just database.
* Add generic static route handler.Matthew Somerville2015-10-29-0/+9
| | | | | This puts all static pages under /about, and lets you add new static pages by placing new HTML in your about template directory.
* [Zurich] Set report's public response before sending email to userDave Arter2015-10-06-2/+36
| | | | | | | | The 'public response' to a problem was being omitted from the email sent to the user when the problem is closed, because the email was sent before the report's 'extra' field was updated with the response body text. This commit sets the public response on the problem before sending the email.
* [Zurich] Update de_CH .po fileHakim Cassimally2015-10-06-3/+1
|
* [Zurich] Test that external message is visible for certain statesDave Arter2015-10-06-6/+6
|
* [Zurich] Override MAP_TYPE in tests where appropriateDave Arter2015-10-06-0/+23
|
* [Zurich] Tweaks to redirectHakim Cassimally2015-10-06-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See mysociety/FixMyStreet-Commercial#690 I understand redirection to summary page was introduced at ZWN's request, to make it easy to process reports and then quickly move onto the next one. However, during testing now, Tobias has mentioned this is a) slowing things down and b) confusing because it's not obvious that the report has been saved. I've tried to address (b) by adding the "Aktualisiert!" message when you are redirected. Also, for (a) I've removed the redirection from a few cases, and disabled it for superuser. If need be, I can remove redirection from more (or all) cases. Fix Official answer/Reply to user - hide label for status update on state change - correct wording on button for closure (single wording) - correct wording on label for user reply (either "Official answer" or "Reply to user" as appropriate) - Make sure the official response texts are shown for edit/static as appropriate, and test. - javascript improvements - honour public status update for Extern/Wunsch too - don't show public message for Wunsch - Ignore all other fields when rotating photos. (See mysociety/FixMyStreet-Commercial#718)
* [Zurich] additional closure statuses workHakim Cassimally2015-10-06-96/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Requirements: ============= 1: DM to be able to mark a problem as Wish, Extern, Not contactable, Hidden, Jurisdiction unknown 2: SDM to be able to mark a problem as Not contactable. 3: DM to be able to add information to such a problem, and trigger emails to external agencies, and to user, closing the problem at the same time. 4: Closed reports must be categorized as Wish/Extern/NC/Hidden/JU for statistical reporting 5: Non-closed reports must appear as open, to allow DM to see them in the list, similar to what is currently done for Ruckmeldung Ausstehend (Feedback outstanding). 5b: however "Hidden" problems must be immediately hidden from public view. Proposal: ========= a) Requirement 1 will be carried out in exactly the same way by DM. e.g. Category dropdown select b) Requirement 2 will be carried out in exactly the same way by SDM. e.g. "Not contactable" button c) BUT, for a), c), the category will be diverted to "Ruckmeldung Ausstehend" (Feedback outstanding), and metadata will be saved with the appropriate closure type. d) NOTE: this means the report will still be visible to public as "In bearbeitung" (Except for Hidden reports, as per 5b) e) The extra fields will be presented on the "Ruckmeldung Ausstehend" page, just as defined in the PDF, depending on the metadata. e.g. - Wish: Zustaendige Stelle + Message - Extern: External body + Message2 - Not contactable: (no extra info) - Hidden: (no extra info) - Jurisdiction unknown: (no extra info) f) When the DM publishes the answer (e.g. "Antwort Veroeffentlichen" button), the state will normally change to Fixed. BUT in the new cases, the metadata saved in step c) will be checked, and the report will change state to Wish/Extern/Not contactable/Hidden/Jurisdiction unknown, as appropriate. The report will now be visible/hidden as previously discussed depending on the new state. g) If the report is edited again (in /admin/report_edit) it will be in the relevant state, and any extra fields will be visible as per e). Those fields may be updated. Alternatively, the state may be changed, possibly triggering a) again, and clearing any metadata. - Fix javascript interactions 690 - show new statuses in summary - fix photos on SDM page - fix Planned => Planned+metadata transition - stop "assignation .select" js affecting templates - fix redirection for Extern and generally See mysociety/FixMyStreet-Commercial#672, mysociety/FixMyStreet-Commercial#690
* [Zurich] Updated email templatesMatthew Somerville2015-10-06-15/+6
| | | | | | | - submit-external-wish.txt includes a link with report's coordinates, template values are interpolated Conflicts: perllib/FixMyStreet/SendReport/Zurich.pm
* [Zurich] admin workflow changes available statesHakim Cassimally2015-10-06-172/+262
| | | | | | | | | | | | | | | | | | | | | | | | | | See mysociety/FixMyStreet-Commercial#690 - external_message for Extern/Wunsch states - as per PDF mockups, the "public response" field is now editable from more states, namely: - Ruckmeldung ausstehend - Extern - Zustandigkeit unbekannt - Wunsch - Nicht kontaktierbar - Unsichtbar - test fixes NB: slight hack to reorder Zurich report_display tests As these remove 'investigating' from hidden_states, these break tests for default cobrand (the FMS::App code expects to be called once on request start, not multiple times within one test) - Not contactable button and tests for this and the similar `send_back` functionality (previously untested). NB: Unsure why we need to specify form_number=2 just for these submits, but test won't find the buttons otherwise. - Make sure SDMs' "time_spent" figure is recorded. (See mysociety/FixMyStreet-Commercial#718)
* Add "time spent" admin logging.Hakim Cassimally2015-10-06-3/+21
| | | | | | | | | | | | | | | | | | | | | Mechanism is general, but current implementation only used for Zurich. - Zurich: Record time_spent field mysociety/FixMyStreet-Commercial#676 - template changes (including jQuery spinner) - backend changes to save data are made: - in log_edit, if supplied - and time on category change (and arbitrary actions) - Add update_admin_log to all paths for DM, ensuring that it gets called, while resetting the `time_spent` parameter, to make sure that there is never a duplicate record created. - Also quell warning about using DateTime values in query. - Also add (seemingly unrelated) parens to stop misparsing of OK line in questionnaire test now that DT::Format::Pg is used in Zurich cobrand See mysociety/FixMyStreet-Commercial#676
* [Zurich] Attach images to external bodyHakim Cassimally2015-10-06-1/+103
| | | | See mysociety/FixMyStreet-Commercial#675
* Allow attachment of emails in email_sendHakim Cassimally2015-10-06-9/+120
| | | | Required by Zurich for mysociety/FixMyStreet-Commercial#675
* [Zurich] 'photo required' functionalityDave Arter2015-10-06-0/+36
| | | | | | | | | | | - Save 'photo_required' value in Contact->extra from admin edit form - Enforce per-category photo requirement on new reports A new step has been added to the photo upload process that ensures a photo is present if any of the categories chosen for the report require it. If the photo is missing an error is displayed to the user in the same manner as if the photo upload was invalid. - Add test of mandatory photo categories
* Add support for multiple photos per report.Hakim Cassimally2015-10-06-11/+175
| | | | | | | | For Zurich, see mysociety/FixMyStreet-Commercial#664. This commit includes a new PhotoSet class (NB: called Model:: though not really a model), should handle binary data (e.g. old style photos in database), fileids (40-char hash), and Catalyst::Upload objects.
* [Zurich] all admin users can see statsHakim Cassimally2015-10-06-2/+2
| | | | | | | Admin CR4 https://github.com/mysociety/FixMyStreet-Commercial/issues/673 seems like admin_pages should be able to generate the menu, but this change also needs template change.
* Exclude deleted categories from the all reports page filtersSteven Day2015-10-01-0/+23
|
* Merge remote-tracking branch 'origin/blank-questionnaire-text'Matthew Somerville2015-09-28-0/+10
|\
| * Process update left as part of questionnaire.Matthew Somerville2015-09-28-0/+10
| | | | | | | | | | | | | | Treat an update left during a questionnaire the same as one left on a report page, ie. pass it through cleanup_text. This will also make sure updates left that are wholly whitespace are errored, or replaced with the default text.
* | Send altered confirmation email if not being sent.Matthew Somerville2015-09-28-1/+10
|/ | | | Fixes #1210.
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-26 08:48:53 +0000