| Commit message (Collapse) | Author | Age | Lines |
|
|
|
| |
It was not being caught by rerun_dbic_loader.pl otherwise.
|
| |
|
|
|
|
|
|
|
|
|
| |
Times in the database should be stored in the application server's local
timezone, by e.g. using `current_timestamp`, or by setting that timezone
explicitly before storage (the database columns are all without timezone
so any timezone info is silently ignored). Reports & updates fetched via
Open311 and offline updates were being put into the TIME_ZONE setting if
present, meaning they were stored incorrectly for future usage.
|
| |
|
| |
|
|
|
|
|
| |
If an update has a fixmystreet id in it check that it looks like an
integer and if not issue a warning and skip the update.
|
|
|
|
|
|
| |
Prevent people from using very long titles.
Fixes mysociety/fixmystreet-commercial#1344
|
|\ |
|
| | |
|
|/ |
|
| |
|
| |
|
|
|
|
| |
Fixes mysociety/fixmystreet-commercial#1306
|
|\ |
|
| |
| |
| |
| |
| | |
The test has to now create a new comment object each time as
`get_cobrand_logged` is cached on the object.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If an update has a fixmystreet_id field then use the contents of that in
preference to the external_id field to match an update to a problem.
This handles the case where a report in a third party system passes
through different types (eg inspection and defect), resulting in the
external id changing. In this case it is sometimes possible to include
the fixmystreet id in each type and hence use that to match things up at
the fixmystreet side.
|
| |
| |
| |
| |
| | |
If an Open311 server returned an empty set of values, it was possible
for this template to then display a set of empty dropdown options.
|
| |
| |
| |
| |
| | |
Otherwise running on a site where one body ID is a substring
of another, comments can get processed for the wrong body.
|
|/
|
|
|
| |
After the change in 1cff2a0e, we need to make sure this is set
so that the relevant fields are not shown in the front end.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without doing this, a call to e.g. $contact->set_extra_fields(@meta)
in PopulateServiceList.pm, with an unchanged meta that contains some
Unicode values, can write to the database (and cause an unneeded row
in the history table), because the column from the database is UTF-8
decoded, whilst the new text is UTF-8 encoded.
It looks like an attempt was made in filter_from_storage to fix this
issue, but the column comparison for marking a column as dirty takes
place without this being called.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On some UK council cobrands, some reports listed might not have been sent
to that council, so links to those must go to the national site. However,
using absolute URLs for all these reports means that sometimes you change
domain when you don't need to (eg. if you’re on osm.fixmystreet.com or an
aliased version of the site), which can cause confusion. State when we’re
happy to use a relative link (ie. web-facing report links, not emails, or
share links) and do that when we can.
|
|/ |
|
|\ |
|
| | |
|
| | |
|
|/ |
|
|\ |
|
| |
| |
| |
| | |
Unused right now, but will be soon, for the duplicate suggestion UI.
|
| | |
|
| | |
|
|/ |
|
| |
|
|
|
|
|
|
|
| |
The “Get updates” flow on a report page, if logged in, was showing
an input label but no input field (because one is not needed), but
then on submission asking for your email address. Add missing name
on submit button to fix this.
|
| |
|
|
|
|
|
|
| |
Update database to store an array of IDs rather than only one;
consequential changes to the admin and the dashboard to allow
selection.
|
|
|
|
|
|
|
| |
Similarly to 1f69e28c, we were previously only checking the first
matching entry, which led to confusing behaviour in places. Include
consequential amendments for e.g. one body being unresponsive, the
other not.
|
| |
|
| |
|
|
|
|
|
|
| |
Remove the server-side zoom-in-url fix, instead use an ArgParser
subclass to default to the provided data if nothing in URL. Then
we can switch to using short lat/lon in geocoder URLs.
|
| |
|
|
|
|
|
| |
If someone tries to moderate after someone else has, re-show the
form and an error.
|
|
|
|
|
|
|
|
| |
This adds a question to check whether a flytipping report concerns
flytipping on a road or not. Client-side, it is asked when a road is
selected and destination adjusted according to the answer; server side
it uses the answer to direct any both-tier submissions (from e.g.
non-JavaScript or phone app).
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
If a state is passed in (on a cobrand), update problem state and add a
comment to record this (as state changes are updates not moderations).
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
If the user has moderating permission, or a cobrand allows the viewing
of moderation history, show moderation history within the updates on a
report page.
|
|/
|
|
|
|
|
| |
Add in validation to check names, email and phone numbers don't exceed
maximum lengths permitted by HIAMS.
Fixes mysociety/fixmystreet-commercial#1244
|
| |
|