| Commit message (Collapse) | Author | Age | Lines |
| |
|
| |
|
|
|
|
| |
No need for bullets here, nor margins above/below each label.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Shared margin rules for `.box-warning` and `.extra-category-questions`
in `_base.scss` and `_layout.scss` (where the margin can potentially
change based on the `$mappage-sidebar-padding` variable).
* Move the Sass rules for `.box-warning` further up `_base.scss` to be
next to `.extra-category-questions` since they’re both so similar.
* No need for `.full-width` on the `.extra-category-questions` div since
we were overriding the margin-top anyway.
* Remove the little triangle between the category select box and the
grey `.extra-category-questions` div, since the category questions
isn’t always presented immediately after the category select box.
|
|
|
|
|
|
|
|
| |
When an expanded list item has a single image, it would previously float
to the right of the list item action buttons, which looked messy.
Now, the buttons clear below the floated image, just like the buttons in
the individual report page `.problem-header`.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the expandable list item’s expanded state look more like the
regular `.problem-header`, to more strongly imply that you don’t need
to visit the individual report page to read more.
Since expandable list items now *always* contain more information in
their expanded state, there’s no need for the `show_more` flag in the
templates.
Addresses part of the feedback in mysociety/fixmystreet-commercial#1304.
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce the space between checkbox and label, so the text isn't lost if
the page is zoomed in. Fixes #2411.
Replace the creator_fixed question with segmented control to match the
full questionnaire, and the admin verified checkboxes with inline-text
as they need no padding. Having done that, all uses of .inline are now
on their own lines, so no post-padding is needed any longer, but we’ll
leave some in case of future use.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previously staff-only fixmystreet.set_up.manage_duplicates() has
been promoted from staff.js to its own file so that we can use it to
display the duplicate suggestions on the `/report/new` form.
render_duplicate_list (the old refresh_duplicate_list) no longer filters
or slices the reports_list returned by the ajax call, since it turns out
the server handles all of that (`sub _nearby_json` in `Report.pm` and
`sub nearby` in `Nearby.pm`).
Since the expandable list items include the "fancybox" image previews,
the fancybox CSS now has to be included in the `/report/new` page head,
hence the addition of "photo-js.html" in `fill_in_details.html`.
The “Get updates” flow reuses the same JavaScript that handles the
submission of the "Get updates" drawer at the bottom of around pages.
|
|
|
|
|
| |
There’s no need for this `--reports` to be there, so let’s start phasing
it out.
|
|
|
|
|
|
|
|
|
|
| |
`_item_expandable.html` is an alternative to regular list items, where
you can display extra information on the first click on the item, and
then also, optionally, offer a further action, as a separate button.
Right now the expandable list items aren’t used anywhere, but we’ll
soon be using them in the duplicate report suggestion UI for council
staff and the public.
|
|
|
|
|
| |
Moving the 4em padding from _layout.scss to _base.scss helps separate
the content on /report/<id> and /report/new pages from the nav below.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Simplify markup required for the status banner.
* Simplify styles - the banner is now identical on all screen sizes.
* Move the banner from `report/display.html` into `report/_main.html`
so that it can appear after `.problem-back` in the source order.
* Use real pin icon instead of `pin-flat-white-small.png`.
* Set a default `$col_fixed_label` colour in `_base.scss`, so cobrands
don’t have to define it themselves if they’re happy with green.
* Introduce `$col_fixed_label_light`, with a sensible default for all
cobrands, even ones that have a custom `$col_fixed_label`.
* Remove `$col_fixed_label_dark` – no longer needed.
|
|\ |
|
| |
| |
| |
| | |
Co-authored-by: Zarino Zappia <zarino@mysociety.org>
|
| | |
|
| |
| |
| |
| |
| |
| | |
This was a cute space-saving feature at the time, but the layout made it
look like the button was specific to that input, rather than submitting
the whole form. Make similar buttons full width, and improve spacing.
|
|/ |
|
|
|
|
|
|
|
| |
Includes an option to send to the council instead for e.g. reports on
underpasses or bridges.
Fixes #736
|
| |
|
|
|
|
| |
.btn--social doesn't do anything, and neither do the text-transforms.
|
|
|
|
|
|
|
|
|
| |
The intention of .btn--block is to make the element full width. Because
of the weird way browsers handle sizing of form elements, just setting
`display: block` on `<button>` and `<input type="submit">` elements
wasn’t making them full width. Instead, .btn--block needed to explicitly
set a 100% width, and then reset any margins or box-sizing issues that
might cause it to overflow its parent.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the "Report a problem" link in the nav bar links, more often
than not, to the reporting form rather than the homepage, it could be
challenging to actually start a new report in a location *other* than
the one currently on screen.
Rather than adding a link to the homepage, this change hopefully adds
a link right at the moment the user expects it – right on the "Report
a problem" form.
It also gave us an opportunity to reword the "Wrong location" message
and give it an icon more suitable for high-dpi displays.
Fixes #2238.
|
|
|
|
| |
This reverts commit ee3c4e05daf3f4df01762ead3d07697a12f13a28.
|
|
|
|
|
| |
Anything using old names should still work as long as they included the
mixins file.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the "Report a problem" link in the nav bar links, more often
than not, to the reporting form rather than the homepage, it could be
challenging to actually start a new report in a location *other* than
the one currently on screen.
Rather than adding a link to the homepage, this change hopefully adds
a link right at the moment the user expects it – right on the "Report
a problem" form.
It also gave us an opportunity to reword the "Wrong location" message
and give it an icon more suitable for high-dpi displays.
Fixes #2238.
|
|
|
|
| |
So version 2.4.1 has no translation changes, putting back straight after.
|
|
|
|
|
|
|
|
|
|
|
| |
The large negative text-indent can sometimes cause horizontal scrollbars
in Right-to-Left languages, and, in some browsers, can also result in a
huge :focus outline being drawn around the button and off to the right
of the window.
Setting a zero height, padding top, and overflow:hidden is a simpler
way to achieve the same thing, and works regardless of text direction,
text length, or focus state.
|
|
|
|
| |
There is no need for #front_stats to always be nested inside of #front-howto.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the "Report a problem" link in the nav bar links, more often
than not, to the reporting form rather than the homepage, it could be
challenging to actually start a new report in a location *other* than
the one currently on screen.
Rather than adding a link to the homepage, this change hopefully adds
a link right at the moment the user expects it – right on the "Report
a problem" form.
It also gave us an opportunity to reword the "Wrong location" message
and give it an icon more suitable for high-dpi displays.
Fixes #2238.
|
| |
|
|\ |
|
| | |
|
|/
|
|
|
|
|
| |
Part of #2012.
Should make it much quicker to report multiple problems in the same
location, one after the other.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2180.
Input placeholders are a generally problematic UI convention, and we’ve
accidentally started using them in more and more parts of FMS over the
last few years.
In some cases, the placeholders simply repeated text from the input’s
existing label element. In cases like those, the placeholder attribute
could just be removed.
In other cases, we broke the placeholder text out into a .form-hint
element, between the input and its label, so that the text is easily
accessible and falls into the top-to-bottom reading flow.
Notable changes:
* Form hint on main postcode search form, instead of placeholder.
* Form hint on alert search form, instead of placeholder.
* Form hints in reporting form (problem summary and description),
instead of placeholders.
* Removed placeholders from most login/password inputs.
* The character limit for "Inspector" report updates is no longer
displayed in the textarea placeholder.
* Form hints now `#666` grey, and better spaced when immediately
following a label element.
|
| |
|
|
|
|
| |
This was caused by the header overlapping the state banner
|
|\ |
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
Useful for simple tables like the cookie lists on Privacy Policy pages.
|
|
|
|
| |
Fixes #2124.
|
|
|
|
| |
Fixes mysociety/fixmystreetforcouncils#231
|